[HDFS-6578] add toString method to DatanodeStorage for easier debugging

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.5.0
• Target Version/s: 2.5.0
• Hadoop Flags: Reviewed
• Assignee: Yongjun Zhang Assign to me
• Reporter: Yongjun Zhang
• Created: 20/Jun/14 17:36
• Updated: 03/Sep/14 20:34
• Resolved: 23/Jun/14 21:32

Description

It seems to be nice to add a toString() method for DatanodeStorage class, so we can print out its key info easier while doing debuging.

Another thing is, in the end of BlockManager#processReport, there is the following message,

   blockLog.info("BLOCK* processReport: from storage " + storage.getStorageID()
        + " node " + nodeID + ", blocks: " + newReport.getNumberOfBlocks()
        + ", processing time: " + (endTime - startTime) + " msecs");
    return !node.hasStaleStorages();

We could add node.hasStaleStorages() to the log, and possibly replace storage.getSorateID() with the suggested storage.toString().

Any comments? thanks.