Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.6.0
    • Component/s: None
    • Labels:
      None

      Description

      When compiling native code on macosx using clang, compiler find more warning and errors which gcc ignores, those should be fixed.

      1. HDFS-6534.v1.patch
        10 kB
        Binglin Chang
      2. HDFS-6534.v2.patch
        10 kB
        Binglin Chang
      3. HDFS-6534.v3.patch
        8 kB
        Binglin Chang

        Issue Links

          Activity

          Hide
          decster Binglin Chang added a comment -

          Changes:
          1. fix bug in memset(hdfsFileInfo...)
          2. use PRId64 instead of %ld to prevent compile warning
          3. emulate clock_gettime/sem_init/sem_destroy on macosx
          4. remove -lrt on macosx in CMakeLists.txt

          Show
          decster Binglin Chang added a comment - Changes: 1. fix bug in memset(hdfsFileInfo...) 2. use PRId64 instead of %ld to prevent compile warning 3. emulate clock_gettime/sem_init/sem_destroy on macosx 4. remove -lrt on macosx in CMakeLists.txt
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12650517/HDFS-6534.v1.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified test files.

          -1 javac. The patch appears to cause the build to fail.

          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7129//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12650517/HDFS-6534.v1.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified test files. -1 javac . The patch appears to cause the build to fail. Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7129//console This message is automatically generated.
          Hide
          decster Binglin Chang added a comment -

          FIx a minor typo causing linux build failed

          Show
          decster Binglin Chang added a comment - FIx a minor typo causing linux build failed
          Hide
          hadoopqa Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12650756/HDFS-6534.v2.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/7329//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7329//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12650756/HDFS-6534.v2.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/7329//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7329//console This message is automatically generated.
          Hide
          aw Allen Wittenauer added a comment -

          Binglin Chang, any chance for a rebase?

          Thanks!

          Show
          aw Allen Wittenauer added a comment - Binglin Chang , any chance for a rebase? Thanks!
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12650756/HDFS-6534.v2.patch
          against trunk revision b93d960.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8174//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12650756/HDFS-6534.v2.patch against trunk revision b93d960. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8174//console This message is automatically generated.
          Hide
          decster Binglin Chang added a comment -

          Thanks for the notice Allen. Attach new version of the patch.

          Show
          decster Binglin Chang added a comment - Thanks for the notice Allen. Attach new version of the patch.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12670893/HDFS-6534.v3.patch
          against trunk revision ef784a2.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

          org.apache.hadoop.hdfs.TestEncryptionZonesWithKMS
          org.apache.hadoop.hdfs.server.namenode.ha.TestPipelinesFailover

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/8177//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8177//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12670893/HDFS-6534.v3.patch against trunk revision ef784a2. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.TestEncryptionZonesWithKMS org.apache.hadoop.hdfs.server.namenode.ha.TestPipelinesFailover +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/8177//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8177//console This message is automatically generated.
          Hide
          aw Allen Wittenauer added a comment -

          +1 LGTM. Committing to branch-2 and trunk.

          Thanks!

          Show
          aw Allen Wittenauer added a comment - +1 LGTM. Committing to branch-2 and trunk. Thanks!
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #691 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/691/)
          HDFS-6534. Fix build on macosx: HDFS parts (Binglin Chang via aw) (aw: rev cb74f39697b57ec1189073fe128ce5ed3e7d73f0)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/native/libhdfs/test_libhdfs_threaded.c
          • hadoop-hdfs-project/hadoop-hdfs/src/main/native/libhdfs/test/vecsum.c
          • hadoop-hdfs-project/hadoop-hdfs/src/CMakeLists.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/native/libhdfs/hdfs.c
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/native/libhdfs/test/test_libhdfs_ops.c
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #691 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/691/ ) HDFS-6534 . Fix build on macosx: HDFS parts (Binglin Chang via aw) (aw: rev cb74f39697b57ec1189073fe128ce5ed3e7d73f0) hadoop-hdfs-project/hadoop-hdfs/src/main/native/libhdfs/test_libhdfs_threaded.c hadoop-hdfs-project/hadoop-hdfs/src/main/native/libhdfs/test/vecsum.c hadoop-hdfs-project/hadoop-hdfs/src/CMakeLists.txt hadoop-hdfs-project/hadoop-hdfs/src/main/native/libhdfs/hdfs.c hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/native/libhdfs/test/test_libhdfs_ops.c
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Hdfs-trunk #1882 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1882/)
          HDFS-6534. Fix build on macosx: HDFS parts (Binglin Chang via aw) (aw: rev cb74f39697b57ec1189073fe128ce5ed3e7d73f0)

          • hadoop-hdfs-project/hadoop-hdfs/src/CMakeLists.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/native/libhdfs/hdfs.c
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/native/libhdfs/test_libhdfs_threaded.c
          • hadoop-hdfs-project/hadoop-hdfs/src/main/native/libhdfs/test/vecsum.c
          • hadoop-hdfs-project/hadoop-hdfs/src/main/native/libhdfs/test/test_libhdfs_ops.c
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #1882 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1882/ ) HDFS-6534 . Fix build on macosx: HDFS parts (Binglin Chang via aw) (aw: rev cb74f39697b57ec1189073fe128ce5ed3e7d73f0) hadoop-hdfs-project/hadoop-hdfs/src/CMakeLists.txt hadoop-hdfs-project/hadoop-hdfs/src/main/native/libhdfs/hdfs.c hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/native/libhdfs/test_libhdfs_threaded.c hadoop-hdfs-project/hadoop-hdfs/src/main/native/libhdfs/test/vecsum.c hadoop-hdfs-project/hadoop-hdfs/src/main/native/libhdfs/test/test_libhdfs_ops.c
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #1907 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1907/)
          HDFS-6534. Fix build on macosx: HDFS parts (Binglin Chang via aw) (aw: rev cb74f39697b57ec1189073fe128ce5ed3e7d73f0)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/native/libhdfs/test/vecsum.c
          • hadoop-hdfs-project/hadoop-hdfs/src/main/native/libhdfs/test/test_libhdfs_ops.c
          • hadoop-hdfs-project/hadoop-hdfs/src/CMakeLists.txt
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/native/libhdfs/test_libhdfs_threaded.c
          • hadoop-hdfs-project/hadoop-hdfs/src/main/native/libhdfs/hdfs.c
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #1907 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1907/ ) HDFS-6534 . Fix build on macosx: HDFS parts (Binglin Chang via aw) (aw: rev cb74f39697b57ec1189073fe128ce5ed3e7d73f0) hadoop-hdfs-project/hadoop-hdfs/src/main/native/libhdfs/test/vecsum.c hadoop-hdfs-project/hadoop-hdfs/src/main/native/libhdfs/test/test_libhdfs_ops.c hadoop-hdfs-project/hadoop-hdfs/src/CMakeLists.txt hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/native/libhdfs/test_libhdfs_threaded.c hadoop-hdfs-project/hadoop-hdfs/src/main/native/libhdfs/hdfs.c

            People

            • Assignee:
              decster Binglin Chang
              Reporter:
              decster Binglin Chang
            • Votes:
              1 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development