Details

      Description

      Test file write/read, syncable, positioned read, seek and others for Crypto streams.

      1. HDFS-6405.patch
        8 kB
        Yi Liu
      2. HDFS-6405.5.patch
        5 kB
        Yi Liu
      3. HDFS-6405.4.patch
        4 kB
        Yi Liu
      4. HDFS-6405.3.patch
        4 kB
        Yi Liu
      5. HDFS-6405.2.patch
        4 kB
        Yi Liu
      6. HDFS-6405.1.patch
        14 kB
        Yi Liu

        Issue Links

          Activity

          Hide
          Yi Liu added a comment -

          This test case is to verify basic functionality for crypto streams in HADOOP-10603.

          Show
          Yi Liu added a comment - This test case is to verify basic functionality for crypto streams in HADOOP-10603 .
          Hide
          Yi Liu added a comment -

          1. Test crypto file writing with different buffer size.
          2. Test crypto file reading with different buffer size.
          3. Test hflush/hsync of crypto output stream, and with different buffer size.
          4. Test positioned read of crypto file.
          5. Test seek to different positions for crypto file.
          6. Test get file position of crypto file.
          7. Test skip operations for crypto file.

          Show
          Yi Liu added a comment - 1. Test crypto file writing with different buffer size. 2. Test crypto file reading with different buffer size. 3. Test hflush/hsync of crypto output stream, and with different buffer size. 4. Test positioned read of crypto file. 5. Test seek to different positions for crypto file. 6. Test get file position of crypto file. 7. Test skip operations for crypto file.
          Hide
          Yi Liu added a comment -

          Refine TestHdfsCryptoStreams extends CryptoStreamsTestBase.

          Show
          Yi Liu added a comment - Refine TestHdfsCryptoStreams extends CryptoStreamsTestBase .
          Hide
          Yi Liu added a comment -

          HDFS side test cases for Crypto streams.

          Show
          Yi Liu added a comment - HDFS side test cases for Crypto streams.
          Hide
          Andrew Wang added a comment -

          Hi Yi, overall looks good, few small comments:

          • writeCheck has an unused parameter Path file
          • shutdown, put a space after if, feel free to just run the auto-formatter on this file
          • Any reason we couldn't just fold testFileWrite into CryptoStreamsTestBase? We could do an instanceof FSDataOutputStream check. I also see that the subclasses @Ignore out unsupported tests, which is another option.
          Show
          Andrew Wang added a comment - Hi Yi, overall looks good, few small comments: writeCheck has an unused parameter Path file shutdown, put a space after if , feel free to just run the auto-formatter on this file Any reason we couldn't just fold testFileWrite into CryptoStreamsTestBase? We could do an instanceof FSDataOutputStream check. I also see that the subclasses @Ignore out unsupported tests, which is another option.
          Hide
          Yi Liu added a comment -

          Andrew Wang, thanks for your good comments. I update the patch for them.

          Show
          Yi Liu added a comment - Andrew Wang , thanks for your good comments. I update the patch for them.
          Hide
          Andrew Wang added a comment -

          +1 thanks Yi, I committed this to the branch.

          Show
          Andrew Wang added a comment - +1 thanks Yi, I committed this to the branch.

            People

            • Assignee:
              Yi Liu
              Reporter:
              Yi Liu
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development