Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 2.5.0
    • Fix Version/s: 2.5.0
    • Component/s: tools
    • Labels:
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      HDFS-6293 added "hdfs oiv_legacy" command to view a legacy fsimage, but cannot execute the command.
      In hdfs,

      elif [ "COMMAND" = "oiv_legacy" ] ; then
        CLASS=org.apache.hadoop.hdfs.tools.offlineImageViewer.OfflineImageViewer
      

      should be

      elif [ "$COMMAND" = "oiv_legacy" ] ; then
        CLASS=org.apache.hadoop.hdfs.tools.offlineImageViewer.OfflineImageViewer
      
      1. HDFS-6400.patch
        0.7 kB
        Akira AJISAKA
      2. HDFS-6400.2.patch
        2 kB
        Akira AJISAKA

        Issue Links

          Activity

          Hide
          Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #1780 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1780/)
          HDFS-6400. Cannot execute hdfs oiv_legacy. Contributed by Akira AJISAKA. (kihwal: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1594917)

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageViewer.java
          Show
          Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #1780 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1780/ ) HDFS-6400 . Cannot execute hdfs oiv_legacy. Contributed by Akira AJISAKA. (kihwal: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1594917 ) /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageViewer.java
          Hide
          Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #1754 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1754/)
          HDFS-6400. Cannot execute hdfs oiv_legacy. Contributed by Akira AJISAKA. (kihwal: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1594917)

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageViewer.java
          Show
          Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #1754 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1754/ ) HDFS-6400 . Cannot execute hdfs oiv_legacy. Contributed by Akira AJISAKA. (kihwal: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1594917 ) /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageViewer.java
          Hide
          Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #562 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/562/)
          HDFS-6400. Cannot execute hdfs oiv_legacy. Contributed by Akira AJISAKA. (kihwal: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1594917)

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageViewer.java
          Show
          Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #562 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/562/ ) HDFS-6400 . Cannot execute hdfs oiv_legacy. Contributed by Akira AJISAKA. (kihwal: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1594917 ) /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageViewer.java
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in Hadoop-trunk-Commit #5605 (See https://builds.apache.org/job/Hadoop-trunk-Commit/5605/)
          HDFS-6400. Cannot execute hdfs oiv_legacy. Contributed by Akira AJISAKA. (kihwal: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1594917)

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageViewer.java
          Show
          Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #5605 (See https://builds.apache.org/job/Hadoop-trunk-Commit/5605/ ) HDFS-6400 . Cannot execute hdfs oiv_legacy. Contributed by Akira AJISAKA. (kihwal: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1594917 ) /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageViewer.java
          Hide
          Kihwal Lee added a comment -

          Thanks for spotting and fixing the bug quickly, Akira. I've committed this to trunk and branch-2.

          Show
          Kihwal Lee added a comment - Thanks for spotting and fixing the bug quickly, Akira. I've committed this to trunk and branch-2.
          Hide
          Kihwal Lee added a comment -

          The precommit is not running, so I manually verified that there is no new javac or javadoc warning with the patch applied. Unit tests won't be affected since the change only involves content of existing string and a shell command that is not directly executed from tests.

          Show
          Kihwal Lee added a comment - The precommit is not running, so I manually verified that there is no new javac or javadoc warning with the patch applied. Unit tests won't be affected since the change only involves content of existing string and a shell command that is not directly executed from tests.
          Hide
          Kihwal Lee added a comment -

          Sorry, I've only tested it programmatically.
          +1 The patch looks good.

          Show
          Kihwal Lee added a comment - Sorry, I've only tested it programmatically. +1 The patch looks good.
          Hide
          Akira AJISAKA added a comment -

          Updated the usage of OfflineImageViewer.java

          Show
          Akira AJISAKA added a comment - Updated the usage of OfflineImageViewer.java
          Hide
          Akira AJISAKA added a comment -

          Attaching a patch.

          Show
          Akira AJISAKA added a comment - Attaching a patch.

            People

            • Assignee:
              Akira AJISAKA
              Reporter:
              Akira AJISAKA
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development