Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-6364

Incorrect check for unknown datanode in Balancer

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.4.0
    • Fix Version/s: 2.5.0
    • Component/s: balancer & mover
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      The Balancer makes a check to see if a block's location is known datanode. But the variable it uses to check is wrong.

      1. HDFS-6364.patch
        0.9 kB
        Benoy Antony
      2. HDFS-6364.patch
        0.9 kB
        Benoy Antony
      3. HDFS-6364-6441.patch
        4 kB
        Benoy Antony

        Issue Links

          Activity

          Allen Wittenauer made changes -
          Fix Version/s 3.0.0 [ 12320356 ]
          Karthik Kambatla (Inactive) made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Benoy Antony made changes -
          Link This issue is depended upon by HDFS-6798 [ HDFS-6798 ]
          Benoy Antony made changes -
          Link This issue is related to HDFS-6441 [ HDFS-6441 ]
          Hide
          Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #1798 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1798/)
          HDFS-6364. Incorrect check for unknown datanode in Balancer. (Contributed by Benoy Antony) (arp: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1601771)

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Balancer.java
          Show
          Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #1798 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1798/ ) HDFS-6364 . Incorrect check for unknown datanode in Balancer. (Contributed by Benoy Antony) (arp: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1601771 ) /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Balancer.java
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Hdfs-trunk #1771 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1771/)
          HDFS-6364. Incorrect check for unknown datanode in Balancer. (Contributed by Benoy Antony) (arp: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1601771)

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Balancer.java
          Show
          Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #1771 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1771/ ) HDFS-6364 . Incorrect check for unknown datanode in Balancer. (Contributed by Benoy Antony) (arp: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1601771 ) /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Balancer.java
          Hide
          Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #580 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/580/)
          HDFS-6364. Incorrect check for unknown datanode in Balancer. (Contributed by Benoy Antony) (arp: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1601771)

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Balancer.java
          Show
          Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #580 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/580/ ) HDFS-6364 . Incorrect check for unknown datanode in Balancer. (Contributed by Benoy Antony) (arp: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1601771 ) /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Balancer.java
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in Hadoop-trunk-Commit #5678 (See https://builds.apache.org/job/Hadoop-trunk-Commit/5678/)
          HDFS-6364. Incorrect check for unknown datanode in Balancer. (Contributed by Benoy Antony) (arp: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1601771)

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Balancer.java
          Show
          Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #5678 (See https://builds.apache.org/job/Hadoop-trunk-Commit/5678/ ) HDFS-6364 . Incorrect check for unknown datanode in Balancer. (Contributed by Benoy Antony) (arp: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1601771 ) /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Balancer.java
          Arpit Agarwal made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Hadoop Flags Reviewed [ 10343 ]
          Target Version/s 2.5.0 [ 12326264 ]
          Fix Version/s 3.0.0 [ 12320356 ]
          Fix Version/s 2.5.0 [ 12326264 ]
          Resolution Fixed [ 1 ]
          Hide
          Arpit Agarwal added a comment -

          I committed this to trunk and branch-2. Thanks for finding and fixing this Benoy Antony!

          Show
          Arpit Agarwal added a comment - I committed this to trunk and branch-2. Thanks for finding and fixing this Benoy Antony !
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12649629/HDFS-6364.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/7076//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7076//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12649629/HDFS-6364.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/7076//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7076//console This message is automatically generated.
          Hide
          Arpit Agarwal added a comment -

          +1 pending Jenkins.

          Per discussion with Benoy he will include the test case in a separate Jira due to the dependence on HDFS-6441.

          Show
          Arpit Agarwal added a comment - +1 pending Jenkins. Per discussion with Benoy he will include the test case in a separate Jira due to the dependence on HDFS-6441 .
          Benoy Antony made changes -
          Attachment HDFS-6364.patch [ 12649629 ]
          Hide
          Benoy Antony added a comment -

          Attaching the newer patch

          Show
          Benoy Antony added a comment - Attaching the newer patch
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12646688/HDFS-6364-6441.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          -1 javac. The patch appears to cause the build to fail.

          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6973//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12646688/HDFS-6364-6441.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. -1 javac . The patch appears to cause the build to fail. Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6973//console This message is automatically generated.
          Hide
          Benoy Antony added a comment -

          If there is a way to simulate this without depending on HDFS-6441 , please let me know and I can add it .

          Show
          Benoy Antony added a comment - If there is a way to simulate this without depending on HDFS-6441 , please let me know and I can add it .
          Benoy Antony made changes -
          Attachment HDFS-6364-6441.patch [ 12646688 ]
          Hide
          Benoy Antony added a comment -

          Attaching test case based on HDFS-6441.
          Without HDFS-6441, it is tough to simulate the condition where the block's location is an unknown node.

          Show
          Benoy Antony added a comment - Attaching test case based on HDFS-6441 . Without HDFS-6441 , it is tough to simulate the condition where the block's location is an unknown node.
          Hide
          Arpit Agarwal added a comment -

          Nice catch. Is it feasible to add a test case?

          Show
          Arpit Agarwal added a comment - Nice catch. Is it feasible to add a test case?
          Hide
          Benoy Antony added a comment -

          Haohui Mai, Could you please take a look at this bug ?

          Show
          Benoy Antony added a comment - Haohui Mai , Could you please take a look at this bug ?
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12644087/HDFS-6364.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

          org.apache.hadoop.hdfs.TestSafeMode

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/6871//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6871//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12644087/HDFS-6364.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.TestSafeMode +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/6871//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6871//console This message is automatically generated.
          Benoy Antony made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Benoy Antony made changes -
          Field Original Value New Value
          Attachment HDFS-6364.patch [ 12644087 ]
          Hide
          Benoy Antony added a comment -

          The attached uses the correct variable.

          Show
          Benoy Antony added a comment - The attached uses the correct variable.
          Benoy Antony created issue -

            People

            • Assignee:
              Benoy Antony
              Reporter:
              Benoy Antony
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development