Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-6337

Setfacl testcase is failing due to dash character in username in TestAclCLI

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0
    • Fix Version/s: 2.5.0
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      TestHDFSCLI is failing due to a '-' in username.

      I have seen the similar fix done in HDFS-5821. So, same fix should be done for setfacl case as well.

      1. HDFS-6337.patch
        0.8 kB
        Uma Maheswara Rao G

        Activity

        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #1751 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1751/)
        HDFS-6337. Setfacl testcase is failing due to dash character in username in TestAclCLI. Contributed by Uma Maheswara Rao G. (umamahesh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1592489)

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testAclCLI.xml
        Show
        Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #1751 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1751/ ) HDFS-6337 . Setfacl testcase is failing due to dash character in username in TestAclCLI. Contributed by Uma Maheswara Rao G. (umamahesh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1592489 ) /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testAclCLI.xml
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk #559 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/559/)
        HDFS-6337. Setfacl testcase is failing due to dash character in username in TestAclCLI. Contributed by Uma Maheswara Rao G. (umamahesh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1592489)

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testAclCLI.xml
        Show
        Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #559 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/559/ ) HDFS-6337 . Setfacl testcase is failing due to dash character in username in TestAclCLI. Contributed by Uma Maheswara Rao G. (umamahesh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1592489 ) /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testAclCLI.xml
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in Hadoop-trunk-Commit #5593 (See https://builds.apache.org/job/Hadoop-trunk-Commit/5593/)
        HDFS-6337. Setfacl testcase is failing due to dash character in username in TestAclCLI. Contributed by Uma Maheswara Rao G. (umamahesh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1592489)

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testAclCLI.xml
        Show
        Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #5593 (See https://builds.apache.org/job/Hadoop-trunk-Commit/5593/ ) HDFS-6337 . Setfacl testcase is failing due to dash character in username in TestAclCLI. Contributed by Uma Maheswara Rao G. (umamahesh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1592489 ) /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testAclCLI.xml
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #1775 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1775/)
        HDFS-6337. Setfacl testcase is failing due to dash character in username in TestAclCLI. Contributed by Uma Maheswara Rao G. (umamahesh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1592489)

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testAclCLI.xml
        Show
        Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #1775 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1775/ ) HDFS-6337 . Setfacl testcase is failing due to dash character in username in TestAclCLI. Contributed by Uma Maheswara Rao G. (umamahesh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1592489 ) /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testAclCLI.xml
        Hide
        Uma Maheswara Rao G added a comment -

        Thanks Vinay for the review!. I have just committed this to trunk and branch-2.

        Show
        Uma Maheswara Rao G added a comment - Thanks Vinay for the review!. I have just committed this to trunk and branch-2.
        Hide
        Vinayakumar B added a comment -

        patch looks good. +1

        Show
        Vinayakumar B added a comment - patch looks good. +1
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12643273/HDFS-6337.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/6809//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6809//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12643273/HDFS-6337.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/6809//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6809//console This message is automatically generated.
        Hide
        Uma Maheswara Rao G added a comment -

        Here is a simple patch to fix the issue. [fix is same as HDFS-5821]

        Show
        Uma Maheswara Rao G added a comment - Here is a simple patch to fix the issue. [fix is same as HDFS-5821]
        Hide
        Uma Maheswara Rao G added a comment -

        I have seen this failure when I test the HDFS-2006 branch. SO, same should apply for trunk as well.

        2014-05-03 21:35:30,346 INFO  cli.CLITestHelper (CLITestHelper.java:displayResults(156)) -                     Test ID: [20]
        2014-05-03 21:35:30,346 INFO  cli.CLITestHelper (CLITestHelper.java:displayResults(157)) -            Test Description: [ls: display extended acl marker]
        2014-05-03 21:35:30,346 INFO  cli.CLITestHelper (CLITestHelper.java:displayResults(158)) - 
        2014-05-03 21:35:30,346 INFO  cli.CLITestHelper (CLITestHelper.java:displayResults(162)) -               Test Commands: [-fs hdfs://localhost:33753 -mkdir -p /dir1/dir2]
        2014-05-03 21:35:30,347 INFO  cli.CLITestHelper (CLITestHelper.java:displayResults(162)) -               Test Commands: [-fs hdfs://localhost:33753 -setfacl -m user:charlie:rwx,group::-wx,group:sales:rwx,mask::r-x,default:user:charlie:rwx,default:group::r-x,default:group:sales:rwx,default:mask::rw- /dir1/dir2]
        2014-05-03 21:35:30,347 INFO  cli.CLITestHelper (CLITestHelper.java:displayResults(162)) -               Test Commands: [-fs hdfs://localhost:33753 -ls /dir1]
        2014-05-03 21:35:30,347 INFO  cli.CLITestHelper (CLITestHelper.java:displayResults(166)) - 
        2014-05-03 21:35:30,347 INFO  cli.CLITestHelper (CLITestHelper.java:displayResults(169)) -            Cleanup Commands: [-fs hdfs://localhost:33753 -rm -R /dir1]
        2014-05-03 21:35:30,347 INFO  cli.CLITestHelper (CLITestHelper.java:displayResults(173)) - 
        2014-05-03 21:35:30,348 INFO  cli.CLITestHelper (CLITestHelper.java:displayResults(177)) -                  Comparator: [RegexpComparator]
        2014-05-03 21:35:30,348 INFO  cli.CLITestHelper (CLITestHelper.java:displayResults(179)) -          Comparision result:   [fail]
        2014-05-03 21:35:30,348 INFO  cli.CLITestHelper (CLITestHelper.java:displayResults(181)) -             Expected output:   [^drwxr-xr-x\+( )*-( )*[a-zA-z0-9]*( )*supergroup( )*0( )*[0-9]{4,}-[0-9]{2,}-[0-9]{2,} [0-9]{2,}:[0-9]{2,}( )*/dir1/dir2]
        2014-05-03 21:35:30,348 INFO  cli.CLITestHelper (CLITestHelper.java:displayResults(183)) -               Actual output:   [Found 1 items
        drwxr-xr-x+  - ec2-user supergroup          0 2014-05-03 21:35 /dir1/dir2
        ]
        2014-05-03 21:35:30,348 INFO  cli.CLITestHelper (CLITestHelper.java:displayResults(186)) - 
        2014-05-03 21:35:30,348 INFO  cli.CLITestHelper (CLITestHelper.java:displayResults(190)) - Summary results:
        2014-05-03 21:35:30,349 INFO  cli.CLITestHelper (CLITestHelper.java:displayResults(191)) - ----------------------------------
        
        2014-05-03 21:35:30,349 INFO  cli.CLITestHelper (CLITestHelper.java:displayResults(211)) -                Testing mode: test
        2014-05-03 21:35:30,349 INFO  cli.CLITestHelper (CLITestHelper.java:displayResults(212)) - 
        2014-05-03 21:35:30,349 INFO  cli.CLITestHelper (CLITestHelper.java:displayResults(213)) -              Overall result: --- FAIL ---
        2014-05-03 21:35:30,349 INFO  cli.CLITestHelper (CLITestHelper.java:displayResults(221)) -                # Tests pass: 23 (95%)
        2014-05-03 21:35:30,349 INFO  cli.CLITestHelper (CLITestHelper.java:displayResults(223)) -                # Tests fail: 1 (4%)
        2014-05-03 21:35:30,350 INFO  cli.CLITestHelper (CLITestHelper.java:displayResults(227)) -          # Validations done: 163 (each test may do multiple validations)
        
        Show
        Uma Maheswara Rao G added a comment - I have seen this failure when I test the HDFS-2006 branch. SO, same should apply for trunk as well. 2014-05-03 21:35:30,346 INFO cli.CLITestHelper (CLITestHelper.java:displayResults(156)) - Test ID: [20] 2014-05-03 21:35:30,346 INFO cli.CLITestHelper (CLITestHelper.java:displayResults(157)) - Test Description: [ls: display extended acl marker] 2014-05-03 21:35:30,346 INFO cli.CLITestHelper (CLITestHelper.java:displayResults(158)) - 2014-05-03 21:35:30,346 INFO cli.CLITestHelper (CLITestHelper.java:displayResults(162)) - Test Commands: [-fs hdfs://localhost:33753 -mkdir -p /dir1/dir2] 2014-05-03 21:35:30,347 INFO cli.CLITestHelper (CLITestHelper.java:displayResults(162)) - Test Commands: [-fs hdfs://localhost:33753 -setfacl -m user:charlie:rwx,group::-wx,group:sales:rwx,mask::r-x,default:user:charlie:rwx,default:group::r-x,default:group:sales:rwx,default:mask::rw- /dir1/dir2] 2014-05-03 21:35:30,347 INFO cli.CLITestHelper (CLITestHelper.java:displayResults(162)) - Test Commands: [-fs hdfs://localhost:33753 -ls /dir1] 2014-05-03 21:35:30,347 INFO cli.CLITestHelper (CLITestHelper.java:displayResults(166)) - 2014-05-03 21:35:30,347 INFO cli.CLITestHelper (CLITestHelper.java:displayResults(169)) - Cleanup Commands: [-fs hdfs://localhost:33753 -rm -R /dir1] 2014-05-03 21:35:30,347 INFO cli.CLITestHelper (CLITestHelper.java:displayResults(173)) - 2014-05-03 21:35:30,348 INFO cli.CLITestHelper (CLITestHelper.java:displayResults(177)) - Comparator: [RegexpComparator] 2014-05-03 21:35:30,348 INFO cli.CLITestHelper (CLITestHelper.java:displayResults(179)) - Comparision result: [fail] 2014-05-03 21:35:30,348 INFO cli.CLITestHelper (CLITestHelper.java:displayResults(181)) - Expected output: [^drwxr-xr-x\+( )*-( )*[a-zA-z0-9]*( )*supergroup( )*0( )*[0-9]{4,}-[0-9]{2,}-[0-9]{2,} [0-9]{2,}:[0-9]{2,}( )*/dir1/dir2] 2014-05-03 21:35:30,348 INFO cli.CLITestHelper (CLITestHelper.java:displayResults(183)) - Actual output: [Found 1 items drwxr-xr-x+ - ec2-user supergroup 0 2014-05-03 21:35 /dir1/dir2 ] 2014-05-03 21:35:30,348 INFO cli.CLITestHelper (CLITestHelper.java:displayResults(186)) - 2014-05-03 21:35:30,348 INFO cli.CLITestHelper (CLITestHelper.java:displayResults(190)) - Summary results: 2014-05-03 21:35:30,349 INFO cli.CLITestHelper (CLITestHelper.java:displayResults(191)) - ---------------------------------- 2014-05-03 21:35:30,349 INFO cli.CLITestHelper (CLITestHelper.java:displayResults(211)) - Testing mode: test 2014-05-03 21:35:30,349 INFO cli.CLITestHelper (CLITestHelper.java:displayResults(212)) - 2014-05-03 21:35:30,349 INFO cli.CLITestHelper (CLITestHelper.java:displayResults(213)) - Overall result: --- FAIL --- 2014-05-03 21:35:30,349 INFO cli.CLITestHelper (CLITestHelper.java:displayResults(221)) - # Tests pass: 23 (95%) 2014-05-03 21:35:30,349 INFO cli.CLITestHelper (CLITestHelper.java:displayResults(223)) - # Tests fail: 1 (4%) 2014-05-03 21:35:30,350 INFO cli.CLITestHelper (CLITestHelper.java:displayResults(227)) - # Validations done: 163 (each test may do multiple validations)

          People

          • Assignee:
            Uma Maheswara Rao G
            Reporter:
            Uma Maheswara Rao G
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development