Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-6300

Prevent multiple balancers from running simultaneously

    Details

    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      Javadoc of "Balancer.java" says, it will not allow to run second balancer if the first one is in progress. But I've noticed multiple can run together and balancer.id implementation is not safe guarding.

       * <li>Another balancer is running. Exiting...
      
      1. HDFS-6300.patch
        6 kB
        Rakesh R
      2. HDFS-6300-001.patch
        6 kB
        Rakesh R
      3. HDFS-6300-002.patch
        6 kB
        Rakesh R
      4. HDFS-6300-003.patch
        7 kB
        Rakesh R
      5. HDFS-6300-004.patch
        6 kB
        Rakesh R
      6. HDFS-6300-005.patch
        6 kB
        Rakesh R
      7. HDFS-6300-006.patch
        6 kB
        Rakesh R

        Issue Links

          Activity

          Hide
          vinayrpet Vinayakumar B added a comment -

          Thanks Aaron T. Myers for the heads-up. I have resolved HDFS-4505 as duplicate.

          Show
          vinayrpet Vinayakumar B added a comment - Thanks Aaron T. Myers for the heads-up. I have resolved HDFS-4505 as duplicate.
          Hide
          atm Aaron T. Myers added a comment -

          Given these recent fixes, do we think that HDFS-4505 is now obsolete and should therefore be closed?

          Show
          atm Aaron T. Myers added a comment - Given these recent fixes, do we think that HDFS-4505 is now obsolete and should therefore be closed?
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #185 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/185/)
          HDFS-6300. Prevent multiple balancers from running simultaneously (Contributed by Rakesh R) (vinayakumarb: rev 065d8f2a34296b566e7ca541a284f7991212f14c)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancer.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/NameNodeConnector.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #185 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/185/ ) HDFS-6300 . Prevent multiple balancers from running simultaneously (Contributed by Rakesh R) (vinayakumarb: rev 065d8f2a34296b566e7ca541a284f7991212f14c) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancer.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/NameNodeConnector.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2125 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2125/)
          HDFS-6300. Prevent multiple balancers from running simultaneously (Contributed by Rakesh R) (vinayakumarb: rev 065d8f2a34296b566e7ca541a284f7991212f14c)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancer.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/NameNodeConnector.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2125 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2125/ ) HDFS-6300 . Prevent multiple balancers from running simultaneously (Contributed by Rakesh R) (vinayakumarb: rev 065d8f2a34296b566e7ca541a284f7991212f14c) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancer.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/NameNodeConnector.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #196 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/196/)
          HDFS-6300. Prevent multiple balancers from running simultaneously (Contributed by Rakesh R) (vinayakumarb: rev 065d8f2a34296b566e7ca541a284f7991212f14c)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancer.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/NameNodeConnector.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #196 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/196/ ) HDFS-6300 . Prevent multiple balancers from running simultaneously (Contributed by Rakesh R) (vinayakumarb: rev 065d8f2a34296b566e7ca541a284f7991212f14c) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancer.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/NameNodeConnector.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #927 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/927/)
          HDFS-6300. Prevent multiple balancers from running simultaneously (Contributed by Rakesh R) (vinayakumarb: rev 065d8f2a34296b566e7ca541a284f7991212f14c)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/NameNodeConnector.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancer.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #927 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/927/ ) HDFS-6300 . Prevent multiple balancers from running simultaneously (Contributed by Rakesh R) (vinayakumarb: rev 065d8f2a34296b566e7ca541a284f7991212f14c) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/NameNodeConnector.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancer.java
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          > Expectation of create with overwrite on open file was changed in HDFS-3755. Before this, NN used to throw AlreadyBeingCreatedException. So there was no problem.

          Vinayakumar B, thanks for tracing the cause and committing the patch.

          Rakesh R, thanks for the great work!

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - > Expectation of create with overwrite on open file was changed in HDFS-3755 . Before this, NN used to throw AlreadyBeingCreatedException. So there was no problem. Vinayakumar B , thanks for tracing the cause and committing the patch. Rakesh R , thanks for the great work!
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2142 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2142/)
          HDFS-6300. Prevent multiple balancers from running simultaneously (Contributed by Rakesh R) (vinayakumarb: rev 065d8f2a34296b566e7ca541a284f7991212f14c)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancer.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/NameNodeConnector.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2142 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2142/ ) HDFS-6300 . Prevent multiple balancers from running simultaneously (Contributed by Rakesh R) (vinayakumarb: rev 065d8f2a34296b566e7ca541a284f7991212f14c) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancer.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/NameNodeConnector.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #194 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/194/)
          HDFS-6300. Prevent multiple balancers from running simultaneously (Contributed by Rakesh R) (vinayakumarb: rev 065d8f2a34296b566e7ca541a284f7991212f14c)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancer.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/NameNodeConnector.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #194 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/194/ ) HDFS-6300 . Prevent multiple balancers from running simultaneously (Contributed by Rakesh R) (vinayakumarb: rev 065d8f2a34296b566e7ca541a284f7991212f14c) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancer.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/NameNodeConnector.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #7814 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7814/)
          HDFS-6300. Prevent multiple balancers from running simultaneously (Contributed by Rakesh R) (vinayakumarb: rev 065d8f2a34296b566e7ca541a284f7991212f14c)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/NameNodeConnector.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancer.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7814 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7814/ ) HDFS-6300 . Prevent multiple balancers from running simultaneously (Contributed by Rakesh R) (vinayakumarb: rev 065d8f2a34296b566e7ca541a284f7991212f14c) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/NameNodeConnector.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancer.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          rakeshr Rakesh R added a comment -

          Thank you Tsz Wo Nicholas Sze, Allen Wittenauer for reviews. Thank you Vinayakumar B for reviewing and committing the changes!

          Show
          rakeshr Rakesh R added a comment - Thank you Tsz Wo Nicholas Sze , Allen Wittenauer for reviews. Thank you Vinayakumar B for reviewing and committing the changes!
          Hide
          vinayrpet Vinayakumar B added a comment -

          Committed to trunk, branch-2 and branch-2.7 as well. ( as this was critical )
          Thanks Rakesh R for the contribution.
          Thanks Allen Wittenauer and Tsz Wo Nicholas Sze for reviews.

          Show
          vinayrpet Vinayakumar B added a comment - Committed to trunk, branch-2 and branch-2.7 as well. ( as this was critical ) Thanks Rakesh R for the contribution. Thanks Allen Wittenauer and Tsz Wo Nicholas Sze for reviews.
          Hide
          vinayrpet Vinayakumar B added a comment -

          +1 for latest patch.
          Will commit soon.

          Show
          vinayrpet Vinayakumar B added a comment - +1 for latest patch. Will commit soon.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 14m 58s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 41s There were no new javac warning messages.
          +1 javadoc 9m 44s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 2m 18s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 33s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 3m 6s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
          +1 native 3m 21s Pre-build of native portion
          -1 hdfs tests 166m 40s Tests failed in hadoop-hdfs.
              210m 19s  



          Reason Tests
          Failed unit tests hadoop.tracing.TestTraceAdmin
            hadoop.hdfs.TestDFSRename
            hadoop.tools.TestHdfsConfigFields



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12732507/HDFS-6300-006.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / e82067b
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/10951/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10951/testReport/
          Java 1.7.0_55
          uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10951/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 58s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 41s There were no new javac warning messages. +1 javadoc 9m 44s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 2m 18s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 3m 6s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 native 3m 21s Pre-build of native portion -1 hdfs tests 166m 40s Tests failed in hadoop-hdfs.     210m 19s   Reason Tests Failed unit tests hadoop.tracing.TestTraceAdmin   hadoop.hdfs.TestDFSRename   hadoop.tools.TestHdfsConfigFields Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12732507/HDFS-6300-006.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / e82067b hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/10951/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10951/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10951/console This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 14m 33s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 27s There were no new javac warning messages.
          +1 javadoc 9m 32s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 0m 49s There were no new checkstyle issues.
          -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 install 1m 35s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 3m 7s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
          +1 native 3m 13s Pre-build of native portion
          -1 hdfs tests 165m 35s Tests failed in hadoop-hdfs.
              206m 49s  



          Reason Tests
          Failed unit tests hadoop.tools.TestHdfsConfigFields
            hadoop.tracing.TestTraceAdmin



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12732492/HDFS-6300-005.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / fcd0702
          whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/10949/artifact/patchprocess/whitespace.txt
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/10949/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10949/testReport/
          Java 1.7.0_55
          uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10949/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 33s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 27s There were no new javac warning messages. +1 javadoc 9m 32s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 49s There were no new checkstyle issues. -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 35s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 3m 7s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 native 3m 13s Pre-build of native portion -1 hdfs tests 165m 35s Tests failed in hadoop-hdfs.     206m 49s   Reason Tests Failed unit tests hadoop.tools.TestHdfsConfigFields   hadoop.tracing.TestTraceAdmin Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12732492/HDFS-6300-005.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / fcd0702 whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/10949/artifact/patchprocess/whitespace.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/10949/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10949/testReport/ Java 1.7.0_55 uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10949/console This message was automatically generated.
          Hide
          rakeshr Rakesh R added a comment -

          Thanks Vinayakumar B. Attached another patch addressing the comments.

          Show
          rakeshr Rakesh R added a comment - Thanks Vinayakumar B . Attached another patch addressing the comments.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 14m 59s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 38s There were no new javac warning messages.
          +1 javadoc 9m 46s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 2m 13s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 34s mvn install still works.
          +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
          +1 findbugs 3m 6s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
          +1 native 3m 20s Pre-build of native portion
          -1 hdfs tests 142m 49s Tests failed in hadoop-hdfs.
              186m 24s  



          Reason Tests
          Failed unit tests hadoop.tracing.TestTraceAdmin
            hadoop.tools.TestHdfsConfigFields
            hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA
            hadoop.hdfs.server.datanode.TestDataNodeRollingUpgrade
          Timed out tests org.apache.hadoop.hdfs.server.namenode.ha.TestStandbyIsHot



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12732476/HDFS-6300-004.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / fcd0702
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/10946/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10946/testReport/
          Java 1.7.0_55
          uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10946/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 59s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 38s There were no new javac warning messages. +1 javadoc 9m 46s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 2m 13s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 34s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 3m 6s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 native 3m 20s Pre-build of native portion -1 hdfs tests 142m 49s Tests failed in hadoop-hdfs.     186m 24s   Reason Tests Failed unit tests hadoop.tracing.TestTraceAdmin   hadoop.tools.TestHdfsConfigFields   hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA   hadoop.hdfs.server.datanode.TestDataNodeRollingUpgrade Timed out tests org.apache.hadoop.hdfs.server.namenode.ha.TestStandbyIsHot Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12732476/HDFS-6300-004.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / fcd0702 hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/10946/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10946/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10946/console This message was automatically generated.
          Hide
          vinayrpet Vinayakumar B added a comment - - edited

          Latest patch looks good.
          One nit in test.

          	      // release lease so that another balancer would run
                assertTrue("Failed to run first balancer!",
                fs.exists(Balancer.BALANCER_ID_PATH));

          comment is irrelevant here.
          +1 once addressed.

          Show
          vinayrpet Vinayakumar B added a comment - - edited Latest patch looks good. One nit in test. // release lease so that another balancer would run assertTrue( "Failed to run first balancer!" , fs.exists(Balancer.BALANCER_ID_PATH)); comment is irrelevant here. +1 once addressed.
          Hide
          rakeshr Rakesh R added a comment -

          I think its good to merge two test cases under one unit test, it would avoid start another cluster again. Attached the modified patch to the jira.

          Show
          rakeshr Rakesh R added a comment - I think its good to merge two test cases under one unit test, it would avoid start another cluster again. Attached the modified patch to the jira.
          Hide
          rakeshr Rakesh R added a comment -

          Thanks Tsz Wo Nicholas Sze. Attached another patch addressing the previous comments. Also, I've tried one more test case to simulate the case where another balancer successfully performs append operation and gone ahead with balancing. Kindly review the patch again.

          Show
          rakeshr Rakesh R added a comment - Thanks Tsz Wo Nicholas Sze . Attached another patch addressing the previous comments. Also, I've tried one more test case to simulate the case where another balancer successfully performs append operation and gone ahead with balancing. Kindly review the patch again.
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          Indeed, we could combine checkAnotherBalancerIsRunning to checkAndMarkRunning as below. I also adds a comment to explain why doing append.

            private OutputStream checkAndMarkRunning() throws IOException {
              try {
                if (fs.exists(idPath)) {
                  // try appending to it so that it will fail fast if another balancer is running.
                  IOUtils.closeStream(fs.append(idPath));
                  fs.delete(idPath, true);
                }
                final FSDataOutputStream fsout = fs.create(idPath, false);
                // mark balancer idPath to be deleted during FileSystem closure
                fs.deleteOnExit(idPath);
                if (write2IdFile) {
                  fsout.writeBytes(InetAddress.getLocalHost().getHostName());
                  fsout.hflush();
                }
                return fsout;
              } catch(RemoteException e) {
                if(AlreadyBeingCreatedException.class.getName().equals(e.getClassName())){
                  return null;
                } else {
                  throw e;
                }
              }
            }
          
          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - Indeed, we could combine checkAnotherBalancerIsRunning to checkAndMarkRunning as below. I also adds a comment to explain why doing append. private OutputStream checkAndMarkRunning() throws IOException { try { if (fs.exists(idPath)) { // try appending to it so that it will fail fast if another balancer is running. IOUtils.closeStream(fs.append(idPath)); fs.delete(idPath, true ); } final FSDataOutputStream fsout = fs.create(idPath, false ); // mark balancer idPath to be deleted during FileSystem closure fs.deleteOnExit(idPath); if (write2IdFile) { fsout.writeBytes(InetAddress.getLocalHost().getHostName()); fsout.hflush(); } return fsout; } catch (RemoteException e) { if (AlreadyBeingCreatedException.class.getName().equals(e.getClassName())){ return null ; } else { throw e; } } }
          Hide
          rakeshr Rakesh R added a comment -

          Thanks Tsz Wo Nicholas Sze for the review comments.

          The real fix is "fs.create(idPath, false);". The new checkAnotherBalancerIsRunning() method is for fail-fast. Some minor comments.

          Yes. I hope you are agreeing to keep this check in my logic.

          For the test, the first Balancer may finish and exist before the second balancer start.

          Awsome. This will make it very simple. I'll modify this as per your suggestion

          Could you not renaming out to fsout in checkAndMarkRunning().

          I renamed because checkstyle is complaining like,

          ./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/NameNodeConnector.java:250:28: 'out' hides a field.
          

          Does this change makes sense?

          Show
          rakeshr Rakesh R added a comment - Thanks Tsz Wo Nicholas Sze for the review comments. The real fix is "fs.create(idPath, false);". The new checkAnotherBalancerIsRunning() method is for fail-fast. Some minor comments. Yes. I hope you are agreeing to keep this check in my logic. For the test, the first Balancer may finish and exist before the second balancer start. Awsome. This will make it very simple. I'll modify this as per your suggestion Could you not renaming out to fsout in checkAndMarkRunning(). I renamed because checkstyle is complaining like, ./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/NameNodeConnector.java:250:28: 'out' hides a field. Does this change makes sense?
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 15m 2s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 45s There were no new javac warning messages.
          +1 javadoc 9m 55s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 2m 18s The applied patch generated 55 new checkstyle issues (total was 1639, now 1641).
          +1 whitespace 0m 8s The patch has no lines that end in whitespace.
          +1 install 1m 39s mvn install still works.
          +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
          +1 findbugs 3m 10s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
          +1 native 3m 17s Pre-build of native portion
          -1 hdfs tests 165m 29s Tests failed in hadoop-hdfs.
              209m 45s  



          Reason Tests
          Failed unit tests hadoop.tracing.TestTraceAdmin
            hadoop.hdfs.tools.TestHdfsConfigFields
            hadoop.hdfs.TestFileCreation



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12731499/HDFS-6300-003.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 30099a3
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/10885/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/10885/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10885/testReport/
          Java 1.7.0_55
          uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10885/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 15m 2s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 45s There were no new javac warning messages. +1 javadoc 9m 55s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 2m 18s The applied patch generated 55 new checkstyle issues (total was 1639, now 1641). +1 whitespace 0m 8s The patch has no lines that end in whitespace. +1 install 1m 39s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 3m 10s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 native 3m 17s Pre-build of native portion -1 hdfs tests 165m 29s Tests failed in hadoop-hdfs.     209m 45s   Reason Tests Failed unit tests hadoop.tracing.TestTraceAdmin   hadoop.hdfs.tools.TestHdfsConfigFields   hadoop.hdfs.TestFileCreation Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12731499/HDFS-6300-003.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 30099a3 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/10885/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/10885/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10885/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10885/console This message was automatically generated.
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          Rakesh, thanks for filing this bug. It was a good catch.

          The real fix is "fs.create(idPath, false);". The new checkAnotherBalancerIsRunning() method is for fail-fast. Some minor comments.

          • For the test, the first Balancer may finish and exist before the second balancer start. So how about simply creating the file but not run the first balancer? I.e.
            //testManyBalancerSimultaneously() t
                  FileSystem fs = cluster.getFileSystem(0);
                  final FSDataOutputStream out = fs.create(Balancer.BALANCER_ID_PATH, false);
                  out.writeBytes(InetAddress.getLocalHost().getHostName());
                  out.hflush();
            
          • Could you not renaming out to fsout in checkAndMarkRunning().
          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - Rakesh, thanks for filing this bug. It was a good catch. The real fix is "fs.create(idPath, false);". The new checkAnotherBalancerIsRunning() method is for fail-fast. Some minor comments. For the test, the first Balancer may finish and exist before the second balancer start. So how about simply creating the file but not run the first balancer? I.e. //testManyBalancerSimultaneously() t FileSystem fs = cluster.getFileSystem(0); final FSDataOutputStream out = fs.create(Balancer.BALANCER_ID_PATH, false ); out.writeBytes(InetAddress.getLocalHost().getHostName()); out.hflush(); Could you not renaming out to fsout in checkAndMarkRunning().
          Hide
          rakeshr Rakesh R added a comment -

          Attached another patch fixing the checkstyle comments.

          Show
          rakeshr Rakesh R added a comment - Attached another patch fixing the checkstyle comments.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 14m 47s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 42s There were no new javac warning messages.
          +1 javadoc 9m 44s There were no new javadoc warning messages.
          +1 release audit 0m 21s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 2m 12s The applied patch generated 2 new checkstyle issues (total was 853, now 6).
          +1 whitespace 0m 2s The patch has no lines that end in whitespace.
          +1 install 1m 34s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 3m 6s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
          +1 native 3m 20s Pre-build of native portion
          -1 hdfs tests 170m 28s Tests failed in hadoop-hdfs.
              213m 54s  



          Reason Tests
          Failed unit tests hadoop.tracing.TestTraceAdmin
            hadoop.hdfs.server.datanode.TestNNHandlesCombinedBlockReport



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12731413/HDFS-6300-002.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / e01c1a9
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/10866/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/10866/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10866/testReport/
          Java 1.7.0_55
          uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10866/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 47s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 42s There were no new javac warning messages. +1 javadoc 9m 44s There were no new javadoc warning messages. +1 release audit 0m 21s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 2m 12s The applied patch generated 2 new checkstyle issues (total was 853, now 6). +1 whitespace 0m 2s The patch has no lines that end in whitespace. +1 install 1m 34s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 3m 6s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 native 3m 20s Pre-build of native portion -1 hdfs tests 170m 28s Tests failed in hadoop-hdfs.     213m 54s   Reason Tests Failed unit tests hadoop.tracing.TestTraceAdmin   hadoop.hdfs.server.datanode.TestNNHandlesCombinedBlockReport Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12731413/HDFS-6300-002.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / e01c1a9 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/10866/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/10866/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10866/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10866/console This message was automatically generated.
          Hide
          rakeshr Rakesh R added a comment -

          Thanks Vinayakumar B for the review comments. Yes you are correct, the test is flaky. I've modified the test case to ensure the first balancer is running when triggering the second balancer. Kindly take a look at the patch again.

          Show
          rakeshr Rakesh R added a comment - Thanks Vinayakumar B for the review comments. Yes you are correct, the test is flaky. I've modified the test case to ensure the first balancer is running when triggering the second balancer . Kindly take a look at the patch again.
          Hide
          vinayrpet Vinayakumar B added a comment -

          Expectation of create with overwrite on open file was changed in HDFS-3755. Before this, NN used to throw AlreadyBeingCreatedException. So there was no problem.

          Source changes looks good.
          In Test, balancerStarted.countDown(); should be called after runBalancer(..) right?

          Show
          vinayrpet Vinayakumar B added a comment - Expectation of create with overwrite on open file was changed in HDFS-3755 . Before this, NN used to throw AlreadyBeingCreatedException. So there was no problem. Source changes looks good. In Test, balancerStarted.countDown(); should be called after runBalancer(..) right?
          Hide
          rakeshr Rakesh R added a comment -

          It looks like hadoop.hdfs.server.namenode.TestFileTruncate is not related to my patch.

          Show
          rakeshr Rakesh R added a comment - It looks like hadoop.hdfs.server.namenode.TestFileTruncate is not related to my patch.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 14m 37s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 27s There were no new javac warning messages.
          +1 javadoc 9m 33s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 0m 38s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 35s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 3m 2s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
          +1 native 3m 14s Pre-build of native portion
          -1 hdfs tests 184m 8s Tests failed in hadoop-hdfs.
              225m 18s  



          Reason Tests
          Failed unit tests hadoop.hdfs.server.namenode.TestFileTruncate



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12730170/HDFS-6300-001.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / bb9ddef
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/10780/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10780/testReport/
          Java 1.7.0_55
          uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10780/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 37s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 27s There were no new javac warning messages. +1 javadoc 9m 33s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 38s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 35s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 3m 2s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 native 3m 14s Pre-build of native portion -1 hdfs tests 184m 8s Tests failed in hadoop-hdfs.     225m 18s   Reason Tests Failed unit tests hadoop.hdfs.server.namenode.TestFileTruncate Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12730170/HDFS-6300-001.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / bb9ddef hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/10780/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10780/testReport/ Java 1.7.0_55 uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10780/console This message was automatically generated.
          Hide
          rakeshr Rakesh R added a comment -

          Thanks a lot Allen Wittenauer for the interest. Sorry for the delay, I've missed your comments. I'm attaching another patch re-based in latest trunk code.

          Show
          rakeshr Rakesh R added a comment - Thanks a lot Allen Wittenauer for the interest. Sorry for the delay, I've missed your comments. I'm attaching another patch re-based in latest trunk code.
          Hide
          aw Allen Wittenauer added a comment -

          Cancelling, as patch no longer applies.

          Show
          aw Allen Wittenauer added a comment - Cancelling, as patch no longer applies.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12642451/HDFS-6300.patch
          against trunk revision 1556f86.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8873//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12642451/HDFS-6300.patch against trunk revision 1556f86. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8873//console This message is automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12642451/HDFS-6300.patch
          against trunk revision .

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7643//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12642451/HDFS-6300.patch against trunk revision . -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7643//console This message is automatically generated.
          Hide
          rakeshr Rakesh R added a comment -

          Could someone help me to validate the scenario and the proposed fix. The problem I could see is, fs.create(BALANCER_ID_PATH) is allowing to do OVER_WRITE=true, when another balancer comes its not getting the 'AlreadyBeingCreatedException' and start perform balancing.
          Thanks,
          Rakesh

          Show
          rakeshr Rakesh R added a comment - Could someone help me to validate the scenario and the proposed fix. The problem I could see is, fs.create(BALANCER_ID_PATH) is allowing to do OVER_WRITE=true, when another balancer comes its not getting the 'AlreadyBeingCreatedException' and start perform balancing. Thanks, Rakesh
          Hide
          hadoopqa Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12642451/HDFS-6300.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/6764//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6764//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12642451/HDFS-6300.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/6764//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6764//console This message is automatically generated.

            People

            • Assignee:
              rakeshr Rakesh R
              Reporter:
              rakeshr Rakesh R
            • Votes:
              0 Vote for this issue
              Watchers:
              13 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development