Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-629

Remove ReplicationTargetChooser.java along with fixing import warnings.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.21.0
    • Fix Version/s: 0.21.0
    • Component/s: namenode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      ReplicationTargetChooser.java is empty and should be removed.
      This is introduced by pluggable replica placement interface HDFS-385 along with some import warnings in:
      BlockPlacementPolicy
      BlockPlacementPolicyDefault

      1. war.txt
        2 kB
        dhruba borthakur

        Issue Links

          Activity

          Hide
          Konstantin Shvachko added a comment -

          Also in FSNamesystem.chooseExcessReplicates() the following variable
          long minSpace = Long.MAX_VALUE;
          is never read.

          Show
          Konstantin Shvachko added a comment - Also in FSNamesystem.chooseExcessReplicates() the following variable long minSpace = Long.MAX_VALUE; is never read.
          Hide
          dhruba borthakur added a comment -

          Fix eclipse warnings.

          Show
          dhruba borthakur added a comment - Fix eclipse warnings.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12420067/war.txt
          against trunk revision 816717.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          -1 contrib tests. The patch failed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/10/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/10/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/10/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/10/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12420067/war.txt against trunk revision 816717. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/10/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/10/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/10/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/10/console This message is automatically generated.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          +1 patch looks good.

          I think the failure is not related. Try submitting again.

          Show
          Tsz Wo Nicholas Sze added a comment - +1 patch looks good. I think the failure is not related. Try submitting again.
          Hide
          Konstantin Shvachko added a comment -

          I don't see that it removes ReplicationTargetChooser.

          Show
          Konstantin Shvachko added a comment - I don't see that it removes ReplicationTargetChooser.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12420067/war.txt
          against trunk revision 816785.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/11/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/11/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/11/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/11/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12420067/war.txt against trunk revision 816785. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/11/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/11/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/11/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/11/console This message is automatically generated.
          Hide
          dhruba borthakur added a comment -

          I committed this to trunk.

          Show
          dhruba borthakur added a comment - I committed this to trunk.
          Hide
          Konstantin Boudnik added a comment -

          Druba, could you please put a note on why there's no new tests were developed for the fix?

          Show
          Konstantin Boudnik added a comment - Druba, could you please put a note on why there's no new tests were developed for the fix?
          Hide
          dhruba borthakur added a comment -

          Sure, this removed a few "import xxx" lines from source files to prevent Eclipse warnings, and does not need targetted unit tests. Successful compilation of the source code is a test by itself.

          Show
          dhruba borthakur added a comment - Sure, this removed a few "import xxx" lines from source files to prevent Eclipse warnings, and does not need targetted unit tests. Successful compilation of the source code is a test by itself.
          Hide
          Konstantin Boudnik added a comment -

          Thank you! We are trying to have a way of tracking the changes and their testing. It might be not that easy to find our in a few months why a patch with -1 was committed and why no tests were delivered. I appreciate your help.

          Show
          Konstantin Boudnik added a comment - Thank you! We are trying to have a way of tracking the changes and their testing. It might be not that easy to find our in a few months why a patch with -1 was committed and why no tests were delivered. I appreciate your help.
          Hide
          Konstantin Boudnik added a comment -

          Thank you! We are trying to have a way of tracking the changes and their testing. It might be not that easy to find our in a few months why a patch with -1 was committed and why no tests were delivered. I appreciate your help.

          Show
          Konstantin Boudnik added a comment - Thank you! We are trying to have a way of tracking the changes and their testing. It might be not that easy to find our in a few months why a patch with -1 was committed and why no tests were delivered. I appreciate your help.
          Hide
          Konstantin Shvachko added a comment -

          I just committed this to branch 0.21.

          Show
          Konstantin Shvachko added a comment - I just committed this to branch 0.21.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #98 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/98/)

          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #98 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/98/ )
          Hide
          Hudson added a comment -

          Integrated in Hdfs-Patch-h2.grid.sp2.yahoo.net #20 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/20/)

          Show
          Hudson added a comment - Integrated in Hdfs-Patch-h2.grid.sp2.yahoo.net #20 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/20/ )

            People

            • Assignee:
              dhruba borthakur
              Reporter:
              Konstantin Shvachko
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development