Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-625

ListPathsServlet throws NullPointerException

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: namenode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Corrected error where listing path no longer in name space could stop ListPathsServlet until system restarted.

      Description

      ListPathsServlet throws NullPointerException when listing on a path which is not found in the namesystem.

      1. hdfs-625.patch
        6 kB
        Suresh Srinivas
      2. hdfs-625.1.patch
        6 kB
        Suresh Srinivas
      3. hdfs-625.0-20.patch
        6 kB
        Jitendra Nath Pandey

        Activity

        Tom White made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Tom White made changes -
        Fix Version/s 0.22.0 [ 12314241 ]
        Robert Chansler made changes -
        Release Note Attempt to list path no longer in name space could stop ListPathsServlet until system restarted. Corrected error where listing path no longer in name space could stop ListPathsServlet until system restarted.
        Robert Chansler made changes -
        Release Note Attempt to list path no longer in name space could stop ListPathsServlet until system restarted.
        Hide
        Hudson added a comment -

        Integrated in Hdfs-Patch-h5.grid.sp2.yahoo.net #100 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/100/)

        Show
        Hudson added a comment - Integrated in Hdfs-Patch-h5.grid.sp2.yahoo.net #100 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/100/ )
        Jitendra Nath Pandey made changes -
        Attachment hdfs-625.0-20.patch [ 12424176 ]
        Hide
        Jitendra Nath Pandey added a comment -

        Patch for hadoop-20 added.

        Show
        Jitendra Nath Pandey added a comment - Patch for hadoop-20 added.
        Hide
        Hudson added a comment -

        Integrated in Hdfs-Patch-h2.grid.sp2.yahoo.net #65 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/65/)

        Show
        Hudson added a comment - Integrated in Hdfs-Patch-h2.grid.sp2.yahoo.net #65 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/65/ )
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #122 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/122/)
        . Fix NullPointerException thrown from ListPathServlet. Contributed by Suresh Srinivas.

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #122 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/122/ ) . Fix NullPointerException thrown from ListPathServlet. Contributed by Suresh Srinivas.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #85 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/85/)
        . Fix NullPointerException thrown from ListPathServlet. Contributed by Suresh Srinivas.

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #85 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/85/ ) . Fix NullPointerException thrown from ListPathServlet. Contributed by Suresh Srinivas.
        Suresh Srinivas made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Fix Version/s 0.22.0 [ 12314241 ]
        Resolution Fixed [ 1 ]
        Hide
        Suresh Srinivas added a comment -

        Just committed this change to trunk and 21 branch.

        Show
        Suresh Srinivas added a comment - Just committed this change to trunk and 21 branch.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12423230/hdfs-625.1.patch
        against trunk revision 829894.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/61/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/61/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/61/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/61/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12423230/hdfs-625.1.patch against trunk revision 829894. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/61/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/61/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/61/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/61/console This message is automatically generated.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        +1 on the new patch. Thanks, Suresh.

        Show
        Tsz Wo Nicholas Sze added a comment - +1 on the new patch. Thanks, Suresh.
        Suresh Srinivas made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Suresh Srinivas made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Suresh Srinivas made changes -
        Attachment hdfs-625.1.patch [ 12423230 ]
        Hide
        Suresh Srinivas added a comment -

        New patch prints a warning log in ListPathsServlet to indicate invalid path names. This will help debug issues related to distcp where a file/directory was deleted when distcp is in progress.

        Show
        Suresh Srinivas added a comment - New patch prints a warning log in ListPathsServlet to indicate invalid path names. This will help debug issues related to distcp where a file/directory was deleted when distcp is in progress.
        Hide
        Suresh Srinivas added a comment -

        Failures in TestBlockReport(HDFS-733) and TestBackupNode(HDFS-192) are not related to this change.

        Show
        Suresh Srinivas added a comment - Failures in TestBlockReport( HDFS-733 ) and TestBackupNode( HDFS-192 ) are not related to this change.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12423062/hdfs-625.patch
        against trunk revision 829258.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/58/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/58/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/58/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/58/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12423062/hdfs-625.patch against trunk revision 829258. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/58/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/58/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/58/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/58/console This message is automatically generated.
        Suresh Srinivas made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Suresh Srinivas made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12423062/hdfs-625.patch
        against trunk revision 829182.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/57/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/57/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/57/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/57/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12423062/hdfs-625.patch against trunk revision 829182. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/57/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/57/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/57/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/57/console This message is automatically generated.
        Tsz Wo Nicholas Sze made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hadoop Flags [Reviewed]
        Hide
        Tsz Wo Nicholas Sze added a comment -

        +1 patch looks good.

        Show
        Tsz Wo Nicholas Sze added a comment - +1 patch looks good.
        Suresh Srinivas made changes -
        Attachment hdfs-625.patch [ 12423062 ]
        Hide
        Suresh Srinivas added a comment -

        Fixed NPE. Test for ListPathServlet employs HftpFileSystem, since it already handles the XML returned by the servlet. This avoids complicating the test with XML parsing.

        Show
        Suresh Srinivas added a comment - Fixed NPE. Test for ListPathServlet employs HftpFileSystem, since it already handles the XML returned by the servlet. This avoids complicating the test with XML parsing.
        Suresh Srinivas made changes -
        Field Original Value New Value
        Assignee Suresh Srinivas [ sureshms ]
        Tsz Wo Nicholas Sze created issue -

          People

          • Assignee:
            Suresh Srinivas
            Reporter:
            Tsz Wo Nicholas Sze
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development