[HDFS-6197] Rolling upgrade rollback on Windows can fail attempting to rename edit log segment files to a destination that already exists.

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.4.0, 3.0.0-alpha1
• Fix Version/s: 2.4.1
• Component/s: namenode
• Target Version/s: 2.4.1
• Hadoop Flags: Reviewed
• Assignee: Chris Nauroth
• Reporter: Chris Nauroth
• Created: 07/Apr/14 17:52
• Updated: 12/May/16 18:15
• Resolved: 07/Apr/14 21:33

Description

As part of a rollback from a rolling upgrade in progress, we discard edit log segments by renaming the file with suffix ".trash". If no new edits arrive in between multiple attempts, then the ".trash" file may still exist. On Windows, java.io.File#renameTo fails if the destination already exists though. This is visible right now as a failure in TestRollingUpgrade#testRollback when running on Windows.