Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-612

FSDataset should not use org.mortbay.log.Log

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.21.0
    • Fix Version/s: 0.21.0
    • Component/s: datanode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      There are some codes in FSDataset using org.mortbay.log.Log.

      1. h612_20090911b.patch
        2 kB
        Tsz Wo Nicholas Sze
      2. h612_20090911.patch
        1 kB
        Tsz Wo Nicholas Sze

        Issue Links

          Activity

          Tsz Wo Nicholas Sze created issue -
          Tsz Wo Nicholas Sze made changes -
          Field Original Value New Value
          Link This issue is related to HDFS-457 [ HDFS-457 ]
          Hide
          Tsz Wo Nicholas Sze added a comment -

          h612_20090911.patch: uses DataNode.LOG for logging.

          Show
          Tsz Wo Nicholas Sze added a comment - h612_20090911.patch: uses DataNode.LOG for logging.
          Tsz Wo Nicholas Sze made changes -
          Attachment h612_20090911.patch [ 12419341 ]
          Hide
          Boris Shkolnik added a comment -

          +1

          Show
          Boris Shkolnik added a comment - +1
          Hide
          Boris Shkolnik added a comment -

          could you also remove ">>>>>>>>>>>>" from line 1504

          Show
          Boris Shkolnik added a comment - could you also remove ">>>>>>>>>>>>" from line 1504
          Hide
          Tsz Wo Nicholas Sze added a comment -

          h612_20090911b.patch: removed ">>>>>>>>>>>>"

          Show
          Tsz Wo Nicholas Sze added a comment - h612_20090911b.patch: removed ">>>>>>>>>>>>"
          Tsz Wo Nicholas Sze made changes -
          Attachment h612_20090911b.patch [ 12419353 ]
          Tsz Wo Nicholas Sze made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hadoop Flags [Reviewed]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12419353/h612_20090911b.patch
          against trunk revision 814221.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/23/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/23/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/23/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/23/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12419353/h612_20090911b.patch against trunk revision 814221. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/23/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/23/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/23/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/23/console This message is automatically generated.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          Simple patch. No new tests added.

          I have committed this.

          Show
          Tsz Wo Nicholas Sze added a comment - Simple patch. No new tests added. I have committed this.
          Tsz Wo Nicholas Sze made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #32 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/32/)
          . Remove the use of org.mortbay.log.Log in FSDataset.

          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #32 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/32/ ) . Remove the use of org.mortbay.log.Log in FSDataset.
          Hide
          Hudson added a comment -

          Integrated in Hdfs-Patch-h5.grid.sp2.yahoo.net #26 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/26/)

          Show
          Hudson added a comment - Integrated in Hdfs-Patch-h5.grid.sp2.yahoo.net #26 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/26/ )
          Hide
          Hudson added a comment -

          Integrated in Hdfs-Patch-h2.grid.sp2.yahoo.net #6 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/6/)
          . Remove the use of org.mortbay.log.Log in FSDataset.

          Show
          Hudson added a comment - Integrated in Hdfs-Patch-h2.grid.sp2.yahoo.net #6 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/6/ ) . Remove the use of org.mortbay.log.Log in FSDataset.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #84 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/84/)

          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #84 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/84/ )
          Tom White made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Patch Available Patch Available
          21h 45m 1 Tsz Wo Nicholas Sze 12/Sep/09 19:54
          Patch Available Patch Available Resolved Resolved
          1d 4h 38m 1 Tsz Wo Nicholas Sze 14/Sep/09 00:33
          Resolved Resolved Closed Closed
          344d 21h 15m 1 Tom White 24/Aug/10 21:49

            People

            • Assignee:
              Tsz Wo Nicholas Sze
              Reporter:
              Tsz Wo Nicholas Sze
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development