Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-6112

NFS Gateway docs are incorrect for allowed hosts configuration

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4.0
    • Fix Version/s: 2.5.0
    • Component/s: nfs
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      The NFS gateway export configuration docs say that the machine name configuration can be "wildcards" and provides the example "host*.example.com". The term "wildcard" and this example might imply typical globbing semantics, but in fact what it actually supports is Java regular expressions. I think we should change the docs to make this clearer.

      1. HDFS-6112.patch
        1 kB
        Aaron T. Myers

        Activity

        Hide
        atm Aaron T. Myers added a comment -

        Patch attached to change the docs slightly.

        Show
        atm Aaron T. Myers added a comment - Patch attached to change the docs slightly.
        Hide
        tlipcon Todd Lipcon added a comment -

        +1, unless you think we should fix the code to use glob syntax instead of regex (might be more ops-friendly)?

        Show
        tlipcon Todd Lipcon added a comment - +1, unless you think we should fix the code to use glob syntax instead of regex (might be more ops-friendly)?
        Hide
        atm Aaron T. Myers added a comment -

        Thanks for the review. I considered that as well and concluded that we should probably just stick with regexes. Regular expressions will be more flexible, and we also use them in other places in our configuration (e.g. hadoop.security.auth_to_local) so it's not as if we'll be completely absolving the need for a cluster operator to understand regular expressions if we were to change this setting.

        Show
        atm Aaron T. Myers added a comment - Thanks for the review. I considered that as well and concluded that we should probably just stick with regexes. Regular expressions will be more flexible, and we also use them in other places in our configuration (e.g. hadoop.security.auth_to_local) so it's not as if we'll be completely absolving the need for a cluster operator to understand regular expressions if we were to change this setting.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12635222/HDFS-6112.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/6417//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6417//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12635222/HDFS-6112.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/6417//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6417//console This message is automatically generated.
        Hide
        atm Aaron T. Myers added a comment -

        Thanks a lot for the review, Todd. I've just committed this to trunk and branch-2.

        Show
        atm Aaron T. Myers added a comment - Thanks a lot for the review, Todd. I've just committed this to trunk and branch-2.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-trunk-Commit #5355 (See https://builds.apache.org/job/Hadoop-trunk-Commit/5355/)
        HDFS-6112. NFS Gateway docs are incorrect for allowed hosts configuration. Contributed by Aaron T. Myers. (atm: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1579097)

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/site/apt/HdfsNfsGateway.apt.vm
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #5355 (See https://builds.apache.org/job/Hadoop-trunk-Commit/5355/ ) HDFS-6112 . NFS Gateway docs are incorrect for allowed hosts configuration. Contributed by Aaron T. Myers. (atm: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1579097 ) /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/site/apt/HdfsNfsGateway.apt.vm
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #514 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/514/)
        HDFS-6112. NFS Gateway docs are incorrect for allowed hosts configuration. Contributed by Aaron T. Myers. (atm: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1579097)

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/site/apt/HdfsNfsGateway.apt.vm
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #514 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/514/ ) HDFS-6112 . NFS Gateway docs are incorrect for allowed hosts configuration. Contributed by Aaron T. Myers. (atm: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1579097 ) /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/site/apt/HdfsNfsGateway.apt.vm
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Hdfs-trunk #1706 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1706/)
        HDFS-6112. NFS Gateway docs are incorrect for allowed hosts configuration. Contributed by Aaron T. Myers. (atm: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1579097)

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/site/apt/HdfsNfsGateway.apt.vm
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #1706 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1706/ ) HDFS-6112 . NFS Gateway docs are incorrect for allowed hosts configuration. Contributed by Aaron T. Myers. (atm: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1579097 ) /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/site/apt/HdfsNfsGateway.apt.vm
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk #1731 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1731/)
        HDFS-6112. NFS Gateway docs are incorrect for allowed hosts configuration. Contributed by Aaron T. Myers. (atm: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1579097)

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/site/apt/HdfsNfsGateway.apt.vm
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #1731 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1731/ ) HDFS-6112 . NFS Gateway docs are incorrect for allowed hosts configuration. Contributed by Aaron T. Myers. (atm: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1579097 ) /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/site/apt/HdfsNfsGateway.apt.vm
        Hide
        vinodkv Vinod Kumar Vavilapalli added a comment -

        Closing old tickets that are already shipped in a release.

        Show
        vinodkv Vinod Kumar Vavilapalli added a comment - Closing old tickets that are already shipped in a release.

          People

          • Assignee:
            atm Aaron T. Myers
            Reporter:
            atm Aaron T. Myers
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development