Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-608

BlockReceiver:receivePacket(): packet's header parsing logic is complicated. Refactoring will help w/ testing efforts

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Duplicate
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      Current logic of getting an information from a packet header is kinda complicated with all shifting along the internal data buffer back and forth.
      Besides, an absence of clear API to access a packet header's information makes pipeline testing effort (even with aspects' application) to be a very complicated or even impossible.

      It'd be very nice to have a separate data container which will keep all the information about a packet header within and will initialized once when a new packet is acquired.

      In order to speed-up pipeline testing needed for append (HDFS-265) this modification might implemented in three different states:

      • introduce new header structure and refactor receivePacket()
      • refactor readNextPacket so it it will acquire next packet in initialize its header
      • refactor the sender side to use the packet's header structure as the receiver does.

        Attachments

        1. HDFS-608.patch
          4 kB
          Konstantin Boudnik

          Issue Links

            Activity

              People

              • Assignee:
                cos Konstantin Boudnik
                Reporter:
                cos Konstantin Boudnik
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: