Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-6059

TestBlockReaderLocal fails if native library is not available

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0
    • Fix Version/s: 2.4.0
    • Component/s: None
    • Labels:
    • Target Version/s:

      Description

      I ran TestBlockReaderLocal locally and it failed.

      -------------------------------------------------------
       T E S T S
      -------------------------------------------------------
      Running org.apache.hadoop.hdfs.TestBlockReaderLocal
      Tests run: 37, Failures: 0, Errors: 35, Skipped: 2, Time elapsed: 77.261 sec <<< FAILURE! - in org.apache.hadoop.hdfs.TestBlockReaderLocal
      testBlockReaderLocalImmediateClose(org.apache.hadoop.hdfs.TestBlockReaderLocal)  Time elapsed: 51.562 sec  <<< ERROR!
      java.lang.UnsupportedOperationException: NativeIO is not available.
              at org.apache.hadoop.hdfs.ShortCircuitShm.<init>(ShortCircuitShm.java:461)
              at org.apache.hadoop.hdfs.TestBlockReaderLocal.runBlockReaderLocalTest(TestBlockReaderLocal.java:181)
              at org.apache.hadoop.hdfs.TestBlockReaderLocal.testBlockReaderLocalImmediateClose(TestBlockReaderLocal.java:218)
      
      1. HDFS-6059.2.patch
        1 kB
        Akira AJISAKA
      2. HDFS-6059.patch
        1 kB
        Akira AJISAKA

        Issue Links

          Activity

          Hide
          Akira AJISAKA added a comment -

          I'll create a patch to skip the test if native library is not available shortly.

          Show
          Akira AJISAKA added a comment - I'll create a patch to skip the test if native library is not available shortly.
          Hide
          Akira AJISAKA added a comment -

          Attaching a patch.

          Show
          Akira AJISAKA added a comment - Attaching a patch.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12632871/HDFS-6059.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

          org.apache.hadoop.cli.TestAclCLI
          org.apache.hadoop.cli.TestHDFSCLI

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/6309//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6309//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12632871/HDFS-6059.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.cli.TestAclCLI org.apache.hadoop.cli.TestHDFSCLI +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/6309//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6309//console This message is automatically generated.
          Hide
          Chris Nauroth added a comment -

          This had been reported in HDFS-6052. I decided to close HDFS-6052, because there is more activity here on this one.

          Show
          Chris Nauroth added a comment - This had been reported in HDFS-6052 . I decided to close HDFS-6052 , because there is more activity here on this one.
          Hide
          Colin Patrick McCabe added a comment -

          Thanks for looking at this, Akira.

          Since runBlockReaderLocalTest is the test function that requires the native library, why not put the check there?

          I would rather keep as much test coverage as possible even without libhadoop.so.

          Show
          Colin Patrick McCabe added a comment - Thanks for looking at this, Akira. Since runBlockReaderLocalTest is the test function that requires the native library, why not put the check there? I would rather keep as much test coverage as possible even without libhadoop.so.
          Hide
          Akira AJISAKA added a comment -

          Thanks for the review, Colin Patrick McCabe.
          Attaching a patch that reflects your comment.

          Show
          Akira AJISAKA added a comment - Thanks for the review, Colin Patrick McCabe . Attaching a patch that reflects your comment.
          Hide
          Colin Patrick McCabe added a comment -

          +1. Thanks, Akira.

          Show
          Colin Patrick McCabe added a comment - +1. Thanks, Akira.
          Hide
          Colin Patrick McCabe added a comment -

          committed

          Show
          Colin Patrick McCabe added a comment - committed
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in Hadoop-trunk-Commit #5274 (See https://builds.apache.org/job/Hadoop-trunk-Commit/5274/)
          HDFS-6059. TestBlockReaderLocal fails if native library not available (ajisakaa via cmccabe) (cmccabe: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1574998)

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestBlockReaderLocal.java
          Show
          Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #5274 (See https://builds.apache.org/job/Hadoop-trunk-Commit/5274/ ) HDFS-6059 . TestBlockReaderLocal fails if native library not available (ajisakaa via cmccabe) (cmccabe: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1574998 ) /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestBlockReaderLocal.java
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12633189/HDFS-6059.2.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

          org.apache.hadoop.cli.TestAclCLI

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/6325//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6325//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12633189/HDFS-6059.2.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.cli.TestAclCLI +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/6325//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6325//console This message is automatically generated.

            People

            • Assignee:
              Akira AJISAKA
              Reporter:
              Akira AJISAKA
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development