Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-605

There's not need to run fault-inject tests by 'run-test-hdfs-with-mr' target

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.21.0
    • Fix Version/s: 0.21.0
    • Component/s: build, test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      It turns out that running fault injection tests doesn't make any sense when run-test-hdfs-with-mr target is being executed. Thus, build.xml has to be modified.

      1. HDFS-605.patch
        2 kB
        Konstantin Boudnik

        Activity

        Hide
        Konstantin Boudnik added a comment -

        The patch solves the problem by removing all 'with-mr' related code from fault-inject's context.

        Show
        Konstantin Boudnik added a comment - The patch solves the problem by removing all 'with-mr' related code from fault-inject's context.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        +1

        Show
        Tsz Wo Nicholas Sze added a comment - +1
        Hide
        Konstantin Boudnik added a comment -

        All tests have passed as expected. The sequence of test executions is like this:

        run-test-hdfs:
        ...
        run-test-hdfs-with-mr:
        ...
        run-test-hdfs-fault-inject:
        ...
        run-test-hdfs:
            [mkdir] Created dir: /home/cos/work/Hdfs/build-fi/test/data
            [mkdir] Created dir: /home/cos/work/Hdfs/build-fi/test/logs
             [copy] Copying 1 file to /home/cos/work/Hdfs/build-fi/test/extraconf
             [copy] Copying 1 file to /home/cos/work/Hdfs/build-fi/test/extraconf
            [junit] Running org.apache.hadoop.hdfs.server.datanode.TestFiDataTransferProtocol
            [junit] Tests run: 16, Failures: 0, Errors: 0, Time elapsed: 243.421 sec
        
        checkfailure:
        
        BUILD SUCCESSFUL
        

        so no 'with-mr' tests are being ran in fault-injection mode.

        Show
        Konstantin Boudnik added a comment - All tests have passed as expected. The sequence of test executions is like this: run-test-hdfs: ... run-test-hdfs-with-mr: ... run-test-hdfs-fault-inject: ... run-test-hdfs: [mkdir] Created dir: /home/cos/work/Hdfs/build-fi/test/data [mkdir] Created dir: /home/cos/work/Hdfs/build-fi/test/logs [copy] Copying 1 file to /home/cos/work/Hdfs/build-fi/test/extraconf [copy] Copying 1 file to /home/cos/work/Hdfs/build-fi/test/extraconf [junit] Running org.apache.hadoop.hdfs.server.datanode.TestFiDataTransferProtocol [junit] Tests run: 16, Failures: 0, Errors: 0, Time elapsed: 243.421 sec checkfailure: BUILD SUCCESSFUL so no 'with-mr' tests are being ran in fault-injection mode.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12418988/HDFS-605.patch
        against trunk revision 812701.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/5/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/5/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/5/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/5/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12418988/HDFS-605.patch against trunk revision 812701. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/5/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/5/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/5/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/5/console This message is automatically generated.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        I have committed this. Thanks, Cos!

        Show
        Tsz Wo Nicholas Sze added a comment - I have committed this. Thanks, Cos!
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #25 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/25/)
        . Do not run fault injection tests in the run-test-hdfs-with-mr target. Contributed by Konstantin Boudnik

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #25 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/25/ ) . Do not run fault injection tests in the run-test-hdfs-with-mr target. Contributed by Konstantin Boudnik
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #78 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/78/)
        . Do not run fault injection tests in the run-test-hdfs-with-mr target. Contributed by Konstantin Boudnik

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #78 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/78/ ) . Do not run fault injection tests in the run-test-hdfs-with-mr target. Contributed by Konstantin Boudnik
        Hide
        Hudson added a comment -

        Integrated in Hdfs-Patch-h5.grid.sp2.yahoo.net #21 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/21/)

        Show
        Hudson added a comment - Integrated in Hdfs-Patch-h5.grid.sp2.yahoo.net #21 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/21/ )
        Hide
        Hudson added a comment -

        Integrated in Hdfs-Patch-h2.grid.sp2.yahoo.net #6 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/6/)
        . Do not run fault injection tests in the run-test-hdfs-with-mr target. Contributed by Konstantin Boudnik

        Show
        Hudson added a comment - Integrated in Hdfs-Patch-h2.grid.sp2.yahoo.net #6 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/6/ ) . Do not run fault injection tests in the run-test-hdfs-with-mr target. Contributed by Konstantin Boudnik

          People

          • Assignee:
            Konstantin Boudnik
            Reporter:
            Konstantin Boudnik
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development