Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-6047

TestPread NPE inside in DFSInputStream hedgedFetchBlockByteRange

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.4.0
    • Fix Version/s: 2.4.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Our Andrew Wang saw this on internal test cluster running trunk:

      java.lang.NullPointerException: null
      	at org.apache.hadoop.hdfs.DFSInputStream.hedgedFetchBlockByteRange(DFSInputStream.java:1181)
      	at org.apache.hadoop.hdfs.DFSInputStream.read(DFSInputStream.java:1296)
      	at org.apache.hadoop.fs.FSInputStream.readFully(FSInputStream.java:78)
      	at org.apache.hadoop.fs.FSDataInputStream.readFully(FSDataInputStream.java:108)
      	at org.apache.hadoop.hdfs.TestPread.pReadFile(TestPread.java:151)
      	at org.apache.hadoop.hdfs.TestPread.testMaxOutHedgedReadPool(TestPread.java:292)
      

      TestPread was failing.

      The NPE comes of our presuming there always a chosenNode as we set up hedged reads inside in hedgedFetchBlockByteRange (chosenNode is null'd each time through the loop). Usually there is a chosenNode but need to allow for case where there is not.

      1. HDFS-6047.txt
        1 kB
        stack
      2. HDFS-6047.txt
        1 kB
        stack
      3. HDFS-6047.txt
        1 kB
        stack

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        1m 11s 1 stack 04/Mar/14 00:58
        Patch Available Patch Available Resolved Resolved
        20h 17m 1 stack 04/Mar/14 21:15
        Resolved Resolved Closed Closed
        36d 15h 56m 1 Arun C Murthy 10/Apr/14 14:11
        Arun C Murthy made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk #1717 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1717/)
        HDFS-6047 TestPread NPE inside in DFSInputStream hedgedFetchBlockByteRange (stack) (stack: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1574205)

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java
        Show
        Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #1717 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1717/ ) HDFS-6047 TestPread NPE inside in DFSInputStream hedgedFetchBlockByteRange (stack) (stack: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1574205 ) /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #1692 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1692/)
        HDFS-6047 TestPread NPE inside in DFSInputStream hedgedFetchBlockByteRange (stack) (stack: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1574205)

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java
        Show
        Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #1692 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1692/ ) HDFS-6047 TestPread NPE inside in DFSInputStream hedgedFetchBlockByteRange (stack) (stack: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1574205 ) /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk #500 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/500/)
        HDFS-6047 TestPread NPE inside in DFSInputStream hedgedFetchBlockByteRange (stack) (stack: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1574205)

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java
        Show
        Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #500 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/500/ ) HDFS-6047 TestPread NPE inside in DFSInputStream hedgedFetchBlockByteRange (stack) (stack: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1574205 ) /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in Hadoop-trunk-Commit #5261 (See https://builds.apache.org/job/Hadoop-trunk-Commit/5261/)
        HDFS-6047 TestPread NPE inside in DFSInputStream hedgedFetchBlockByteRange (stack) (stack: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1574205)

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java
        Show
        Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #5261 (See https://builds.apache.org/job/Hadoop-trunk-Commit/5261/ ) HDFS-6047 TestPread NPE inside in DFSInputStream hedgedFetchBlockByteRange (stack) (stack: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1574205 ) /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java
        stack made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Resolution Fixed [ 1 ]
        Hide
        stack added a comment -

        Committed to trunk, branch-2, and to branch-2.4.

        Show
        stack added a comment - Committed to trunk, branch-2, and to branch-2.4.
        Hide
        stack added a comment -

        The three failures are not related (you have to enable hedged reads, this is a small fix for a NPE only, and the failures are from other domains altogether).

        I've run this patch through QA three times. Twice, it failed with not tests failed (zombies?), and this last time we have unrelated fails. Going to commit.

        Show
        stack added a comment - The three failures are not related (you have to enable hedged reads, this is a small fix for a NPE only, and the failures are from other domains altogether). I've run this patch through QA three times. Twice, it failed with not tests failed (zombies?), and this last time we have unrelated fails. Going to commit.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12632554/HDFS-6047.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

        org.apache.hadoop.hdfs.server.namenode.ha.TestHASafeMode
        org.apache.hadoop.cli.TestAclCLI
        org.apache.hadoop.hdfs.qjournal.client.TestQuorumJournalManager

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/6296//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6296//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12632554/HDFS-6047.txt against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.namenode.ha.TestHASafeMode org.apache.hadoop.cli.TestAclCLI org.apache.hadoop.hdfs.qjournal.client.TestQuorumJournalManager +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/6296//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6296//console This message is automatically generated.
        stack made changes -
        Attachment HDFS-6047.txt [ 12632554 ]
        Hide
        stack added a comment -

        Retry. The findbugs issue I see is an old one and it seems hdfs precommit is a bit flakey so unlikely this patch that is causing the zombie failure.

        Show
        stack added a comment - Retry. The findbugs issue I see is an old one and it seems hdfs precommit is a bit flakey so unlikely this patch that is causing the zombie failure.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12632437/HDFS-6047.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        -1 findbugs. The patch appears to introduce 3 new Findbugs (version 1.3.9) warnings.

        -1 release audit. The applied patch generated 1 release audit warnings.

        -1 core tests. The test build failed in hadoop-hdfs-project/hadoop-hdfs

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/6291//testReport/
        Release audit warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/6291//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/6291//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6291//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12632437/HDFS-6047.txt against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. -1 findbugs . The patch appears to introduce 3 new Findbugs (version 1.3.9) warnings. -1 release audit . The applied patch generated 1 release audit warnings. -1 core tests . The test build failed in hadoop-hdfs-project/hadoop-hdfs +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/6291//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/6291//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/6291//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6291//console This message is automatically generated.
        stack made changes -
        Attachment HDFS-6047.txt [ 12632437 ]
        Hide
        stack added a comment -

        The findbugs are from files not touched by this patch. No tests seem to have failed in the test listing. Retrying....

        Show
        stack added a comment - The findbugs are from files not touched by this patch. No tests seem to have failed in the test listing. Retrying....
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12632406/HDFS-6047.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        -1 findbugs. The patch appears to introduce 3 new Findbugs (version 1.3.9) warnings.

        -1 release audit. The applied patch generated 1 release audit warnings.

        -1 core tests. The test build failed in hadoop-hdfs-project/hadoop-hdfs

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/6287//testReport/
        Release audit warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/6287//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/6287//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6287//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12632406/HDFS-6047.txt against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. -1 findbugs . The patch appears to introduce 3 new Findbugs (version 1.3.9) warnings. -1 release audit . The applied patch generated 1 release audit warnings. -1 core tests . The test build failed in hadoop-hdfs-project/hadoop-hdfs +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/6287//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/6287//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/6287//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6287//console This message is automatically generated.
        Hide
        Andrew Wang added a comment -

        +1 pending Jenkins, thanks for tracing this down stack!

        Show
        Andrew Wang added a comment - +1 pending Jenkins, thanks for tracing this down stack!
        stack made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        stack made changes -
        Field Original Value New Value
        Attachment HDFS-6047.txt [ 12632406 ]
        Hide
        stack added a comment -

        Check for null chosenNode before adding it to list of nodes to ignore.

        Show
        stack added a comment - Check for null chosenNode before adding it to list of nodes to ignore.
        stack created issue -

          People

          • Assignee:
            stack
            Reporter:
            stack
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development