Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-6030

Remove an unused constructor in INode.java

VotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Task
    • Status: Closed
    • Trivial
    • Resolution: Fixed
    • 2.3.0
    • 2.4.0
    • None
    • None

    Description

      When I look at fix of HDFS-4879, I noticed that class BlocksMapUpdateInfo in INode.java, has a constructor that still uses ArrayList<Block> (which HDFS-4879 tries to replace with ChunkedArrayList for better memory efficiency)

          public static class BlocksMapUpdateInfo { 
          ...... 
          public BlocksMapUpdateInfo(List<Block> toDeleteList) {
            this.toDeleteList = toDeleteList == null ? new ArrayList<Block>()
                : toDeleteList;
          }
          ......
          }
      

      It turns out that this constructor is not used anywhere (thanks Colin McCabe for pointing this out). I'm filing this JIRA to remove it.

      Attachments

        1. HDFS-6030.001.patch
          0.8 kB
          Yongjun Zhang

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            yzhangal Yongjun Zhang
            yzhangal Yongjun Zhang
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment