Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-601

TestBlockReport should obtain data directories from MiniHDFSCluster

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: Append Branch, 0.21.0
    • Fix Version/s: 0.21.0
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      TestBlockReport relies on that "test.build.data" property is set in configuration, which is not always correct, e.g. when you run test from eclipse. It would be better to get data directories directly from the mini-cluster.

      1. HDFS-601.patch
        2 kB
        Konstantin Boudnik
      2. HDFS-601.patch
        2 kB
        Konstantin Boudnik

        Issue Links

          Activity

          Hide
          Hudson added a comment -

          Integrated in Hdfs-Patch-h2.grid.sp2.yahoo.net #6 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/6/)
          . TestBlockReport obtains data directories directly from MiniHDFSCluster. Contributed by Konstantin Boudnik.

          Show
          Hudson added a comment - Integrated in Hdfs-Patch-h2.grid.sp2.yahoo.net #6 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/6/ ) . TestBlockReport obtains data directories directly from MiniHDFSCluster. Contributed by Konstantin Boudnik.
          Hide
          Hudson added a comment -

          Integrated in Hdfs-Patch-h5.grid.sp2.yahoo.net #26 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/26/)

          Show
          Hudson added a comment - Integrated in Hdfs-Patch-h5.grid.sp2.yahoo.net #26 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/26/ )
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #82 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/82/)
          . TestBlockReport obtains data directories directly from MiniHDFSCluster. Contributed by Konstantin Boudnik.

          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #82 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/82/ ) . TestBlockReport obtains data directories directly from MiniHDFSCluster. Contributed by Konstantin Boudnik.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #30 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/30/)
          . TestBlockReport obtains data directories directly from MiniHDFSCluster. Contributed by Konstantin Boudnik.

          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #30 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/30/ ) . TestBlockReport obtains data directories directly from MiniHDFSCluster. Contributed by Konstantin Boudnik.
          Hide
          Konstantin Shvachko added a comment -

          I just committed this to trunk. It will get into Append branch while merging.
          Thank you Konstantin.

          Show
          Konstantin Shvachko added a comment - I just committed this to trunk. It will get into Append branch while merging. Thank you Konstantin.
          Hide
          Konstantin Shvachko added a comment -

          +1

          Show
          Konstantin Shvachko added a comment - +1
          Hide
          Konstantin Boudnik added a comment -

          The test failure is unrelated to the patch, obviously. It is a timeout someplace else
          TestDatanodeBlockScanner.testBlockCorruptionPolicy: Timeout occurred. Please note the time in the report does not reflect the time until the timeout.
          The patch seems to be good to go

          Show
          Konstantin Boudnik added a comment - The test failure is unrelated to the patch, obviously. It is a timeout someplace else TestDatanodeBlockScanner.testBlockCorruptionPolicy: Timeout occurred. Please note the time in the report does not reflect the time until the timeout. The patch seems to be good to go
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12418967/HDFS-601.patch
          against trunk revision 813101.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/20/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/20/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/20/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/20/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12418967/HDFS-601.patch against trunk revision 813101. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/20/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/20/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/20/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/20/console This message is automatically generated.
          Hide
          Konstantin Boudnik added a comment -

          The patch is already attached (for the trunk)

          Show
          Konstantin Boudnik added a comment - The patch is already attached (for the trunk)
          Hide
          Konstantin Boudnik added a comment -

          Need to re-apply the patch

          Show
          Konstantin Boudnik added a comment - Need to re-apply the patch
          Hide
          Konstantin Boudnik added a comment -

          Oops, my bad - the previous patch has been made against Append branch which is slightly behind of the trunk.
          This is one is for trunk and should apply cleanly.

          Show
          Konstantin Boudnik added a comment - Oops, my bad - the previous patch has been made against Append branch which is slightly behind of the trunk. This is one is for trunk and should apply cleanly.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12418957/HDFS-601.patch
          against trunk revision 812656.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          -1 patch. The patch command could not apply the patch.

          Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/16/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12418957/HDFS-601.patch against trunk revision 812656. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/16/console This message is automatically generated.
          Hide
          Konstantin Boudnik added a comment -

          The trivial patch has been provided so let's see what Hudson has to say about it

          Show
          Konstantin Boudnik added a comment - The trivial patch has been provided so let's see what Hudson has to say about it
          Hide
          Konstantin Boudnik added a comment -

          The patch addresses the problem.
          Also, some unused variables were removed and the imports' list has been fixed accordingly.

          Show
          Konstantin Boudnik added a comment - The patch addresses the problem. Also, some unused variables were removed and the imports' list has been fixed accordingly.

            People

            • Assignee:
              Konstantin Boudnik
              Reporter:
              Konstantin Shvachko
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development