[HDFS-5982] Need to update snapshot manager when applying editlog for deleting a snapshottable directory

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 2.3.0
• Fix Version/s: 2.4.0
• Component/s: namenode
• Hadoop Flags: Reviewed
• Assignee: Jing Zhao
• Reporter: Tassapol Athiapinya
• Created: 20/Feb/14 04:42
• Updated: 10/Apr/14 13:11
• Resolved: 21/Feb/14 00:19

Description

Currently after deleting a snapshottable directory which does not have snapshots any more, we also remove the directory from the snapshottable directory list in SnapshotManager. This works fine when handling a delete request from user. However, when we apply the OP_DELETE editlog, FSDirectory#unprotectedDelete(String, long) is called, which does not contain the "updating snapshot manager" process. This may leave an non-existent inode id in the snapshottable directory list, and can even lead to FSImage corruption.