Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-595

FsPermission tests need to be updated for new octal configuration parameter from HADOOP-6234

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: hdfs-client
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Unit tests updated to match syntax of new configuration parameters.

      Description

      HADOOP-6234 changed the format of the configuration umask value. Tests that use this value need to be updated.

      1. HDFS-595.patch
        2 kB
        Jakob Homan
      2. HDFS-595.patch
        3 kB
        Jakob Homan
      3. HDFS-595-Y20.patch
        2 kB
        Jakob Homan

        Issue Links

          Activity

          Hide
          Jakob Homan added a comment -

          Attaching patch to update tests that set umask. Note that updated jars from HADOOP-6234 are needed. As such, can't submit patch to Hudson. Manually tested.

          All unit tests pass.

          With updated jars for test-patch:

               [exec] +1 overall.  
               [exec] 
               [exec]     +1 @author.  The patch does not contain any @author tags.
               [exec] 
               [exec]     +1 tests included.  The patch appears to include 6 new or modified tests.
               [exec] 
               [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
               [exec] 
               [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
               [exec] 
               [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
               [exec] 
               [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.
          
          Show
          Jakob Homan added a comment - Attaching patch to update tests that set umask. Note that updated jars from HADOOP-6234 are needed. As such, can't submit patch to Hudson. Manually tested. All unit tests pass. With updated jars for test-patch: [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 6 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
          Hide
          Jakob Homan added a comment -

          updated patch to remove unneeded import. Otherwise unchanged.

          Show
          Jakob Homan added a comment - updated patch to remove unneeded import. Otherwise unchanged.
          Hide
          Kan Zhang added a comment -

          +1 for the patch

          Show
          Kan Zhang added a comment - +1 for the patch
          Hide
          Suresh Srinivas added a comment -

          I committed the changes. Thanks Jakob.

          Show
          Suresh Srinivas added a comment - I committed the changes. Thanks Jakob.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #22 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/22/)
          . umask settings in configuration may now use octal or symbolic instead of decimal. Contributed by Jakob Homan.

          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #22 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/22/ ) . umask settings in configuration may now use octal or symbolic instead of decimal. Contributed by Jakob Homan.
          Hide
          Hudson added a comment -

          Integrated in Hdfs-Patch-h2.grid.sp2.yahoo.net #5 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/5/)
          . umask settings in configuration may now use octal or symbolic instead of decimal. Contributed by Jakob Homan.

          Show
          Hudson added a comment - Integrated in Hdfs-Patch-h2.grid.sp2.yahoo.net #5 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/5/ ) . umask settings in configuration may now use octal or symbolic instead of decimal. Contributed by Jakob Homan.
          Hide
          Hudson added a comment -

          Integrated in Hdfs-Patch-h5.grid.sp2.yahoo.net #21 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/21/)

          Show
          Hudson added a comment - Integrated in Hdfs-Patch-h5.grid.sp2.yahoo.net #21 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/21/ )
          Hide
          Robert Chansler added a comment -

          Editorial pass over all release notes prior to publication of 0.21.

          Show
          Robert Chansler added a comment - Editorial pass over all release notes prior to publication of 0.21.
          Hide
          Jakob Homan added a comment -

          Attaching patch for Y!'s 20 branch.

          Show
          Jakob Homan added a comment - Attaching patch for Y!'s 20 branch.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          HDFS-595-Y20.patch looks good.

          Show
          Tsz Wo Nicholas Sze added a comment - HDFS-595 -Y20.patch looks good.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          > HDFS-595-Y20.patch looks good.
          I mean +1 on the patch.

          Show
          Tsz Wo Nicholas Sze added a comment - > HDFS-595 -Y20.patch looks good. I mean +1 on the patch.

            People

            • Assignee:
              Jakob Homan
              Reporter:
              Jakob Homan
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development