[HDFS-5940] Minor cleanups to ShortCircuitReplica, FsDatasetCache, and DomainSocketWatcher

• Type: Sub-task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.4.0
• Fix Version/s: 2.4.0
• Component/s: hdfs-client
• Target Version/s: 2.4.0
• Assignee: Colin McCabe
• Reporter: Colin McCabe
• Created: 12/Feb/14 21:52
• Updated: 10/Apr/14 13:11
• Resolved: 13/Feb/14 03:14

Description

ShortCircuitReplica#Key and FsDatasetCache#Key are pretty much identical code and should be factored out to an external class. (There will soon be a need for a third user of such an identifier.)

Another minor cleanup is that DomainSocketWatcher should not implement Thread. It contains a thread currently, but I forgot to remove the "extends".