Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-5918

Avoid logging unnecessary trace in IPCLoggerChannel#close()

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Duplicate
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      Avoid logging stack trace while close() in IPCLoggerChannel.

        @Override
        public void close() {
          QuorumJournalManager.LOG.info("Closing", new Exception());
          // No more tasks may be submitted after this point.
          executor.shutdown();
          if (proxy != null) {
            // TODO: this can hang for quite some time if the client
            // is currently in the middle of a call to a downed JN.
            // We should instead do this asynchronously, and just stop
            // making any more calls after this point (eg clear the queue)
            RPC.stopProxy(proxy);
          }
        }

      This might have been left out by mistake in HDFS-5074

      1. HDFS-5918.patch
        0.7 kB
        Vinayakumar B

        Issue Links

          Activity

          Hide
          Vinayakumar B added a comment -

          NP Jing

          Show
          Vinayakumar B added a comment - NP Jing
          Hide
          Jing Zhao added a comment -

          Oops, sorry Vinay, I should search the jira first before I filed HDFS-6018.
          Close this jira as duplicate since we already commit HDFS-6018. I will be more careful next time.

          Show
          Jing Zhao added a comment - Oops, sorry Vinay, I should search the jira first before I filed HDFS-6018 . Close this jira as duplicate since we already commit HDFS-6018 . I will be more careful next time.
          Hide
          Vinayakumar B added a comment -

          This is fixed in HDFS-6018.

          Show
          Vinayakumar B added a comment - This is fixed in HDFS-6018 .
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12627927/HDFS-5918.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/6093//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6093//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12627927/HDFS-5918.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/6093//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6093//console This message is automatically generated.
          Hide
          Vinayakumar B added a comment -

          Attached a patch to remove unnecessary trace

          Show
          Vinayakumar B added a comment - Attached a patch to remove unnecessary trace

            People

            • Assignee:
              Vinayakumar B
              Reporter:
              Vinayakumar B
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development