[HDFS-5913] Nfs3Utils#getWccAttr() should check attr parameter against null

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.4.0
• Component/s: nfs
• Hadoop Flags: Reviewed
• Assignee: Brandon Li
• Reporter: Ted Yu
• Created: 07/Feb/14 23:43
• Updated: 10/Apr/14 13:11
• Resolved: 13/Feb/14 22:41

Description

In RpcProgramNfs3#commit() :

      Nfs3FileAttributes postOpAttr = null;
      try {
        postOpAttr = writeManager.getFileAttr(dfsClient, handle, iug);
      } catch (IOException e1) {
        LOG.info("Can't get postOpAttr for fileId: " + handle.getFileId());
      }
      WccData fileWcc = new WccData(Nfs3Utils.getWccAttr(preOpAttr), postOpAttr);

If there is exception, postOpAttr would be null.
However, Nfs3Utils#getWccAttr() dereferences attr parameter directly.