Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.2.0, 2.4.0
    • Fix Version/s: 2.4.0
    • Component/s: nfs
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      According to the discussion in HDFS-5804:
      1. The NFS gateway should be able to get it's own tgts, and renew them.
      2. We should update the HdfsNfsGateway.apt.vm

      1. HDFS-5898-documentation.patch
        2 kB
        Abin Shahab
      2. HDFS-5898-documentation.patch
        2 kB
        Abin Shahab
      3. HDFS-5898.patch
        4 kB
        Abin Shahab
      4. HDFS-5898.patch
        6 kB
        Abin Shahab
      5. HDFS-5898.patch
        7 kB
        Abin Shahab
      6. HDFS-5898-with-documentation.patch
        9 kB
        Abin Shahab
      7. HDFS-5898-with-documentation.patch
        9 kB
        Abin Shahab
      8. HDFS-5898-with-documentation.patch
        11 kB
        Abin Shahab
      9. HDFS-5898-with-documentation.patch
        11 kB
        Abin Shahab
      10. HDFS-5898-with-documentation.patch
        11 kB
        Abin Shahab
      11. HDFS-5898-with-documentation.patch
        11 kB
        Abin Shahab
      12. HDFS-5898-with-documentation.patch
        11 kB
        Abin Shahab

        Activity

        Hide
        Abin Shahab added a comment -

        Changes to the NFS documentation.

        Show
        Abin Shahab added a comment - Changes to the NFS documentation.
        Hide
        Abin Shahab added a comment -

        Added the proxy user settings to NFS documentation.

        Show
        Abin Shahab added a comment - Added the proxy user settings to NFS documentation.
        Hide
        Aaron T. Myers added a comment -

        Hi Abin, the updates docs look pretty good to me. Two small comments:

        1. Recommend changing "These are the hosts from where the proxying is allowed " to explicitly say "this is the host where the NFS gateway is running." That's the only host that should need to be configured.
        2. You might also consider mentioning that the proxyuser config values can be set to "*" for simplicity.

        Any update on adding the ability for the NFS gateway to log in from a keytab? That, in my opinion, is the far more important issue.

        Show
        Aaron T. Myers added a comment - Hi Abin, the updates docs look pretty good to me. Two small comments: Recommend changing "These are the hosts from where the proxying is allowed " to explicitly say "this is the host where the NFS gateway is running." That's the only host that should need to be configured. You might also consider mentioning that the proxyuser config values can be set to " * " for simplicity. Any update on adding the ability for the NFS gateway to log in from a keytab? That, in my opinion, is the far more important issue.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12627398/HDFS-5898-documentation.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        -1 eclipse:eclipse. The patch failed to build with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        -1 release audit. The applied patch generated 1 release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/6058//testReport/
        Release audit warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/6058//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6058//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12627398/HDFS-5898-documentation.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. -1 eclipse:eclipse . The patch failed to build with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. -1 release audit . The applied patch generated 1 release audit warnings. +1 core tests . The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/6058//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/6058//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6058//console This message is automatically generated.
        Hide
        Abin Shahab added a comment -

        This patch updates the documentation. As for getting the NFS gateway to handle kerberos keytabs, I will get to it in the next 2/4 weeks(depending on our sprint priorities).

        Show
        Abin Shahab added a comment - This patch updates the documentation. As for getting the NFS gateway to handle kerberos keytabs, I will get to it in the next 2/4 weeks(depending on our sprint priorities).
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12627926/HDFS-5898-documentation.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

        org.apache.hadoop.hdfs.server.namenode.TestCacheDirectives

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/6094//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6094//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12627926/HDFS-5898-documentation.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.namenode.TestCacheDirectives +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/6094//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6094//console This message is automatically generated.
        Hide
        Brandon Li added a comment -

        Abin Shahab, the document change looks good. Do you plan to get this committed first, or wait until you have more code and doc change in a new patch?
        Due to the incompatible change of HDFS-5804, I would suggest getting the doc fixed as early as possible if we don't know how soon kerberos keytab related change can be available.

        Show
        Brandon Li added a comment - Abin Shahab , the document change looks good. Do you plan to get this committed first, or wait until you have more code and doc change in a new patch? Due to the incompatible change of HDFS-5804 , I would suggest getting the doc fixed as early as possible if we don't know how soon kerberos keytab related change can be available.
        Hide
        Aaron T. Myers added a comment -

        It's certainly fine to commit the docs change sooner rather than later, but IMO we should also absolutely add the login from keytab capabilities ASAP as HDFS-5804 basically isn't usable in the current state. IMO HDFS-5804 should not have been committed without keytab login support.

        Show
        Aaron T. Myers added a comment - It's certainly fine to commit the docs change sooner rather than later, but IMO we should also absolutely add the login from keytab capabilities ASAP as HDFS-5804 basically isn't usable in the current state. IMO HDFS-5804 should not have been committed without keytab login support.
        Hide
        Abin Shahab added a comment -

        Hi ~atm, ~brandon, I would like to first commit the doc change. I agree with you both that we must add the keytab capabilities.

        Show
        Abin Shahab added a comment - Hi ~atm, ~brandon, I would like to first commit the doc change. I agree with you both that we must add the keytab capabilities.
        Hide
        Daryn Sharp added a comment -

        Too swamped to investigate, but the NFS gateway is using UGI, correct? If so, presumably UGI.loginUserFromKeytab method is insufficient? If yes again, is HADOOP-9317 closer to what you need?

        Show
        Daryn Sharp added a comment - Too swamped to investigate, but the NFS gateway is using UGI, correct? If so, presumably UGI.loginUserFromKeytab method is insufficient? If yes again, is HADOOP-9317 closer to what you need?
        Hide
        Aaron T. Myers added a comment -

        Daryn Sharp - no, I think UGI#loginUserFromKeytab will be just fine for this use case, it's just that the current code doesn't ever call it, or ever attempt to relogin from the keytab.

        Show
        Aaron T. Myers added a comment - Daryn Sharp - no, I think UGI#loginUserFromKeytab will be just fine for this use case, it's just that the current code doesn't ever call it, or ever attempt to relogin from the keytab.
        Hide
        Abin Shahab added a comment -

        I've started working on integrating UGI#loginUserFromKeytab. Should I be using SecurityUtil#login to invoke UGI#loginUserFromKeytab?

        Show
        Abin Shahab added a comment - I've started working on integrating UGI#loginUserFromKeytab. Should I be using SecurityUtil#login to invoke UGI#loginUserFromKeytab?
        Hide
        Abin Shahab added a comment -

        Also, just to be absolutely clear: This feature will add the capability for the NFS gateway running user( lets call it 'nfsuser') to get its own TGT and renew it.

        I still see an issue with nfsuser proxying for other users who may have expired TGTs).
        Abin

        Show
        Abin Shahab added a comment - Also, just to be absolutely clear: This feature will add the capability for the NFS gateway running user( lets call it 'nfsuser') to get its own TGT and renew it. I still see an issue with nfsuser proxying for other users who may have expired TGTs). Abin
        Hide
        Abin Shahab added a comment -

        NFS gateway uses SecurityUtil to renew TGT.

        Show
        Abin Shahab added a comment - NFS gateway uses SecurityUtil to renew TGT.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12628966/HDFS-5898.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs-nfs.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/6153//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/6153//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs-nfs.html
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6153//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12628966/HDFS-5898.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. -1 findbugs . The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs-nfs. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/6153//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/6153//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs-nfs.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6153//console This message is automatically generated.
        Hide
        Abin Shahab added a comment -

        Added test.

        Show
        Abin Shahab added a comment - Added test.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12629097/HDFS-5898.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        -1 javac. The patch appears to cause the build to fail.

        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6155//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12629097/HDFS-5898.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. -1 javac . The patch appears to cause the build to fail. Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6155//console This message is automatically generated.
        Hide
        Abin Shahab added a comment -

        Fixed build issue.

        Show
        Abin Shahab added a comment - Fixed build issue.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12629112/HDFS-5898.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs-nfs.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/6156//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6156//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12629112/HDFS-5898.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs-nfs. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/6156//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6156//console This message is automatically generated.
        Hide
        Abin Shahab added a comment -

        Added documentation. This now won't require a separate doc patch.

        Show
        Abin Shahab added a comment - Added documentation. This now won't require a separate doc patch.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12629672/HDFS-5898-with-documentation.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The test build failed in hadoop-hdfs-project/hadoop-hdfs-nfs

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/6171//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6171//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12629672/HDFS-5898-with-documentation.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The test build failed in hadoop-hdfs-project/hadoop-hdfs-nfs +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/6171//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6171//console This message is automatically generated.
        Hide
        Abin Shahab added a comment -

        Not sure why the previous build broke.
        Aaron T. Myers, were you able to take a look at this patch?

        Show
        Abin Shahab added a comment - Not sure why the previous build broke. Aaron T. Myers , were you able to take a look at this patch?
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12629805/HDFS-5898-with-documentation.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-nfs.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/6173//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6173//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12629805/HDFS-5898-with-documentation.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-nfs. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/6173//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6173//console This message is automatically generated.
        Hide
        Aaron T. Myers added a comment -

        Hi Abin, thanks a lot for working on this. A few quick comments:

        1. I don't follow how the change in RpcProgramNfs3 is related to this issue. Did that perhaps sneak in to this patch accidentally? Or is it somehow related and I'm completely missing it?
        2. We should probably put the new constants in DFSConfigKeys.java instead of Nfs3.java. Also, entries for them should also be added to hdfs-default.xml to document them.
        3. Did you test this with a long-running NFS gateway against a Kerberized cluster? i.e. longer than the ticket lifetime granted by default from the KDC? The reason I ask is because I see no "reloginFromKeytab" anywhere in the patch, which I would expect to be necessary.
        4. I don't think the included tests actually exercises the new functionality. I tried just applying that portion of the patch and it passed without issue. To write an automated test for this, you'll probably have to use the MiniKdc. Or, you could test this manually against a real cluster/KDC and report the findings here.
        Show
        Aaron T. Myers added a comment - Hi Abin, thanks a lot for working on this. A few quick comments: I don't follow how the change in RpcProgramNfs3 is related to this issue. Did that perhaps sneak in to this patch accidentally? Or is it somehow related and I'm completely missing it? We should probably put the new constants in DFSConfigKeys.java instead of Nfs3.java. Also, entries for them should also be added to hdfs-default.xml to document them. Did you test this with a long-running NFS gateway against a Kerberized cluster? i.e. longer than the ticket lifetime granted by default from the KDC? The reason I ask is because I see no "reloginFromKeytab" anywhere in the patch, which I would expect to be necessary. I don't think the included tests actually exercises the new functionality. I tried just applying that portion of the patch and it passed without issue. To write an automated test for this, you'll probably have to use the MiniKdc. Or, you could test this manually against a real cluster/KDC and report the findings here.
        Hide
        Jing Zhao added a comment -

        I don't follow how the change in RpcProgramNfs3 is related to this issue.

        Yes, I think the change in RpcProgramNfs3 is a regression of HDFS-5913.

        One question: the current patch puts the login into DFSClientCache#getUserGroupInformation, which is called by the load() method of the loading cache. Thus we will call login() every time we miss the cache. Should we put the login call into the constructor of RpcProgramNfs3 instead?

        Show
        Jing Zhao added a comment - I don't follow how the change in RpcProgramNfs3 is related to this issue. Yes, I think the change in RpcProgramNfs3 is a regression of HDFS-5913 . One question: the current patch puts the login into DFSClientCache#getUserGroupInformation, which is called by the load() method of the loading cache. Thus we will call login() every time we miss the cache. Should we put the login call into the constructor of RpcProgramNfs3 instead?
        Hide
        Aaron T. Myers added a comment -

        Hi Abin, any updates on posting a rev of this patch to address mine and Jing's review feedback?

        Thanks a lot for working on this.

        Show
        Aaron T. Myers added a comment - Hi Abin, any updates on posting a rev of this patch to address mine and Jing's review feedback? Thanks a lot for working on this.
        Hide
        Abin Shahab added a comment -

        Aaron T. Myers, sorry for the delay on this.
        I'll try to get to this by the end of this week/weekend. What you've asked for is clear to me, and the changes are clear to me.

        Show
        Abin Shahab added a comment - Aaron T. Myers , sorry for the delay on this. I'll try to get to this by the end of this week/weekend. What you've asked for is clear to me, and the changes are clear to me.
        Hide
        Abin Shahab added a comment -

        Moved constants, added relogin.

        Show
        Abin Shahab added a comment - Moved constants, added relogin.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12632183/HDFS-5898-with-documentation.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        -1 findbugs. The patch appears to introduce 3 new Findbugs (version 1.3.9) warnings.

        -1 release audit. The applied patch generated 1 release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-nfs:

        org.apache.hadoop.hdfs.server.datanode.TestIncrementalBlockReports
        org.apache.hadoop.hdfs.server.namenode.ha.TestHASafeMode

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/6275//testReport/
        Release audit warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/6275//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/6275//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6275//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12632183/HDFS-5898-with-documentation.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. -1 findbugs . The patch appears to introduce 3 new Findbugs (version 1.3.9) warnings. -1 release audit . The applied patch generated 1 release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-nfs: org.apache.hadoop.hdfs.server.datanode.TestIncrementalBlockReports org.apache.hadoop.hdfs.server.namenode.ha.TestHASafeMode +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/6275//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/6275//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/6275//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6275//console This message is automatically generated.
        Hide
        Abin Shahab added a comment -

        Aaron T. Myers, I removed the regression, and applied all the changes you and Jing requested. I did not add MiniKdc, as I need some help on how to move it up to the hadoop-common project so that I can access it from hadoop-hdfs-nfs project.

        Show
        Abin Shahab added a comment - Aaron T. Myers , I removed the regression, and applied all the changes you and Jing requested. I did not add MiniKdc, as I need some help on how to move it up to the hadoop-common project so that I can access it from hadoop-hdfs-nfs project.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12632307/HDFS-5898-with-documentation.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        -1 findbugs. The patch appears to introduce 4 new Findbugs (version 1.3.9) warnings.

        -1 release audit. The applied patch generated 1 release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-nfs:

        org.apache.hadoop.hdfs.TestPread

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/6276//testReport/
        Release audit warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/6276//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/6276//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/6276//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs-nfs.html
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6276//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12632307/HDFS-5898-with-documentation.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. -1 findbugs . The patch appears to introduce 4 new Findbugs (version 1.3.9) warnings. -1 release audit . The applied patch generated 1 release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-nfs: org.apache.hadoop.hdfs.TestPread +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/6276//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/6276//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/6276//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/6276//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs-nfs.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6276//console This message is automatically generated.
        Hide
        Abin Shahab added a comment -

        Can't figure out why the test breaks.

        Show
        Abin Shahab added a comment - Can't figure out why the test breaks.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12632363/HDFS-5898-with-documentation.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        -1 findbugs. The patch appears to introduce 4 new Findbugs (version 1.3.9) warnings.

        -1 release audit. The applied patch generated 1 release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-nfs:

        org.apache.hadoop.hdfs.server.namenode.ha.TestHASafeMode

        The test build failed in hadoop-hdfs-project/hadoop-hdfs-nfs

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/6283//testReport/
        Release audit warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/6283//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/6283//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/6283//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs-nfs.html
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6283//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12632363/HDFS-5898-with-documentation.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. -1 findbugs . The patch appears to introduce 4 new Findbugs (version 1.3.9) warnings. -1 release audit . The applied patch generated 1 release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-nfs: org.apache.hadoop.hdfs.server.namenode.ha.TestHASafeMode The test build failed in hadoop-hdfs-project/hadoop-hdfs-nfs +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/6283//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/6283//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/6283//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/6283//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs-nfs.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6283//console This message is automatically generated.
        Hide
        Abin Shahab added a comment -

        Cannot reproduce test failures.

        Show
        Abin Shahab added a comment - Cannot reproduce test failures.
        Hide
        Daryn Sharp added a comment -

        Quick glance, in the client cache, you don't want to re-initialize the ugi conf or force a new login. Maybe just use realUser.checkTGTAndReloginFromKeytab before creating the proxy user. However that's probably not even necessary because the RPC client will relogin from keytab when the TGT goes bad.

        Show
        Daryn Sharp added a comment - Quick glance, in the client cache, you don't want to re-initialize the ugi conf or force a new login. Maybe just use realUser.checkTGTAndReloginFromKeytab before creating the proxy user. However that's probably not even necessary because the RPC client will relogin from keytab when the TGT goes bad.
        Hide
        Abin Shahab added a comment -

        Hi Daryn Sharp, I have done what you've asked in my latest patch. I'm not sure about the test failures, as they don't seem to be related.

        Show
        Abin Shahab added a comment - Hi Daryn Sharp , I have done what you've asked in my latest patch. I'm not sure about the test failures, as they don't seem to be related.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12632531/HDFS-5898-with-documentation.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-nfs.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/6295//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/6295//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs-nfs.html
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6295//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12632531/HDFS-5898-with-documentation.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. -1 findbugs . The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-nfs. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/6295//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/6295//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs-nfs.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6295//console This message is automatically generated.
        Hide
        Abin Shahab added a comment -

        Aaron T. Myers, were you able to review the patch? I didn't add the MiniKdc test, but otherwise this should be complete.

        Show
        Abin Shahab added a comment - Aaron T. Myers , were you able to review the patch? I didn't add the MiniKdc test, but otherwise this should be complete.
        Hide
        Aaron T. Myers added a comment -

        The latest patch looks pretty good to me. My only suggestion is to change the config setting names from being prefixed with 'dfs.nfsgateway' to 'dfs.nfs' for consistency with the other setting names.

        +1 once this is addressed.

        Show
        Aaron T. Myers added a comment - The latest patch looks pretty good to me. My only suggestion is to change the config setting names from being prefixed with 'dfs.nfsgateway' to 'dfs.nfs' for consistency with the other setting names. +1 once this is addressed.
        Hide
        Aaron T. Myers added a comment -

        Forgot to mention - I'm pretty confident that the findbugs warning is unrelated to this patch.

        Show
        Aaron T. Myers added a comment - Forgot to mention - I'm pretty confident that the findbugs warning is unrelated to this patch.
        Hide
        Abin Shahab added a comment -

        Thanks for the review. Are you sure changing 'nfsgateway' to 'nfs' is not going to confuse some people? I wanted to specifically call out that this is the nfs gateway for hdfs, and NOT the nfs mount for the HA namenode.

        Show
        Abin Shahab added a comment - Thanks for the review. Are you sure changing 'nfsgateway' to 'nfs' is not going to confuse some people? I wanted to specifically call out that this is the nfs gateway for hdfs, and NOT the nfs mount for the HA namenode.
        Hide
        Aaron T. Myers added a comment -

        That's a good thought, but I think we're fine. The HA NFS stuff doesn't even use the word "nfs" in its configs - you just set the dfs.namenode.shared.dir to point to a path that's on an NFS server, and in any case it's far more critical that we be consistent with the current NFS gateway-related configs, e.g. dfs.nfs.exports.allowed.hosts.

        Show
        Aaron T. Myers added a comment - That's a good thought, but I think we're fine. The HA NFS stuff doesn't even use the word "nfs" in its configs - you just set the dfs.namenode.shared.dir to point to a path that's on an NFS server, and in any case it's far more critical that we be consistent with the current NFS gateway-related configs, e.g. dfs.nfs.exports.allowed.hosts.
        Hide
        Abin Shahab added a comment -

        Replaced 'nfsgateway' with 'nfs'

        Show
        Abin Shahab added a comment - Replaced 'nfsgateway' with 'nfs'
        Hide
        Aaron T. Myers added a comment -

        The latest patch looks good to me. +1 pending Jenkins.

        Show
        Aaron T. Myers added a comment - The latest patch looks good to me. +1 pending Jenkins.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12632853/HDFS-5898-with-documentation.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-nfs:

        org.apache.hadoop.cli.TestHDFSCLI

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/6308//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/6308//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs-nfs.html
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6308//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12632853/HDFS-5898-with-documentation.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. -1 findbugs . The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-nfs: org.apache.hadoop.cli.TestHDFSCLI +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/6308//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/6308//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs-nfs.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/6308//console This message is automatically generated.
        Hide
        Aaron T. Myers added a comment -

        +1, the latest patch looks good to me. TestHDFSCLI appears to be failing on trunk right now and I'm confident that the findbugs warning is unrelated.

        I'm going to commit this momentarily.

        Show
        Aaron T. Myers added a comment - +1, the latest patch looks good to me. TestHDFSCLI appears to be failing on trunk right now and I'm confident that the findbugs warning is unrelated. I'm going to commit this momentarily.
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in Hadoop-trunk-Commit #5271 (See https://builds.apache.org/job/Hadoop-trunk-Commit/5271/)
        HDFS-5898. Allow NFS gateway to login/relogin from its kerberos keytab. Contributed by Abin Shahab. (atm: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1574693)

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/mount/RpcProgramMountd.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/DFSClientCache.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/RpcProgramNfs3.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs-nfs/src/test/java/org/apache/hadoop/hdfs/nfs/nfs3/TestDFSClientCache.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/site/apt/HdfsNfsGateway.apt.vm
        Show
        Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #5271 (See https://builds.apache.org/job/Hadoop-trunk-Commit/5271/ ) HDFS-5898 . Allow NFS gateway to login/relogin from its kerberos keytab. Contributed by Abin Shahab. (atm: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1574693 ) /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/mount/RpcProgramMountd.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/DFSClientCache.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/RpcProgramNfs3.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs-nfs/src/test/java/org/apache/hadoop/hdfs/nfs/nfs3/TestDFSClientCache.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/site/apt/HdfsNfsGateway.apt.vm
        Hide
        Aaron T. Myers added a comment -

        I've just committed this to trunk, branch-2, and branch-2.4

        Thanks a lot for the contribution, Abin.

        Show
        Aaron T. Myers added a comment - I've just committed this to trunk, branch-2, and branch-2.4 Thanks a lot for the contribution, Abin.
        Hide
        Abin Shahab added a comment -

        Aaron T. Myers You're welcome. Glad to see this go through.

        Show
        Abin Shahab added a comment - Aaron T. Myers You're welcome. Glad to see this go through.
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #1693 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1693/)
        HDFS-5898. Allow NFS gateway to login/relogin from its kerberos keytab. Contributed by Abin Shahab. (atm: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1574693)

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/mount/RpcProgramMountd.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/DFSClientCache.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/RpcProgramNfs3.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs-nfs/src/test/java/org/apache/hadoop/hdfs/nfs/nfs3/TestDFSClientCache.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/site/apt/HdfsNfsGateway.apt.vm
        Show
        Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #1693 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1693/ ) HDFS-5898 . Allow NFS gateway to login/relogin from its kerberos keytab. Contributed by Abin Shahab. (atm: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1574693 ) /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/mount/RpcProgramMountd.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/DFSClientCache.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/RpcProgramNfs3.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs-nfs/src/test/java/org/apache/hadoop/hdfs/nfs/nfs3/TestDFSClientCache.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/site/apt/HdfsNfsGateway.apt.vm
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk #501 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/501/)
        HDFS-5898. Allow NFS gateway to login/relogin from its kerberos keytab. Contributed by Abin Shahab. (atm: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1574693)

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/mount/RpcProgramMountd.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/DFSClientCache.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/RpcProgramNfs3.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs-nfs/src/test/java/org/apache/hadoop/hdfs/nfs/nfs3/TestDFSClientCache.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/site/apt/HdfsNfsGateway.apt.vm
        Show
        Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #501 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/501/ ) HDFS-5898 . Allow NFS gateway to login/relogin from its kerberos keytab. Contributed by Abin Shahab. (atm: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1574693 ) /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/mount/RpcProgramMountd.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/DFSClientCache.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/RpcProgramNfs3.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs-nfs/src/test/java/org/apache/hadoop/hdfs/nfs/nfs3/TestDFSClientCache.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/site/apt/HdfsNfsGateway.apt.vm
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk #1718 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1718/)
        HDFS-5898. Allow NFS gateway to login/relogin from its kerberos keytab. Contributed by Abin Shahab. (atm: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1574693)

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/mount/RpcProgramMountd.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/DFSClientCache.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/RpcProgramNfs3.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs-nfs/src/test/java/org/apache/hadoop/hdfs/nfs/nfs3/TestDFSClientCache.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/site/apt/HdfsNfsGateway.apt.vm
        Show
        Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #1718 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1718/ ) HDFS-5898 . Allow NFS gateway to login/relogin from its kerberos keytab. Contributed by Abin Shahab. (atm: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1574693 ) /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/mount/RpcProgramMountd.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/DFSClientCache.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/RpcProgramNfs3.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs-nfs/src/test/java/org/apache/hadoop/hdfs/nfs/nfs3/TestDFSClientCache.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/site/apt/HdfsNfsGateway.apt.vm

          People

          • Assignee:
            Abin Shahab
            Reporter:
            Jing Zhao
          • Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development