Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.21.0
    • Fix Version/s: 0.21.0
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      TestBlocksWithNotEnoughRacks failed with the following error on my Mac laptop:

      Testcase: testUnderReplicatedNotEnoughRacks took 33.209 sec
              FAILED
      null
      junit.framework.AssertionFailedError: null
              at org.apache.hadoop.hdfs.server.namenode.TestBlocksWithNotEnoughRacks.testUnderReplicatedNotEnoughRacks(TestBlocksWithNotEnoughRacks.java:127)
      
      1. HDFS-586.1.patch
        4 kB
        Jitendra Nath Pandey
      2. HDFS-586.2.patch
        5 kB
        Jitendra Nath Pandey

        Activity

        Hairong Kuang created issue -
        Jitendra Nath Pandey made changes -
        Field Original Value New Value
        Attachment HDFS-586.1.patch [ 12418428 ]
        Hide
        Hairong Kuang added a comment -

        1. add a log message before the test goes to sleep.
        2. instead of using while(true), I would prefer to put break condition there.
        3, better use logging instead of System.out.print.

        Show
        Hairong Kuang added a comment - 1. add a log message before the test goes to sleep. 2. instead of using while(true), I would prefer to put break condition there. 3, better use logging instead of System.out.print.
        Hide
        Jitendra Nath Pandey added a comment -

        Patch updated with Hairong's suggestions.

        Show
        Jitendra Nath Pandey added a comment - Patch updated with Hairong's suggestions.
        Jitendra Nath Pandey made changes -
        Attachment HDFS-586.2.patch [ 12418451 ]
        Hide
        Hairong Kuang added a comment -

        +1 The patch looks good. One minor comment: could you please make the sleep period shorter, like 200?

        Show
        Hairong Kuang added a comment - +1 The patch looks good. One minor comment: could you please make the sleep period shorter, like 200?
        Hide
        Jitendra Nath Pandey added a comment -

        The granularity of dfs.replication.interval is 1 sec. Therefore, reducing the sleep period to a small value doesn't improve the run time of the test.

        Show
        Jitendra Nath Pandey added a comment - The granularity of dfs.replication.interval is 1 sec. Therefore, reducing the sleep period to a small value doesn't improve the run time of the test.
        Jitendra Nath Pandey made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12418451/HDFS-586.2.patch
        against trunk revision 810631.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/8/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/8/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/8/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/8/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12418451/HDFS-586.2.patch against trunk revision 810631. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/8/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/8/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/8/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/8/console This message is automatically generated.
        Hide
        Hairong Kuang added a comment -

        I've committed this with a minor change. I changed the sleeping period from 2000ms to 600ms. This should reduce the uneccessary waiting time.

        Thanks Jitendra!

        Show
        Hairong Kuang added a comment - I've committed this with a minor change. I changed the sleeping period from 2000ms to 600ms. This should reduce the uneccessary waiting time. Thanks Jitendra!
        Hairong Kuang made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags [Reviewed]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #14 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/14/)
        . TestBlocksWithNotEnoughRacks fails. Contributed by Jitendra Nath Pandey.

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #14 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/14/ ) . TestBlocksWithNotEnoughRacks fails. Contributed by Jitendra Nath Pandey.
        Hide
        Hudson added a comment -

        Integrated in Hdfs-Patch-h2.grid.sp2.yahoo.net #4 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/4/)
        . TestBlocksWithNotEnoughRacks fails. Contributed by Jitendra Nath Pandey.

        Show
        Hudson added a comment - Integrated in Hdfs-Patch-h2.grid.sp2.yahoo.net #4 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/4/ ) . TestBlocksWithNotEnoughRacks fails. Contributed by Jitendra Nath Pandey.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #74 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/74/)

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #74 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/74/ )
        Hide
        Hudson added a comment -

        Integrated in Hdfs-Patch-h5.grid.sp2.yahoo.net #21 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/21/)

        Show
        Hudson added a comment - Integrated in Hdfs-Patch-h5.grid.sp2.yahoo.net #21 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/21/ )
        Tom White made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Jitendra Nath Pandey
            Reporter:
            Hairong Kuang
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development