[HDFS-5837] dfs.namenode.replication.considerLoad does not consider decommissioned nodes

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.0-alpha, 2.0.6-alpha, 2.2.0, 3.0.0-alpha1
• Fix Version/s: 2.3.0
• Component/s: namenode
• Hadoop Flags: Reviewed
• Assignee: Tao Luo
• Reporter: Bryan Beaudreault
• Created: 27/Jan/14 22:45
• Updated: 12/May/16 21:18
• Resolved: 10/Feb/14 00:55

Description

In DefaultBlockPlacementPolicy, there is a setting dfs.namenode.replication.considerLoad which tries to balance the load of the cluster when choosing replica locations. This code does not take into account decommissioned nodes.

The code for considerLoad calculates the load by doing: TotalClusterLoad / numNodes. However, numNodes includes decommissioned nodes (which have 0 load). Therefore, the average load is artificially low. Example:

TotalLoad = 250
numNodes = 100
decommissionedNodes = 70
remainingNodes = numNodes - decommissionedNodes = 30

avgLoad = 250/100 = 2.50
trueAvgLoad = 250 / 30 = 8.33

If the real load of the remaining 30 nodes is (on average) 8.33, this is more than 2x the calculated average load of 2.50. This causes these nodes to be rejected as replica locations. The final result is that all nodes are rejected, and no replicas can be placed.

See exceptions printed from client during this scenario: https://gist.github.com/bbeaudreault/49c8aa4bb231de54e9c1

Issue Links

• breaks: HDFS-6599 2.4 addBlock is 10 to 20 times slower compared to 0.23