Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-5800

Typo: soft-limit for hard-limit in DFSClient

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.3.0
    • Component/s: hdfs-client
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      In DFSClient#renewLease, there is a log message as follows.

       LOG.warn("Failed to renew lease for " + clientName + " for "
                    + (elapsed/1000) + " seconds (>= soft-limit ="
                    + (HdfsConstants.LEASE_HARDLIMIT_PERIOD/1000) + " seconds.) "
      

      This log message includes "soft-limit" but, considering the context, I think it's typo for "hard-limit".

      1. HDFS-5800.patch
        0.9 kB
        Kousuke Saruta

        Activity

        Hide
        Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Hdfs-trunk #1651 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1651/)
        HDFS-5800. Fix a typo in DFSClient.renewLease(). Contributed by Kousuke Saruta (szetszwo: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1559701)

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
        Show
        Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #1651 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1651/ ) HDFS-5800 . Fix a typo in DFSClient.renewLease(). Contributed by Kousuke Saruta (szetszwo: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1559701 ) /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #1676 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1676/)
        HDFS-5800. Fix a typo in DFSClient.renewLease(). Contributed by Kousuke Saruta (szetszwo: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1559701)

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
        Show
        Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #1676 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1676/ ) HDFS-5800 . Fix a typo in DFSClient.renewLease(). Contributed by Kousuke Saruta (szetszwo: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1559701 ) /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk #459 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/459/)
        HDFS-5800. Fix a typo in DFSClient.renewLease(). Contributed by Kousuke Saruta (szetszwo: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1559701)

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
        Show
        Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #459 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/459/ ) HDFS-5800 . Fix a typo in DFSClient.renewLease(). Contributed by Kousuke Saruta (szetszwo: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1559701 ) /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in Hadoop-trunk-Commit #5024 (See https://builds.apache.org/job/Hadoop-trunk-Commit/5024/)
        HDFS-5800. Fix a typo in DFSClient.renewLease(). Contributed by Kousuke Saruta (szetszwo: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1559701)

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
        Show
        Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #5024 (See https://builds.apache.org/job/Hadoop-trunk-Commit/5024/ ) HDFS-5800 . Fix a typo in DFSClient.renewLease(). Contributed by Kousuke Saruta (szetszwo: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1559701 ) /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
        Hide
        Tsz Wo Nicholas Sze added a comment -

        I have committed this. Thanks Kousuke!

        Thanks also Akira for reviewing the patch.

        Show
        Tsz Wo Nicholas Sze added a comment - I have committed this. Thanks Kousuke! Thanks also Akira for reviewing the patch.
        Hide
        Akira AJISAKA added a comment -

        The test failure should be unrelated to the simple patch.

        Show
        Akira AJISAKA added a comment - The test failure should be unrelated to the simple patch.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12623906/HDFS-5800.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

        org.apache.hadoop.hdfs.server.balancer.TestBalancerWithNodeGroup

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/5917//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5917//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12623906/HDFS-5800.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.balancer.TestBalancerWithNodeGroup +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/5917//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5917//console This message is automatically generated.
        Hide
        Akira AJISAKA added a comment -

        +1, LGTM. Pending Jenkins.

        Show
        Akira AJISAKA added a comment - +1, LGTM. Pending Jenkins.
        Hide
        Kousuke Saruta added a comment -

        I've attached a patch for this issue.

        Show
        Kousuke Saruta added a comment - I've attached a patch for this issue.

          People

          • Assignee:
            Kousuke Saruta
            Reporter:
            Kousuke Saruta
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development