[HDFS-5747] BlocksMap.getStoredBlock(..) and BlockInfoUnderConstruction.addReplicaIfNotPresent(..) may throw NullPointerException

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.3.0, 3.0.0-alpha1
• Fix Version/s: 2.3.0
• Component/s: namenode
• Hadoop Flags: Reviewed
• Assignee: Arpit Agarwal
• Reporter: Tsz-wo Sze
• Created: 09/Jan/14 16:00
• Updated: 12/May/16 18:13
• Resolved: 11/Jan/14 00:17

Description

Found these NPEs in build #5849.

• BlocksMap is accessed after close:

  2014-01-09 04:28:32,350 WARN  ipc.Server (Server.java:run(2060)) - IPC Server handler 2 on 58333, call org.apache.hadoop.hdfs.server.protocol.DatanodeProtocol.blockReceivedAndDeleted from 127.0.0.1:55572 Call#32 Retry#0: error: java.lang.NullPointerException
  java.lang.NullPointerException
  	at org.apache.hadoop.hdfs.server.blockmanagement.BlocksMap.getStoredBlock(BlocksMap.java:113)
  	at org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.processReportedBlock(BlockManager.java:1915)
  	at org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.processAndHandleReportedBlock(BlockManager.java:2698)
  	at org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.addBlock(BlockManager.java:2685)
  	at org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.processIncrementalBlockReport(BlockManager.java:2759)
  	at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.processIncrementalBlockReport(FSNamesystem.java:5321)
  	at org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.blockReceivedAndDeleted(NameNodeRpcServer.java:1018)
  	...
  

• expectedLocation can be null.

  2014-01-09 04:28:35,384 WARN  ipc.Server (Server.java:run(2060)) - IPC Server handler 5 on 58333, call org.apache.hadoop.hdfs.server.protocol.DatanodeProtocol.blockReport from 127.0.0.1:55583 Call#47 Retry#0: error: java.lang.NullPointerException
  java.lang.NullPointerException
  	at org.apache.hadoop.hdfs.server.blockmanagement.BlockInfoUnderConstruction.addReplicaIfNotPresent(BlockInfoUnderConstruction.java:331)
  	at org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.processFirstBlockReport(BlockManager.java:1801)
  	at org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.processReport(BlockManager.java:1645)
  	at org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.blockReport(NameNodeRpcServer.java:987)
  	...
  

Issue Links

• is related to: HDFS-5770 Exception hit in TestPersistBlocks