[HDFS-5706] Should reset Balancer.Parameters.DEFALUT.policy in TestBalancer

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Duplicate
• Affects Version/s: 2.2.0
• Component/s: balancer & mover
• Assignee: Yu Li
• Reporter: Yu Li
• Created: 30/Dec/13 03:07
• Updated: 30/Dec/13 06:02
• Resolved: 30/Dec/13 06:02

Description

Now in TestBalancer.java, more than one test case will invoke the private method runBalancer, in which it will use Balancer.Parameters.Default, while the policy is never reset thus its totalUsedSpace and totalCapacity will increase continuously.

We can reveal this issue by simply change

TestBalancer#testBalancer1Internal

testUnevenDistribution(conf,
        new long[] {50*CAPACITY/100, 10*CAPACITY/100},
        new long[]{CAPACITY, CAPACITY},
        new String[] {RACK0, RACK1});

to

TestBalancer#testBalancer1Internal

testUnevenDistribution(conf,
        new long[] {70*CAPACITY/100, 40*CAPACITY/100},
        new long[]{CAPACITY, CAPACITY},
        new String[] {RACK0, RACK1});

which in current implement, will cause none node under-replication thus cause the test case fail

Issue Links

• duplicates: HDFS-4261 TestBalancerWithNodeGroup times out