Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-5679

TestCacheDirectives should handle the case where native code is not available

    Details

    • Type: Test Test
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0
    • Fix Version/s: 2.3.0
    • Component/s: None
    • Labels:

      Description

      TestCacheDirectives fails on trunk due to:

      testBasicPoolOperations(org.apache.hadoop.hdfs.server.namenode.TestCacheDirectives)  Time elapsed: 1.618 sec  <<< ERROR!
      java.lang.RuntimeException: Cannot start datanode because the configured max locked memory size (dfs.datanode.max.locked.memory) is greater than zero and native code is not available.
      

      Configuration of max locked memory size should be dependent on whether native code is available.

      1. hdfs-5679-1.patch
        0.7 kB
        Andrew Wang

        Activity

        Ted Yu created issue -
        Andrew Wang made changes -
        Field Original Value New Value
        Assignee Andrew Wang [ andrew.wang ]
        Hide
        Andrew Wang added a comment -

        Thanks for the report Ted, looks like we forgot to redo the mlock stub when this file was refactored. Trivial patch attached, I tested before and after behavior.

        Show
        Andrew Wang added a comment - Thanks for the report Ted, looks like we forgot to redo the mlock stub when this file was refactored. Trivial patch attached, I tested before and after behavior.
        Andrew Wang made changes -
        Attachment hdfs-5679-1.patch [ 12619656 ]
        Andrew Wang made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Affects Version/s 3.0.0 [ 12320356 ]
        Andrew Wang made changes -
        Labels caching
        Hide
        Colin Patrick McCabe added a comment -

        +1. Thanks, Andrew.

        Show
        Colin Patrick McCabe added a comment - +1. Thanks, Andrew.
        Hide
        Colin Patrick McCabe added a comment -

        pending jenkins, obviously, although jenkins tests the case with native libs

        Show
        Colin Patrick McCabe added a comment - pending jenkins, obviously, although jenkins tests the case with native libs
        Hide
        Ted Yu added a comment -

        The test passed on Mac with the patch.

        Thanks for the fix.

        Show
        Ted Yu added a comment - The test passed on Mac with the patch. Thanks for the fix.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12619656/hdfs-5679-1.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/5772//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5772//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12619656/hdfs-5679-1.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/5772//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5772//console This message is automatically generated.
        Hide
        Andrew Wang added a comment -

        Committed to trunk, thanks all.

        Show
        Andrew Wang added a comment - Committed to trunk, thanks all.
        Andrew Wang made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Fix Version/s 3.0.0 [ 12320356 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in Hadoop-trunk-Commit #4921 (See https://builds.apache.org/job/Hadoop-trunk-Commit/4921/)
        HDFS-5679. TestCacheDirectives should handle the case where native code is not available. (wang) (wang: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1552461)

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCacheDirectives.java
        Show
        Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #4921 (See https://builds.apache.org/job/Hadoop-trunk-Commit/4921/ ) HDFS-5679 . TestCacheDirectives should handle the case where native code is not available. (wang) (wang: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1552461 ) /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCacheDirectives.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Hdfs-trunk #1618 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1618/)
        HDFS-5679. TestCacheDirectives should handle the case where native code is not available. (wang) (wang: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1552461)

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCacheDirectives.java
        Show
        Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #1618 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1618/ ) HDFS-5679 . TestCacheDirectives should handle the case where native code is not available. (wang) (wang: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1552461 ) /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCacheDirectives.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #1644 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1644/)
        HDFS-5679. TestCacheDirectives should handle the case where native code is not available. (wang) (wang: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1552461)

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCacheDirectives.java
        Show
        Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #1644 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1644/ ) HDFS-5679 . TestCacheDirectives should handle the case where native code is not available. (wang) (wang: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1552461 ) /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCacheDirectives.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #427 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/427/)
        HDFS-5679. TestCacheDirectives should handle the case where native code is not available. (wang) (wang: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1552461)

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCacheDirectives.java
        Show
        Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #427 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/427/ ) HDFS-5679 . TestCacheDirectives should handle the case where native code is not available. (wang) (wang: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1552461 ) /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCacheDirectives.java
        Allen Wittenauer made changes -
        Fix Version/s 2.3.0 [ 12325255 ]
        Fix Version/s 3.0.0 [ 12320356 ]
        Hide
        Vinod Kumar Vavilapalli added a comment -

        Closing tickets that are already part of a release.

        Show
        Vinod Kumar Vavilapalli added a comment - Closing tickets that are already part of a release.
        Vinod Kumar Vavilapalli made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        1d 5h 50m 1 Andrew Wang 19/Dec/13 20:49
        Patch Available Patch Available Resolved Resolved
        3h 12m 1 Andrew Wang 20/Dec/13 00:01
        Resolved Resolved Closed Closed
        557d 7h 24m 1 Vinod Kumar Vavilapalli 30/Jun/15 07:25

          People

          • Assignee:
            Andrew Wang
            Reporter:
            Ted Yu
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development