[HDFS-5676] fix inconsistent synchronization of CachingStrategy

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.3.0
• Fix Version/s: 2.3.0
• Component/s: hdfs-client
• Assignee: Colin McCabe
• Reporter: Colin McCabe
• Created: 18/Dec/13 00:31
• Updated: 24/Feb/14 20:57
• Resolved: 18/Dec/13 23:29

Description

Currently, the synchronization for CachingStrategy is a little inconsistent. DFSOutputStream#setDropBehind modifies the strategy object, but there's nothing protecting that object against concurrent use in createBlockOutputStream. Similarly, DFSInputStream#setDropBehind is synchronized, but not all the uses of cachingStrategy are.