[HDFS-5669] Storage#tryLock() should check for null before logging successfull message

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.2.0
• Fix Version/s: 2.5.0
• Component/s: datanode
• Hadoop Flags: Reviewed
• Assignee: Vinayakumar B
• Reporter: Vinayakumar B
• Created: 14/Dec/13 17:29
• Updated: 03/Sep/14 20:34
• Resolved: 10/Apr/14 18:14

Description

In the following code in Storage#tryLock(), there is a possibility that file.getChannel().tryLock() returns null if the lock is acquired by some other process. In that case even though return value is null, a successfull message confuses.

try {
        res = file.getChannel().tryLock();
        file.write(jvmName.getBytes(Charsets.UTF_8));
        LOG.info("Lock on " + lockF + " acquired by nodename " + jvmName);
      } catch(OverlappingFileLockException oe) {