[HDFS-5666] Fix inconsistent synchronization in BPOfferService

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.3.0
• Fix Version/s: 2.3.0
• Component/s: namenode
• Target Version/s: 2.3.0
• Assignee: Jimmy Xiang
• Reporter: Colin McCabe
• Created: 13/Dec/13 19:55
• Updated: 24/Feb/14 20:57
• Resolved: 16/Dec/13 18:46

Description

TestBPOfferService#testBPInitErrorHandling fails intermittently. We believe it's because of inconsistent synchronization in BPOfferService.

stack trace:

Regression

org.apache.hadoop.hdfs.server.datanode.TestBPOfferService.testBPInitErrorHandling

Failing for the past 1 build (Since #5698 )
Took 0.16 sec.

Error Message

expected:<1> but was:<2>

Stacktrace

java.lang.AssertionError: expected:<1> but was:<2>
at org.junit.Assert.fail(Assert.java:93)
at org.junit.Assert.failNotEquals(Assert.java:647)
at org.junit.Assert.assertEquals(Assert.java:128)

see https://builds.apache.org/job/PreCommit-HDFS-Build/5698//testReport/org.apache.hadoop.hdfs.server.datanode/TestBPOfferService/testBPInitErrorHandling/

Issue Links

• is duplicated by: HDFS-5668 TestBPOfferService.testBPInitErrorHandling fails intermittently