Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-5592

"DIR* completeFile: /file is closed by DFSClient_" should be logged only for successful closure of the file.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0, 2.3.0
    • Fix Version/s: 2.3.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Following log message in FSNameSystem#completeFile(..) should be logged only if the file is closed.

          getEditLog().logSync();
          NameNode.stateChangeLog.info("DIR* completeFile: " + src + " is closed by "
              + holder);
          return success;
      1. HDFS-5592.patch
        0.8 kB
        Vinayakumar B

        Activity

        Allen Wittenauer made changes -
        Fix Version/s 3.0.0 [ 12320356 ]
        Arun C Murthy made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #1640 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1640/)
        HDFS-5592. statechangeLog of completeFile should be logged only in case of success. Contributed by Vinay. (umamahesh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1551145)

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        Show
        Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #1640 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1640/ ) HDFS-5592 . statechangeLog of completeFile should be logged only in case of success. Contributed by Vinay. (umamahesh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1551145 ) /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #1614 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1614/)
        HDFS-5592. statechangeLog of completeFile should be logged only in case of success. Contributed by Vinay. (umamahesh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1551145)

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        Show
        Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #1614 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1614/ ) HDFS-5592 . statechangeLog of completeFile should be logged only in case of success. Contributed by Vinay. (umamahesh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1551145 ) /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #423 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/423/)
        HDFS-5592. statechangeLog of completeFile should be logged only in case of success. Contributed by Vinay. (umamahesh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1551145)

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        Show
        Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #423 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/423/ ) HDFS-5592 . statechangeLog of completeFile should be logged only in case of success. Contributed by Vinay. (umamahesh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1551145 ) /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in Hadoop-trunk-Commit #4886 (See https://builds.apache.org/job/Hadoop-trunk-Commit/4886/)
        HDFS-5592. statechangeLog of completeFile should be logged only in case of success. Contributed by Vinay. (umamahesh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1551145)

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        Show
        Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #4886 (See https://builds.apache.org/job/Hadoop-trunk-Commit/4886/ ) HDFS-5592 . statechangeLog of completeFile should be logged only in case of success. Contributed by Vinay. (umamahesh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1551145 ) /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        Hide
        Vinayakumar B added a comment -

        Thanks Uma

        Show
        Vinayakumar B added a comment - Thanks Uma
        Uma Maheswara Rao G made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Fix Version/s 3.0.0 [ 12320356 ]
        Fix Version/s 2.3.0 [ 12325255 ]
        Resolution Fixed [ 1 ]
        Hide
        Uma Maheswara Rao G added a comment -

        I have committed this to trunk and branch 2.

        Show
        Uma Maheswara Rao G added a comment - I have committed this to trunk and branch 2.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12616735/HDFS-5592.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/5622//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5622//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12616735/HDFS-5592.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/5622//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5622//console This message is automatically generated.
        Hide
        Uma Maheswara Rao G added a comment -

        +1

        Show
        Uma Maheswara Rao G added a comment - +1
        Vinayakumar B made changes -
        Affects Version/s 2.3.0 [ 12325255 ]
        Affects Version/s 2.2.0 [ 12325049 ]
        Vinayakumar B made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Affects Version/s 2.2.0 [ 12325049 ]
        Affects Version/s 3.0.0 [ 12320356 ]
        Vinayakumar B made changes -
        Field Original Value New Value
        Attachment HDFS-5592.patch [ 12616735 ]
        Hide
        Vinayakumar B added a comment -

        Attached the patch

        Show
        Vinayakumar B added a comment - Attached the patch
        Vinayakumar B created issue -

          People

          • Assignee:
            Vinayakumar B
            Reporter:
            Vinayakumar B
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development