Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      BlockReaderLocal.skip and RemoteBlockReader.skip uses a temp buffer to read data to this buffer, it is not necessary.

      1. HDFS-5574.006.patch
        16 kB
        Binglin Chang
      2. HDFS-5574.007.patch
        16 kB
        Binglin Chang
      3. HDFS-5574.008.patch
        16 kB
        Binglin Chang
      4. HDFS-5574.v1.patch
        10 kB
        Binglin Chang
      5. HDFS-5574.v2.patch
        10 kB
        Binglin Chang
      6. HDFS-5574.v3.patch
        6 kB
        Binglin Chang
      7. HDFS-5574.v4.patch
        16 kB
        Binglin Chang
      8. HDFS-5574.v5.patch
        16 kB
        Binglin Chang

        Issue Links

          Activity

          Hide
          decster Binglin Chang added a comment -

          Changes:
          Refactor some code in BlockReaderLocal.skip and RemoteBlockReader2.skip
          Add test for DFSInpustream.skip

          Show
          decster Binglin Chang added a comment - Changes: Refactor some code in BlockReaderLocal.skip and RemoteBlockReader2.skip Add test for DFSInpustream.skip
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12616017/HDFS-5574.v1.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/5590//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/5590//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5590//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12616017/HDFS-5574.v1.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. -1 findbugs . The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/5590//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/5590//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5590//console This message is automatically generated.
          Hide
          decster Binglin Chang added a comment -

          Changes:
          Add synchronized to RemoteBlockReader2.read(ByteBuffer buf) to fix findbug warning.

          Show
          decster Binglin Chang added a comment - Changes: Add synchronized to RemoteBlockReader2.read(ByteBuffer buf) to fix findbug warning.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12616049/HDFS-5574.v2.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

          org.apache.hadoop.hdfs.server.balancer.TestBalancerWithNodeGroup
          org.apache.hadoop.hdfs.server.datanode.TestFsDatasetCache

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/5592//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5592//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12616049/HDFS-5574.v2.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.balancer.TestBalancerWithNodeGroup org.apache.hadoop.hdfs.server.datanode.TestFsDatasetCache +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/5592//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5592//console This message is automatically generated.
          Hide
          decster Binglin Chang added a comment -

          The failed test is unrelated.
          TestBalancerWithNodeGroup is traced in HDFS-5580
          TestFsDatasetCache: I looked into the failed log, the timeout is caused by a race condition, luckily after HDFS-5556 committed, the race condition no longer apply, so there should be no problem now.

          Show
          decster Binglin Chang added a comment - The failed test is unrelated. TestBalancerWithNodeGroup is traced in HDFS-5580 TestFsDatasetCache: I looked into the failed log, the timeout is caused by a race condition, luckily after HDFS-5556 committed, the race condition no longer apply, so there should be no problem now.
          Hide
          cmccabe Colin P. McCabe added a comment -

          Let's close this as duplicate since after HDFS-5634, we no longer do a buffer copy in BlockReader#skip.

          Show
          cmccabe Colin P. McCabe added a comment - Let's close this as duplicate since after HDFS-5634 , we no longer do a buffer copy in BlockReader#skip .
          Hide
          cmccabe Colin P. McCabe added a comment -

          actually, maybe I spoke too soon. This patch removes a buffer copy from RemoteBlockReader2#skip, which HDFS-5634 doesn't change. HDFS-5634 only affects BlockReaderLocal, not either of the remote block readers. So Binglin, if you want to prepare a new version, it would be worth looking at.

          Show
          cmccabe Colin P. McCabe added a comment - actually, maybe I spoke too soon. This patch removes a buffer copy from RemoteBlockReader2#skip , which HDFS-5634 doesn't change. HDFS-5634 only affects BlockReaderLocal , not either of the remote block readers. So Binglin, if you want to prepare a new version, it would be worth looking at.
          Hide
          decster Binglin Chang added a comment -

          Thanks for the comments, Colin. The new v3 patch just remove changes of BlockReaderLocal in v2 patch. Since RemoteBlockReader is deprecated, I keep it unchanged.
          Another change is add synchronized to RemoteBlockReader2.read(ByteBuffer buf), there is a findbug warning.
          Add a test to test DFSInpustream.skip which will call BlockReader.skip.

          Show
          decster Binglin Chang added a comment - Thanks for the comments, Colin. The new v3 patch just remove changes of BlockReaderLocal in v2 patch. Since RemoteBlockReader is deprecated, I keep it unchanged. Another change is add synchronized to RemoteBlockReader2.read(ByteBuffer buf), there is a findbug warning. Add a test to test DFSInpustream.skip which will call BlockReader.skip.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12619250/HDFS-5574.v3.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

          org.apache.hadoop.hdfs.server.balancer.TestBalancerWithNodeGroup
          org.apache.hadoop.hdfs.server.namenode.ha.TestHASafeMode

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/5755//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5755//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12619250/HDFS-5574.v3.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.balancer.TestBalancerWithNodeGroup org.apache.hadoop.hdfs.server.namenode.ha.TestHASafeMode +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/5755//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5755//console This message is automatically generated.
          Hide
          cmccabe Colin P. McCabe added a comment -

          If it's easy, then I would say do RemoteBlockReader as well, just to avoid divergence. There are still some people who have to use the old block reader-- for example, if they are using SOCKS sockets.

          The main point of the old block reader is that it can operate on sockets that don't have channels. In the long term, I feel like we could probably wrap those sockets in something that would provide a channel, or just integrate that functionality into RemoteBlockReader2.

          Your test doesn't really test what you think. DFSInputStream#skip is not necessarily going to call BlockReader#skip. If you want to play with a remote block reader directly, you should call the test TestRemoteBlockReader or something like that. There is an example in TestBlockTokenWithDFS. Also, you should set DFSInputStream#tcpReadsDisabledForTesting if you want to make sure you're really getting a local block reader.

          Finally, BlockReaderLocal lets you skip past the end of the file without complaining. This behavior is consistent with how FileInputChannel#position works. Since the DFSInputStream knows the length of the block (reader), it never tries to skip past the end.

          Show
          cmccabe Colin P. McCabe added a comment - If it's easy, then I would say do RemoteBlockReader as well, just to avoid divergence. There are still some people who have to use the old block reader-- for example, if they are using SOCKS sockets. The main point of the old block reader is that it can operate on sockets that don't have channels. In the long term, I feel like we could probably wrap those sockets in something that would provide a channel, or just integrate that functionality into RemoteBlockReader2 . Your test doesn't really test what you think. DFSInputStream#skip is not necessarily going to call BlockReader#skip . If you want to play with a remote block reader directly, you should call the test TestRemoteBlockReader or something like that. There is an example in TestBlockTokenWithDFS . Also, you should set DFSInputStream#tcpReadsDisabledForTesting if you want to make sure you're really getting a local block reader. Finally, BlockReaderLocal lets you skip past the end of the file without complaining. This behavior is consistent with how FileInputChannel#position works. Since the DFSInputStream knows the length of the block (reader), it never tries to skip past the end.
          Hide
          decster Binglin Chang added a comment -

          Thanks for the review and comments, Colin. I updated the patch, changes:
          1. Implement RemoteBlockReader.skip
          2. Add test for RemoteBlockReader.skip in TestRemoteBlockReader, and RemoteBlockReader2.skip in TestRemoteBlockReader2, they both inherent base test class TestRemoteBlockReaderBase
          3. Use BlockReaderTestUtil to create BlockReader in those tests
          4. Keep TestDFSInputStream, I think it is still useful

          Finally, BlockReaderLocal lets you skip past the end of the file without complaining. This behavior is consistent with how FileInputChannel#position works. Since the DFSInputStream knows the length of the block (reader), it never tries to skip past the end.

          My current patch keep the old behavior(return bytes actually skipped without complaining), what should I change?

          Show
          decster Binglin Chang added a comment - Thanks for the review and comments, Colin. I updated the patch, changes: 1. Implement RemoteBlockReader.skip 2. Add test for RemoteBlockReader.skip in TestRemoteBlockReader, and RemoteBlockReader2.skip in TestRemoteBlockReader2, they both inherent base test class TestRemoteBlockReaderBase 3. Use BlockReaderTestUtil to create BlockReader in those tests 4. Keep TestDFSInputStream, I think it is still useful Finally, BlockReaderLocal lets you skip past the end of the file without complaining. This behavior is consistent with how FileInputChannel#position works. Since the DFSInputStream knows the length of the block (reader), it never tries to skip past the end. My current patch keep the old behavior(return bytes actually skipped without complaining), what should I change?
          Hide
          cmccabe Colin P. McCabe added a comment -

          Thanks for working on this, Binglin.

            BlockReaderTestUtil util;
            byte[] blockData;
            BlockReader reader;
          

          If these aren't needed by the test subclasses, they should be private. Similarly with getBlockReader.

              conf.setBoolean(DFSConfigKeys.DFS_CLIENT_USE_LEGACY_BLOCKREADER, true);
          

          I don't think you want this in TestRemoteBlockReader.

          Show
          cmccabe Colin P. McCabe added a comment - Thanks for working on this, Binglin. BlockReaderTestUtil util; byte [] blockData; BlockReader reader; If these aren't needed by the test subclasses, they should be private. Similarly with getBlockReader . conf.setBoolean(DFSConfigKeys.DFS_CLIENT_USE_LEGACY_BLOCKREADER, true ); I don't think you want this in TestRemoteBlockReader .
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12619595/HDFS-5574.v4.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 4 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs:

          org.apache.hadoop.hdfs.TestDFSInputStream
          org.apache.hadoop.hdfs.TestRemoteBlockReader

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/5769//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5769//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12619595/HDFS-5574.v4.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 4 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.TestDFSInputStream org.apache.hadoop.hdfs.TestRemoteBlockReader +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/5769//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5769//console This message is automatically generated.
          Hide
          decster Binglin Chang added a comment -

          Thanks for the review Colin. I updated the patch.

          I don't think you want this in TestRemoteBlockReader.

          I set DFSConfigKeys.DFS_CLIENT_USE_LEGACY_BLOCKREADER to true, so getBlockReader can get RemoteBlockReader rather than RemoteBlockReader2.

          Show
          decster Binglin Chang added a comment - Thanks for the review Colin. I updated the patch. I don't think you want this in TestRemoteBlockReader. I set DFSConfigKeys.DFS_CLIENT_USE_LEGACY_BLOCKREADER to true, so getBlockReader can get RemoteBlockReader rather than RemoteBlockReader2.
          Hide
          hadoopqa Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12619705/HDFS-5574.v5.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 4 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/5777//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5777//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12619705/HDFS-5574.v5.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 4 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/5777//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5777//console This message is automatically generated.
          Hide
          cmccabe Colin P. McCabe added a comment -

          I set DFSConfigKeys.DFS_CLIENT_USE_LEGACY_BLOCKREADER to true, so getBlockReader can get RemoteBlockReader rather than RemoteBlockReader2.

          oh, sorry, I was confusing this with DFS_CLIENT_USE_LEGACY_BLOCKREADERLOCAL.

          +1.

          Show
          cmccabe Colin P. McCabe added a comment - I set DFSConfigKeys.DFS_CLIENT_USE_LEGACY_BLOCKREADER to true, so getBlockReader can get RemoteBlockReader rather than RemoteBlockReader2. oh, sorry, I was confusing this with DFS_CLIENT_USE_LEGACY_BLOCKREADERLOCAL . +1.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12619705/HDFS-5574.v5.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 4 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs:

          org.apache.hadoop.metrics2.impl.TestMetricsSystemImpl
          org.apache.hadoop.ha.TestZKFailoverControllerStress

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/7127//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7127//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12619705/HDFS-5574.v5.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 4 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.metrics2.impl.TestMetricsSystemImpl org.apache.hadoop.ha.TestZKFailoverControllerStress +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/7127//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7127//console This message is automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12619705/HDFS-5574.v5.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 4 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/7131//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7131//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12619705/HDFS-5574.v5.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 4 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/7131//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7131//console This message is automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12619705/HDFS-5574.v5.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 4 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs:

          org.apache.hadoop.hdfs.server.datanode.TestBPOfferService

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/7132//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7132//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12619705/HDFS-5574.v5.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 4 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.datanode.TestBPOfferService +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/7132//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7132//console This message is automatically generated.
          Hide
          decster Binglin Chang added a comment -

          Hi Colin P. McCabe, looks like there are no more comments for a long time, could you help get this committed? Thanks

          Show
          decster Binglin Chang added a comment - Hi Colin P. McCabe , looks like there are no more comments for a long time, could you help get this committed? Thanks
          Hide
          decster Binglin Chang added a comment -

          rebase patch to trunk

          Show
          decster Binglin Chang added a comment - rebase patch to trunk
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12685973/HDFS-5574.006.patch
          against trunk revision db73cc9.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 4 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          -1 findbugs. The patch appears to introduce 352 new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs:

          org.apache.hadoop.hdfs.TestDFSInputStream
          org.apache.hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/8970//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/8970//artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/8970//artifact/patchprocess/newPatchFindbugsWarningshadoop-common.html
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8970//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12685973/HDFS-5574.006.patch against trunk revision db73cc9. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 4 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. -1 findbugs . The patch appears to introduce 352 new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.TestDFSInputStream org.apache.hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/8970//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/8970//artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/8970//artifact/patchprocess/newPatchFindbugsWarningshadoop-common.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8970//console This message is automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12685973/HDFS-5574.006.patch
          against trunk revision 82707b4.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 4 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          -1 findbugs. The patch appears to introduce 352 new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs:

          org.apache.hadoop.hdfs.TestLeaseRecovery2

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/8974//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/8974//artifact/patchprocess/newPatchFindbugsWarningshadoop-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/8974//artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8974//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12685973/HDFS-5574.006.patch against trunk revision 82707b4. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 4 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. -1 findbugs . The patch appears to introduce 352 new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.TestLeaseRecovery2 Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/8974//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/8974//artifact/patchprocess/newPatchFindbugsWarningshadoop-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/8974//artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8974//console This message is automatically generated.
          Hide
          cmccabe Colin P. McCabe added a comment -

          Thanks for your patience. I'll try to look at this later this week. If anyone else wants to check it out before that, that works too

          Show
          cmccabe Colin P. McCabe added a comment - Thanks for your patience. I'll try to look at this later this week. If anyone else wants to check it out before that, that works too
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12685973/HDFS-5574.006.patch
          against trunk revision af9d4fe.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 4 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 javadoc. The javadoc tool appears to have generated 9 warning messages.
          See https://builds.apache.org/job/PreCommit-HDFS-Build/10241//artifact/patchprocess/diffJavadocWarnings.txt for details.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs:

          org.apache.hadoop.hdfs.TestDFSInputStream
          org.apache.hadoop.hdfs.tools.TestDFSAdmin
          org.apache.hadoop.hdfs.TestRemoteBlockReader

          The following test timeouts occurred in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs:

          org.apache.hadoop.hdfs.TestDFSRollback

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/10241//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/10241//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12685973/HDFS-5574.006.patch against trunk revision af9d4fe. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 4 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 javadoc . The javadoc tool appears to have generated 9 warning messages. See https://builds.apache.org/job/PreCommit-HDFS-Build/10241//artifact/patchprocess/diffJavadocWarnings.txt for details. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.TestDFSInputStream org.apache.hadoop.hdfs.tools.TestDFSAdmin org.apache.hadoop.hdfs.TestRemoteBlockReader The following test timeouts occurred in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.TestDFSRollback Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/10241//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/10241//console This message is automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Looks good to me. +1 pending Jenkins. Kicked https://builds.apache.org/job/PreCommit-HDFS-Build/10369/

          Show
          ajisakaa Akira Ajisaka added a comment - Looks good to me. +1 pending Jenkins. Kicked https://builds.apache.org/job/PreCommit-HDFS-Build/10369/
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 14m 41s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 4 new or modified test files.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          -1 javac 7m 37s The applied patch generated 125 additional warning messages.
          +1 javadoc 9m 47s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 3m 58s The applied patch generated 1 additional checkstyle issues.
          +1 install 1m 34s mvn install still works.
          +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
          +1 findbugs 4m 44s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
          -1 common tests 22m 51s Tests failed in hadoop-common.
          -1 hdfs tests 0m 31s Tests failed in hadoop-hdfs.
              66m 42s  



          Reason Tests
          Failed unit tests hadoop.security.ssl.TestReloadingX509TrustManager
          Failed build hadoop-hdfs



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12685973/HDFS-5574.006.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / c8d7290
          javac https://builds.apache.org/job/PreCommit-HDFS-Build/10369/artifact/patchprocess/diffJavacWarnings.txt
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/10369/artifact/patchprocess/checkstyle-result-diff.txt
          hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/10369/artifact/patchprocess/testrun_hadoop-common.txt
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/10369/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10369/testReport/
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10369/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 41s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 4 new or modified test files. +1 whitespace 0m 0s The patch has no lines that end in whitespace. -1 javac 7m 37s The applied patch generated 125 additional warning messages. +1 javadoc 9m 47s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 3m 58s The applied patch generated 1 additional checkstyle issues. +1 install 1m 34s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 4m 44s The patch does not introduce any new Findbugs (version 2.0.3) warnings. -1 common tests 22m 51s Tests failed in hadoop-common. -1 hdfs tests 0m 31s Tests failed in hadoop-hdfs.     66m 42s   Reason Tests Failed unit tests hadoop.security.ssl.TestReloadingX509TrustManager Failed build hadoop-hdfs Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12685973/HDFS-5574.006.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / c8d7290 javac https://builds.apache.org/job/PreCommit-HDFS-Build/10369/artifact/patchprocess/diffJavacWarnings.txt checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/10369/artifact/patchprocess/checkstyle-result-diff.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/10369/artifact/patchprocess/testrun_hadoop-common.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/10369/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10369/testReport/ Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10369/console This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Hi Binglin Chang, would you replace DFS_CLIENT_READ_SHORTCIRCUIT_KEY with HdfsClientConfigKeys.Read.ShortCircuit.KEY in TestDFSInputStream? That will fix the javac warning.

          For checkstyle warnings, would you make FSInputChecker#readAndDiscard final and adding @return, @param, and @throws tags in javadoc?

          <error line="222" severity="error" message="Expected an @return tag." source="com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck"/>
          <error line="222" column="3" severity="error" message="Method &apos;readAndDiscard&apos; is not designed for extension - needs to be abstract, final or empty." source="com.puppycrawl.tools.checkstyle.checks.design.DesignForExtensionCheck"/>
          <error line="222" column="45" severity="error" message="Parameter len should be final." source="com.puppycrawl.tools.checkstyle.checks.FinalParametersCheck"/>
          <error line="222" column="49" severity="error" message="Expected @param tag for &apos;len&apos;." source="com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck"/>
          <error line="222" column="61" severity="error" message="Expected @throws tag for &apos;IOException&apos;." source="com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck"/>
          
          Show
          ajisakaa Akira Ajisaka added a comment - Hi Binglin Chang , would you replace DFS_CLIENT_READ_SHORTCIRCUIT_KEY with HdfsClientConfigKeys.Read.ShortCircuit.KEY in TestDFSInputStream? That will fix the javac warning. For checkstyle warnings, would you make FSInputChecker#readAndDiscard final and adding @return , @param , and @throws tags in javadoc? <error line= "222" severity= "error" message= "Expected an @ return tag." source= "com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck" /> <error line= "222" column= "3" severity= "error" message= "Method &apos;readAndDiscard&apos; is not designed for extension - needs to be abstract , final or empty." source= "com.puppycrawl.tools.checkstyle.checks.design.DesignForExtensionCheck" /> <error line= "222" column= "45" severity= "error" message= "Parameter len should be final ." source= "com.puppycrawl.tools.checkstyle.checks.FinalParametersCheck" /> <error line= "222" column= "49" severity= "error" message= "Expected @param tag for &apos;len&apos;." source= "com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck" /> <error line= "222" column= "61" severity= "error" message= "Expected @ throws tag for &apos;IOException&apos;." source= "com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck" />
          Hide
          decster Binglin Chang added a comment -

          Thanks for the review Akira. Update the patch to fix compile and stylecheck warnings

          Show
          decster Binglin Chang added a comment - Thanks for the review Akira. Update the patch to fix compile and stylecheck warnings
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 14m 34s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 4 new or modified test files.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 javac 7m 28s There were no new javac warning messages.
          +1 javadoc 9m 30s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 5m 26s The applied patch generated 1 additional checkstyle issues.
          +1 install 1m 35s mvn install still works.
          +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
          +1 findbugs 4m 43s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
          +1 common tests 24m 21s Tests passed in hadoop-common.
          -1 hdfs tests 184m 14s Tests failed in hadoop-hdfs.
              252m 50s  



          Reason Tests
          Failed unit tests hadoop.hdfs.server.blockmanagement.TestDatanodeManager



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12728364/HDFS-5574.007.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 5e67c4d
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/10409/artifact/patchprocess/checkstyle-result-diff.txt
          hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/10409/artifact/patchprocess/testrun_hadoop-common.txt
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/10409/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10409/testReport/
          Java 1.7.0_55
          uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10409/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 34s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 4 new or modified test files. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 javac 7m 28s There were no new javac warning messages. +1 javadoc 9m 30s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 5m 26s The applied patch generated 1 additional checkstyle issues. +1 install 1m 35s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 4m 43s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 common tests 24m 21s Tests passed in hadoop-common. -1 hdfs tests 184m 14s Tests failed in hadoop-hdfs.     252m 50s   Reason Tests Failed unit tests hadoop.hdfs.server.blockmanagement.TestDatanodeManager Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12728364/HDFS-5574.007.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 5e67c4d checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/10409/artifact/patchprocess/checkstyle-result-diff.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/10409/artifact/patchprocess/testrun_hadoop-common.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/10409/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10409/testReport/ Java 1.7.0_55 uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10409/console This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thanks Binglin Chang for updating the patch.

          <error line="222" column="3" severity="error" message="Method &apos;readAndDiscard&apos; is not designed for extension - needs to be abstract, final or empty." source="com.puppycrawl.tools.checkstyle.checks.design.DesignForExtensionCheck"/>
          

          Would you add final to FSInputChecker#readAndDiscard?
          The test failure looks unrelated to the patch.

          Show
          ajisakaa Akira Ajisaka added a comment - Thanks Binglin Chang for updating the patch. <error line= "222" column= "3" severity= "error" message= "Method &apos;readAndDiscard&apos; is not designed for extension - needs to be abstract , final or empty." source= "com.puppycrawl.tools.checkstyle.checks.design.DesignForExtensionCheck" /> Would you add final to FSInputChecker#readAndDiscard ? The test failure looks unrelated to the patch.
          Hide
          decster Binglin Chang added a comment -

          Oops, sorry I forgot this, attach new patch.

          Show
          decster Binglin Chang added a comment - Oops, sorry I forgot this, attach new patch.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 17m 23s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 4 new or modified test files.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 javac 9m 15s There were no new javac warning messages.
          +1 javadoc 11m 31s There were no new javadoc warning messages.
          +1 release audit 0m 26s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 4m 46s The applied patch generated 1 additional checkstyle issues.
          +1 install 1m 42s mvn install still works.
          +1 eclipse:eclipse 0m 38s The patch built with eclipse:eclipse.
          +1 findbugs 5m 27s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
          -1 common tests 22m 32s Tests failed in hadoop-common.
          -1 hdfs tests 174m 54s Tests failed in hadoop-hdfs.
              248m 40s  



          Reason Tests
          Failed unit tests hadoop.hdfs.server.namenode.ha.TestPipelinesFailover
            hadoop.hdfs.TestRemoteBlockReader
            hadoop.hdfs.TestDFSInputStream
            hadoop.hdfs.server.namenode.TestStartup
          Timed out tests org.apache.hadoop.ha.TestZKFailoverControllerStress



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12728717/HDFS-5574.008.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / feb68cb
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/10429/artifact/patchprocess/checkstyle-result-diff.txt
          hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/10429/artifact/patchprocess/testrun_hadoop-common.txt
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/10429/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10429/testReport/
          Java 1.7.0_55
          uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10429/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 23s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 4 new or modified test files. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 javac 9m 15s There were no new javac warning messages. +1 javadoc 11m 31s There were no new javadoc warning messages. +1 release audit 0m 26s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 4m 46s The applied patch generated 1 additional checkstyle issues. +1 install 1m 42s mvn install still works. +1 eclipse:eclipse 0m 38s The patch built with eclipse:eclipse. +1 findbugs 5m 27s The patch does not introduce any new Findbugs (version 2.0.3) warnings. -1 common tests 22m 32s Tests failed in hadoop-common. -1 hdfs tests 174m 54s Tests failed in hadoop-hdfs.     248m 40s   Reason Tests Failed unit tests hadoop.hdfs.server.namenode.ha.TestPipelinesFailover   hadoop.hdfs.TestRemoteBlockReader   hadoop.hdfs.TestDFSInputStream   hadoop.hdfs.server.namenode.TestStartup Timed out tests org.apache.hadoop.ha.TestZKFailoverControllerStress Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12728717/HDFS-5574.008.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / feb68cb checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/10429/artifact/patchprocess/checkstyle-result-diff.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/10429/artifact/patchprocess/testrun_hadoop-common.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/10429/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10429/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10429/console This message was automatically generated.
          Hide
          decster Binglin Chang added a comment -

          Strange, the test error is caused by NoSuchMethodError, which should not happen if code is compiled successfully, is there any bug in test-patch process?

          java.lang.NoSuchMethodError: org.apache.hadoop.fs.FSInputChecker.readAndDiscard(I)I
          	at org.apache.hadoop.hdfs.RemoteBlockReader.read(RemoteBlockReader.java:128)
          	at org.apache.hadoop.hdfs.DFSInputStream$ByteArrayStrategy.doRead(DFSInputStream.java:740)
          	at org.apache.hadoop.hdfs.DFSInputStream.readBuffer(DFSInputStream.java:796)
          	at org.apache.hadoop.hdfs.DFSInputStream.readWithStrategy(DFSInputStream.java:856)
          	at org.apache.hadoop.hdfs.DFSInputStream.read(DFSInputStream.java:899)
          	at org.apache.hadoop.hdfs.DFSInputStream.read(DFSInputStream.java:700)
          	at org.apache.hadoop.hdfs.TestDFSInputStream.testSkipInner(TestDFSInputStream.java:61)
          	at org.apache.hadoop.hdfs.TestDFSInputStream.testSkipWithRemoteBlockReader(TestDFSInputStream.java:76)
          
          Show
          decster Binglin Chang added a comment - Strange, the test error is caused by NoSuchMethodError, which should not happen if code is compiled successfully, is there any bug in test-patch process? java.lang.NoSuchMethodError: org.apache.hadoop.fs.FSInputChecker.readAndDiscard(I)I at org.apache.hadoop.hdfs.RemoteBlockReader.read(RemoteBlockReader.java:128) at org.apache.hadoop.hdfs.DFSInputStream$ByteArrayStrategy.doRead(DFSInputStream.java:740) at org.apache.hadoop.hdfs.DFSInputStream.readBuffer(DFSInputStream.java:796) at org.apache.hadoop.hdfs.DFSInputStream.readWithStrategy(DFSInputStream.java:856) at org.apache.hadoop.hdfs.DFSInputStream.read(DFSInputStream.java:899) at org.apache.hadoop.hdfs.DFSInputStream.read(DFSInputStream.java:700) at org.apache.hadoop.hdfs.TestDFSInputStream.testSkipInner(TestDFSInputStream.java:61) at org.apache.hadoop.hdfs.TestDFSInputStream.testSkipWithRemoteBlockReader(TestDFSInputStream.java:76)
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Looks like jenkins ran the tests in hadoop-hdfs project with hadoop-common-3.0.0-<date>.jar, which does not have FSInputChecker#readAndDiscard. I could reproduce the error by the following command:

          $ cd hadoop-hdfs-project/hadoop-hdfs
          $ mvn test -Dtest=TestDFSInputStream
          
          Show
          ajisakaa Akira Ajisaka added a comment - Looks like jenkins ran the tests in hadoop-hdfs project with hadoop-common-3.0.0-<date>.jar, which does not have FSInputChecker#readAndDiscard . I could reproduce the error by the following command: $ cd hadoop-hdfs-project/hadoop-hdfs $ mvn test -Dtest=TestDFSInputStream
          Hide
          ajisakaa Akira Ajisaka added a comment -

          +1, I ran the failed tests locally and all the tests passed. Committing this.

          Show
          ajisakaa Akira Ajisaka added a comment - +1, I ran the failed tests locally and all the tests passed. Committing this.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Committed this to trunk and branch-2. Thanks Binglin Chang for the contribution!

          Show
          ajisakaa Akira Ajisaka added a comment - Committed this to trunk and branch-2. Thanks Binglin Chang for the contribution!
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #7705 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7705/)
          HDFS-5574. Remove buffer copy in BlockReader.skip. Contributed by Binglin Chang. (aajisaka: rev e89fc53a1d264fde407dd2c36defab5241cd0b52)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestBlockReaderBase.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FSInputChecker.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestRemoteBlockReader.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSInputStream.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/RemoteBlockReader.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestRemoteBlockReader2.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/RemoteBlockReader2.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7705 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7705/ ) HDFS-5574 . Remove buffer copy in BlockReader.skip. Contributed by Binglin Chang. (aajisaka: rev e89fc53a1d264fde407dd2c36defab5241cd0b52) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestBlockReaderBase.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FSInputChecker.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestRemoteBlockReader.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSInputStream.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/RemoteBlockReader.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestRemoteBlockReader2.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/RemoteBlockReader2.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2111 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2111/)
          HDFS-5574. Remove buffer copy in BlockReader.skip. Contributed by Binglin Chang. (aajisaka: rev e89fc53a1d264fde407dd2c36defab5241cd0b52)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestRemoteBlockReader2.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestBlockReaderBase.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FSInputChecker.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestRemoteBlockReader.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/RemoteBlockReader2.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/RemoteBlockReader.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSInputStream.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2111 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2111/ ) HDFS-5574 . Remove buffer copy in BlockReader.skip. Contributed by Binglin Chang. (aajisaka: rev e89fc53a1d264fde407dd2c36defab5241cd0b52) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestRemoteBlockReader2.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestBlockReaderBase.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FSInputChecker.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestRemoteBlockReader.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/RemoteBlockReader2.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/RemoteBlockReader.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSInputStream.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #179 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/179/)
          HDFS-5574. Remove buffer copy in BlockReader.skip. Contributed by Binglin Chang. (aajisaka: rev e89fc53a1d264fde407dd2c36defab5241cd0b52)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSInputStream.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/RemoteBlockReader.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestRemoteBlockReader2.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FSInputChecker.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/RemoteBlockReader2.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestBlockReaderBase.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestRemoteBlockReader.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #179 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/179/ ) HDFS-5574 . Remove buffer copy in BlockReader.skip. Contributed by Binglin Chang. (aajisaka: rev e89fc53a1d264fde407dd2c36defab5241cd0b52) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSInputStream.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/RemoteBlockReader.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestRemoteBlockReader2.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FSInputChecker.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/RemoteBlockReader2.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestBlockReaderBase.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestRemoteBlockReader.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #170 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/170/)
          HDFS-5574. Remove buffer copy in BlockReader.skip. Contributed by Binglin Chang. (aajisaka: rev e89fc53a1d264fde407dd2c36defab5241cd0b52)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestRemoteBlockReader.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestBlockReaderBase.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/RemoteBlockReader.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/RemoteBlockReader2.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FSInputChecker.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSInputStream.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestRemoteBlockReader2.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #170 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/170/ ) HDFS-5574 . Remove buffer copy in BlockReader.skip. Contributed by Binglin Chang. (aajisaka: rev e89fc53a1d264fde407dd2c36defab5241cd0b52) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestRemoteBlockReader.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestBlockReaderBase.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/RemoteBlockReader.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/RemoteBlockReader2.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FSInputChecker.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSInputStream.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestRemoteBlockReader2.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #913 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/913/)
          HDFS-5574. Remove buffer copy in BlockReader.skip. Contributed by Binglin Chang. (aajisaka: rev e89fc53a1d264fde407dd2c36defab5241cd0b52)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/RemoteBlockReader2.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSInputStream.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FSInputChecker.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestRemoteBlockReader.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestBlockReaderBase.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestRemoteBlockReader2.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/RemoteBlockReader.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #913 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/913/ ) HDFS-5574 . Remove buffer copy in BlockReader.skip. Contributed by Binglin Chang. (aajisaka: rev e89fc53a1d264fde407dd2c36defab5241cd0b52) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/RemoteBlockReader2.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSInputStream.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FSInputChecker.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestRemoteBlockReader.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestBlockReaderBase.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestRemoteBlockReader2.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/RemoteBlockReader.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #180 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/180/)
          HDFS-5574. Remove buffer copy in BlockReader.skip. Contributed by Binglin Chang. (aajisaka: rev e89fc53a1d264fde407dd2c36defab5241cd0b52)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/RemoteBlockReader.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/RemoteBlockReader2.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestBlockReaderBase.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestRemoteBlockReader2.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestRemoteBlockReader.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSInputStream.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FSInputChecker.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #180 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/180/ ) HDFS-5574 . Remove buffer copy in BlockReader.skip. Contributed by Binglin Chang. (aajisaka: rev e89fc53a1d264fde407dd2c36defab5241cd0b52) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/RemoteBlockReader.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/RemoteBlockReader2.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestBlockReaderBase.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestRemoteBlockReader2.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestRemoteBlockReader.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSInputStream.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FSInputChecker.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2129 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2129/)
          HDFS-5574. Remove buffer copy in BlockReader.skip. Contributed by Binglin Chang. (aajisaka: rev e89fc53a1d264fde407dd2c36defab5241cd0b52)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestRemoteBlockReader.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSInputStream.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/RemoteBlockReader2.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestBlockReaderBase.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FSInputChecker.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/RemoteBlockReader.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestRemoteBlockReader2.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2129 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2129/ ) HDFS-5574 . Remove buffer copy in BlockReader.skip. Contributed by Binglin Chang. (aajisaka: rev e89fc53a1d264fde407dd2c36defab5241cd0b52) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestRemoteBlockReader.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSInputStream.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/RemoteBlockReader2.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestBlockReaderBase.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FSInputChecker.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/RemoteBlockReader.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestRemoteBlockReader2.java

            People

            • Assignee:
              decster Binglin Chang
              Reporter:
              decster Binglin Chang
            • Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development