Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-5560

Trash configuration log statements prints incorrect units

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 2.2.0
    • 2.3.0
    • None
    • None

    Description

      I ran `hdfs dfs -expunge` on a 2.2.0 system, and noticed the following the message printed out on the console:

      $ hdfs dfs -expunge
      13/11/23 22:12:17 INFO fs.TrashPolicyDefault: Namenode trash configuration: Deletion interval = 1800000 minutes, Emptier interval = 0 minutes.
      

      The configuration for both the deletion interval and emptier interval are given in minutes, converted to milliseconds and then logged as milliseconds but with a label of minutes. It looks like this was introduced in HDFS-4903.

      Attachments

        1. HDFS-5560.patch
          0.9 kB
          Josh Elser

        Activity

          elserj Josh Elser added a comment -

          Patch currently applies against branch-2.2 and trunk

          elserj Josh Elser added a comment - Patch currently applies against branch-2.2 and trunk
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12615512/HDFS-5560.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/5557//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5557//console

          This message is automatically generated.

          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12615512/HDFS-5560.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/5557//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5557//console This message is automatically generated.
          vinayakumarb Vinayakumar B added a comment -

          Thanks Josh for posting patch.
          +1, Patch looks good

          vinayakumarb Vinayakumar B added a comment - Thanks Josh for posting patch. +1, Patch looks good
          andrew.wang Andrew Wang added a comment -

          Thanks Josh, +1. Committed to trunk, branch-2, branch-2.3.

          I also added you as a contributor, so you'll be able to assign JIRAs to yourself and mark things as patch available.

          andrew.wang Andrew Wang added a comment - Thanks Josh, +1. Committed to trunk, branch-2, branch-2.3. I also added you as a contributor, so you'll be able to assign JIRAs to yourself and mark things as patch available.
          elserj Josh Elser added a comment -

          Great! Thanks, Andrew and Vinay.

          elserj Josh Elser added a comment - Great! Thanks, Andrew and Vinay.
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-trunk-Commit #4818 (See https://builds.apache.org/job/Hadoop-trunk-Commit/4818/)
          HDFS-5560. Trash configuration log statements prints incorrect units. Contributed by Josh Elser. (wang: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1547266)

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/TrashPolicyDefault.java
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #4818 (See https://builds.apache.org/job/Hadoop-trunk-Commit/4818/ ) HDFS-5560 . Trash configuration log statements prints incorrect units. Contributed by Josh Elser. (wang: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1547266 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/TrashPolicyDefault.java
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #410 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/410/)
          HDFS-5560. Trash configuration log statements prints incorrect units. Contributed by Josh Elser. (wang: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1547266)

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/TrashPolicyDefault.java
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #410 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/410/ ) HDFS-5560 . Trash configuration log statements prints incorrect units. Contributed by Josh Elser. (wang: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1547266 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/TrashPolicyDefault.java
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #1627 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1627/)
          HDFS-5560. Trash configuration log statements prints incorrect units. Contributed by Josh Elser. (wang: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1547266)

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/TrashPolicyDefault.java
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #1627 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1627/ ) HDFS-5560 . Trash configuration log statements prints incorrect units. Contributed by Josh Elser. (wang: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1547266 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/TrashPolicyDefault.java
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Hdfs-trunk #1601 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1601/)
          HDFS-5560. Trash configuration log statements prints incorrect units. Contributed by Josh Elser. (wang: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1547266)

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/TrashPolicyDefault.java
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #1601 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1601/ ) HDFS-5560 . Trash configuration log statements prints incorrect units. Contributed by Josh Elser. (wang: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1547266 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/TrashPolicyDefault.java

          People

            elserj Josh Elser
            elserj Josh Elser
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: