[HDFS-5483] NN should gracefully handle multiple block replicas on same DN

• Type: Sub-task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Heterogeneous Storage (HDFS-2832)
• Fix Version/s: 2.4.0
• Component/s: namenode
• Target Version/s: 2.4.0
• Hadoop Flags: Reviewed
• Assignee: Arpit Agarwal
• Reporter: Arpit Agarwal
• Created: 08/Nov/13 18:31
• Updated: 04/Sep/14 01:15
• Resolved: 20/Feb/14 01:47

Description

BlockManager#reportDiff can cause an assertion failure in BlockInfo#moveBlockToHead if the block report shows the same block as belonging to more than one storage.

The issue is that moveBlockToHead assumes it will find the DatanodeStorageInfo for the given block.

Exception details:

java.lang.AssertionError: Index is out of bound
        at org.apache.hadoop.hdfs.server.blockmanagement.BlockInfo.setNext(BlockInfo.java:152)
        at org.apache.hadoop.hdfs.server.blockmanagement.BlockInfo.moveBlockToHead(BlockInfo.java:351)
        at org.apache.hadoop.hdfs.server.blockmanagement.DatanodeStorageInfo.moveBlockToHead(DatanodeStorageInfo.java:243)
        at org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.reportDiff(BlockManager.java:1841)
        at org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.processReport(BlockManager.java:1709)
        at org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.processReport(BlockManager.java:1637)
        at org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.blockReport(NameNodeRpcServer.java:984)
        at org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure.testVolumeFailure(TestDataNodeVolumeFailure.java:165)

Issue Links

• relates to: HDFS-5741 BlockInfo#findDataNode can be removed