Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-2832 Enable support for heterogeneous storages in HDFS - DN as a collection of storages
  3. HDFS-5481

Fix TestDataNodeVolumeFailure

        Details

        • Type: Sub-task Sub-task
        • Status: Resolved
        • Priority: Major Major
        • Resolution: Fixed
        • Affects Version/s: Heterogeneous Storage (HDFS-2832)
        • Fix Version/s: Heterogeneous Storage (HDFS-2832)
        • Component/s: None
        • Labels:
          None
        • Hadoop Flags:
          Reviewed

          Description

          In test case, it still use datanodeID to generate storage report. Replace with storageID should work well.

          1. Text File
            HDFS-5481-v3.patch
            5 kB
            Junping Du
          2. Text File
            HDFS-5481-v2.patch
            3 kB
            Junping Du
          3. Text File
            HDFS-5481.patch
            2 kB
            Junping Du

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            Junping Du added a comment -

            Attach a quick patch and verify it fix the test failure of TestDataNodeVolumeFailure.

            Show
            Junping Du added a comment - Attach a quick patch and verify it fix the test failure of TestDataNodeVolumeFailure.
            Hide
            Permalink
            Arpit Agarwal added a comment -

            Thanks for the patch Junping.

            FsDatasetSpi#getBlockReport is going to be removed (HDFS-5429). We now use FsDatasetSpi#getBlockReports to generate per-volume block reports, example usage in TestBlockReport#getBlockReports.

            Show
            Arpit Agarwal added a comment - Thanks for the patch Junping. FsDatasetSpi#getBlockReport is going to be removed ( HDFS-5429 ). We now use FsDatasetSpi#getBlockReports to generate per-volume block reports, example usage in TestBlockReport#getBlockReports .
            Hide
            Permalink
            Junping Du added a comment -

            Thanks Arpit for review and comments! Update v2 patch.

            Show
            Junping Du added a comment - Thanks Arpit for review and comments! Update v2 patch.
            Hide
            Permalink
            Junping Du added a comment -

            Add an additional fix for TestNameNodeMetrics in v3 patch.

            Show
            Junping Du added a comment - Add an additional fix for TestNameNodeMetrics in v3 patch.
            Hide
            Permalink
            Arpit Agarwal added a comment -

            +1 for the patch. I committed it to branch HDFS-2832. Thanks for the contribution Junping!

            Show
            Arpit Agarwal added a comment - +1 for the patch. I committed it to branch HDFS-2832 . Thanks for the contribution Junping!
            Hide
            Permalink
            Junping Du added a comment -

            Oops. We are updating JIRA in the same time.
            Do you commit v2 patch or v3 patch? v3 patch add an additional fix for TestNameNodeMetrics.

            Show
            Junping Du added a comment - Oops. We are updating JIRA in the same time. Do you commit v2 patch or v3 patch? v3 patch add an additional fix for TestNameNodeMetrics.
            Hide
            Permalink
            Arpit Agarwal added a comment -

            I committed v2 just before you posted v3. I filed a separate bug for TestNameNodeMetrics (HDFS-5486).

            Show
            Arpit Agarwal added a comment - I committed v2 just before you posted v3. I filed a separate bug for TestNameNodeMetrics ( HDFS-5486 ).
            Hide
            Permalink
            Junping Du added a comment -

            Hi Arpit, Thanks for review and comments! I can deliver a split patch to fix TestNameNodeMetrics in this jira if you need.

            Show
            Junping Du added a comment - Hi Arpit, Thanks for review and comments! I can deliver a split patch to fix TestNameNodeMetrics in this jira if you need.
            Hide
            Permalink
            Junping Du added a comment -

            Ok. I will put the fix patch on HDFS-5486. Thanks!

            Show
            Junping Du added a comment - Ok. I will put the fix patch on HDFS-5486 . Thanks!

              People

              • Assignee:
                Junping Du
                Reporter:
                Junping Du
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development