[HDFS-5468] CacheAdmin help command does not recognize commands

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.3.0, 3.0.0-alpha1
• Fix Version/s: 2.3.0
• Component/s: tools
• Assignee: Stephen Chu
• Reporter: Stephen Chu
• Created: 06/Nov/13 03:53
• Updated: 12/May/16 18:13
• Resolved: 07/Nov/13 19:59

Description

Currently, the hdfs cacheadmin -help command will not recognize correct command inputs:

[hdfs@hdfs-cache ~]# hdfs cacheadmin -help listPools
Sorry, I don't know the command 'listPools'.
Valid command names are:
-addDirective, -removeDirective, -removeDirectives, -listDirectives, -addPool, -modifyPool, -removePool, -listPools, -help
[hdfs@hdfs-cache ~]# hdfs cacheadmin -help -listPools
Sorry, I don't know the command 'listPools'.
Valid command names are:
-addDirective, -removeDirective, -removeDirectives, -listDirectives, -addPool, -modifyPool, -removePool, -listPools, -help

In the code, we strip the input command of leading hyphens, but then compare it to the command names, which are all prefixed by a hyphen.

Also, cacheadmin -removeDirectives requires specifying a path with -path but -path is not shown in the usage. We should fix this as well.