Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-546

DatanodeDescriptor block iterator should be BlockInfo based rather than Block.

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.21.0
    • Fix Version/s: 0.21.0
    • Component/s: namenode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      DatanodeDescriptor.BlockIterator currently implements Iterator<Block>. I need to change it to implement Iterator<BlockInfo> instead. Otherwise, I cannot filter out blocks under construction in order to exclude them from balancing, as Hairong suggested in HDFS-517.

      1. BlockIterator.patch
        3 kB
        Konstantin Shvachko

        Issue Links

          Activity

          Hide
          Konstantin Shvachko added a comment -

          This should do.
          There is no new functionality, so no new tests is required.

          Show
          Konstantin Shvachko added a comment - This should do. There is no new functionality, so no new tests is required.
          Hide
          Hairong Kuang added a comment -

          +1

          Show
          Hairong Kuang added a comment - +1
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12416632/BlockIterator.patch
          against trunk revision 804127.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-vesta.apache.org/68/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-vesta.apache.org/68/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-vesta.apache.org/68/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-vesta.apache.org/68/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12416632/BlockIterator.patch against trunk revision 804127. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-vesta.apache.org/68/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-vesta.apache.org/68/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-vesta.apache.org/68/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-vesta.apache.org/68/console This message is automatically generated.
          Hide
          Konstantin Shvachko added a comment -

          I just committed this.

          Show
          Konstantin Shvachko added a comment - I just committed this.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #52 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/52/)
          . DatanodeDescriptor iterator blocks as BlockInfo. Contributed by Konstantin Shvachko.

          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #52 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/52/ ) . DatanodeDescriptor iterator blocks as BlockInfo. Contributed by Konstantin Shvachko.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #10 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/10/)
          . Fix a typo in CHANGES.txt

          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #10 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/10/ ) . Fix a typo in CHANGES.txt
          Hide
          Hudson added a comment -

          Integrated in Hdfs-Patch-h5.grid.sp2.yahoo.net #6 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/6/)

          Show
          Hudson added a comment - Integrated in Hdfs-Patch-h5.grid.sp2.yahoo.net #6 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/6/ )
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #70 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/70/)
          . Fix a typo in CHANGES.txt

          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #70 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/70/ ) . Fix a typo in CHANGES.txt

            People

            • Assignee:
              Konstantin Shvachko
              Reporter:
              Konstantin Shvachko
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development