[HDFS-5456] NameNode startup progress creates new steps if caller attempts to create a counter for a step that doesn't already exist.

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 2.2.0, 3.0.0-alpha1
• Fix Version/s: 2.3.0
• Component/s: namenode
• Target Version/s: 2.3.0
• Hadoop Flags: Reviewed
• Assignee: Chris Nauroth
• Reporter: Chris Nauroth
• Created: 04/Nov/13 22:15
• Updated: 12/May/16 18:12
• Resolved: 05/Nov/13 06:10

Description

NameNode startup progress is supposed to be immutable after startup has completed. All methods are coded to ignore update attempts after startup has completed. However, StartupProgress#getCounter does not implement this correctly. If a caller attempts to get a counter for a new step that hasn't been seen before, then the method accidentally creates the step. This allocates additional space in the internal tracking data structures, so ultimately this is a memory leak.

Issue Links

• relates to: HDFS-4372 Track NameNode startup progress