Details

    • Hadoop Flags:
      Reviewed

      Description

      TestReplicationPolicy: the log level checking is incorrect.

      TestBlocksScheduledCounter: HDFS-5222, which moved block schedule information from DatanodeDescriptor to DatanodeStorageInfo, is incorrect since a replica scheduled to a storage may eventually be written to another storage in the same datanode.

      1. h5452_20131103.patch
        11 kB
        Tsz Wo Nicholas Sze
      2. h5452_20131101.patch
        11 kB
        Tsz Wo Nicholas Sze

        Issue Links

          Activity

          Hide
          Tsz Wo Nicholas Sze added a comment -

          h5452_20131101.patch: fixes the tests and cleans up some code.

          Show
          Tsz Wo Nicholas Sze added a comment - h5452_20131101.patch: fixes the tests and cleans up some code.
          Hide
          Arpit Agarwal added a comment -

          +1 for the patch.

          I verified it fixes TestBlocksScheduledCounter. It looks like one test case is still failing in TestReplicationPolicy. We can fix it in a separate Jira.

          java.lang.NullPointerException: null
                  at org.apache.hadoop.hdfs.server.blockmanagement.TestReplicationPolicy.testChooseTargetWithMoreThanHalfStaleNodes(TestReplicationPolicy.java:611)
          
          Show
          Arpit Agarwal added a comment - +1 for the patch. I verified it fixes TestBlocksScheduledCounter. It looks like one test case is still failing in TestReplicationPolicy. We can fix it in a separate Jira. java.lang.NullPointerException: null at org.apache.hadoop.hdfs.server.blockmanagement.TestReplicationPolicy.testChooseTargetWithMoreThanHalfStaleNodes(TestReplicationPolicy.java:611)
          Hide
          Tsz Wo Nicholas Sze added a comment -

          Just checked TestReplicationPolicy. It did not fail in my machine. Not sure why it still fails in your case.

          Running org.apache.hadoop.hdfs.server.blockmanagement.TestReplicationPolicy
          Tests run: 24, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 13.514 sec - in org.apache.hadoop.hdfs.server.blockmanagement.TestReplicationPolicy
          
          Results :
          
          Tests run: 24, Failures: 0, Errors: 0, Skipped: 0
          
          Show
          Tsz Wo Nicholas Sze added a comment - Just checked TestReplicationPolicy. It did not fail in my machine. Not sure why it still fails in your case. Running org.apache.hadoop.hdfs.server.blockmanagement.TestReplicationPolicy Tests run: 24, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 13.514 sec - in org.apache.hadoop.hdfs.server.blockmanagement.TestReplicationPolicy Results : Tests run: 24, Failures: 0, Errors: 0, Skipped: 0
          Hide
          Tsz Wo Nicholas Sze added a comment -

          h5452_20131103.patch: updated with the branch.

          Show
          Tsz Wo Nicholas Sze added a comment - h5452_20131103.patch: updated with the branch.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          Thanks Arpit for reviewing the patch.

          I have committed this.

          Show
          Tsz Wo Nicholas Sze added a comment - Thanks Arpit for reviewing the patch. I have committed this.
          Hide
          Arpit Agarwal added a comment -

          Both tests succeed after I synced the source tree.

          Show
          Arpit Agarwal added a comment - Both tests succeed after I synced the source tree.

            People

            • Assignee:
              Tsz Wo Nicholas Sze
              Reporter:
              Tsz Wo Nicholas Sze
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development