Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.0
    • Fix Version/s: 2.5.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Update the bookkeeper dependency to 4.2.3. This eases compilation on Fedora platforms

      1. HDFS-5411.patch
        3 kB
        Rakesh R
      2. HDFS-5411.patch
        2 kB
        Robert Rati

        Issue Links

          Activity

          Hide
          rakeshr Rakesh R added a comment -

          Hi Robert, Recently Bookkeeper has released 4.2.2 version, would be good to use this stable version. Whats your opinion?

          Show
          rakeshr Rakesh R added a comment - Hi Robert, Recently Bookkeeper has released 4.2.2 version, would be good to use this stable version. Whats your opinion?
          Hide
          rrati_oss Robert Rati added a comment -

          4.2.2 causes compilation and test issues. There will need to be additional work in addition to this patch to port to 4.2.2.

          Show
          rrati_oss Robert Rati added a comment - 4.2.2 causes compilation and test issues. There will need to be additional work in addition to this patch to port to 4.2.2.
          Hide
          rakeshr Rakesh R added a comment -

          Thanks a lot for giving a try with 4.2.2. I'll take a look at this.

          Show
          rakeshr Rakesh R added a comment - Thanks a lot for giving a try with 4.2.2. I'll take a look at this.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          the later bookkeeper versions depend on HDFS-5518/ HADOOP-10101, as well as their shading protobuf to avoid protobuf version grief.

          Show
          stevel@apache.org Steve Loughran added a comment - the later bookkeeper versions depend on HDFS-5518 / HADOOP-10101 , as well as their shading protobuf to avoid protobuf version grief.
          Hide
          hadoopqa Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12653101/HDFS-5411.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/7244//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7244//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12653101/HDFS-5411.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/7244//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7244//console This message is automatically generated.
          Hide
          rakeshr Rakesh R added a comment -

          Hi Uma Maheswara Rao G, Few days back Apache BookKeeper has released 4.2.3 version successfully, which includes few important changes to make smooth integration with hadoop environment. Kindly review the patch and check this patch in. This will help us to focus on pushing the related JIRA.

          Thanks,
          Rakesh

          Show
          rakeshr Rakesh R added a comment - Hi Uma Maheswara Rao G , Few days back Apache BookKeeper has released 4.2.3 version successfully, which includes few important changes to make smooth integration with hadoop environment. Kindly review the patch and check this patch in. This will help us to focus on pushing the related JIRA. Thanks, Rakesh
          Hide
          rakeshr Rakesh R added a comment -

          Note: Since BookKeeper has done the necessary changes, its not required to have a dependency with HDFS-5518 & HADOOP-10101 JIRA issues. I'm removing these dependency links.

          Show
          rakeshr Rakesh R added a comment - Note: Since BookKeeper has done the necessary changes, its not required to have a dependency with HDFS-5518 & HADOOP-10101 JIRA issues. I'm removing these dependency links.
          Hide
          ikelly Ivan Kelly added a comment -

          change lgtm +1

          Show
          ikelly Ivan Kelly added a comment - change lgtm +1
          Hide
          umamaheswararao Uma Maheswara Rao G added a comment -

          Thanks for that patch Rakesh. Thanks a lot Ivan for the review.
          I have just committed this to trunk and branch-2.

          Show
          umamaheswararao Uma Maheswara Rao G added a comment - Thanks for that patch Rakesh. Thanks a lot Ivan for the review. I have just committed this to trunk and branch-2.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-trunk-Commit #5841 (See https://builds.apache.org/job/Hadoop-trunk-Commit/5841/)
          HDFS-5411. Update Bookkeeper dependency to 4.2.3. Contributed by Rakesh R. (umamahesh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1608781)

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal/src/main/java/org/apache/hadoop/contrib/bkjournal/BookKeeperJournalManager.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal/src/test/java/org/apache/hadoop/contrib/bkjournal/BKJMUtil.java
          • /hadoop/common/trunk/hadoop-project/pom.xml
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #5841 (See https://builds.apache.org/job/Hadoop-trunk-Commit/5841/ ) HDFS-5411 . Update Bookkeeper dependency to 4.2.3. Contributed by Rakesh R. (umamahesh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1608781 ) /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal/src/main/java/org/apache/hadoop/contrib/bkjournal/BookKeeperJournalManager.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal/src/test/java/org/apache/hadoop/contrib/bkjournal/BKJMUtil.java /hadoop/common/trunk/hadoop-project/pom.xml
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #608 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/608/)
          HDFS-5411. Update Bookkeeper dependency to 4.2.3. Contributed by Rakesh R. (umamahesh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1608781)

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal/src/main/java/org/apache/hadoop/contrib/bkjournal/BookKeeperJournalManager.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal/src/test/java/org/apache/hadoop/contrib/bkjournal/BKJMUtil.java
          • /hadoop/common/trunk/hadoop-project/pom.xml
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #608 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/608/ ) HDFS-5411 . Update Bookkeeper dependency to 4.2.3. Contributed by Rakesh R. (umamahesh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1608781 ) /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal/src/main/java/org/apache/hadoop/contrib/bkjournal/BookKeeperJournalManager.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal/src/test/java/org/apache/hadoop/contrib/bkjournal/BKJMUtil.java /hadoop/common/trunk/hadoop-project/pom.xml
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #1799 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1799/)
          HDFS-5411. Update Bookkeeper dependency to 4.2.3. Contributed by Rakesh R. (umamahesh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1608781)

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal/src/main/java/org/apache/hadoop/contrib/bkjournal/BookKeeperJournalManager.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal/src/test/java/org/apache/hadoop/contrib/bkjournal/BKJMUtil.java
          • /hadoop/common/trunk/hadoop-project/pom.xml
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #1799 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1799/ ) HDFS-5411 . Update Bookkeeper dependency to 4.2.3. Contributed by Rakesh R. (umamahesh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1608781 ) /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal/src/main/java/org/apache/hadoop/contrib/bkjournal/BookKeeperJournalManager.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal/src/test/java/org/apache/hadoop/contrib/bkjournal/BKJMUtil.java /hadoop/common/trunk/hadoop-project/pom.xml
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Mapreduce-trunk #1827 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1827/)

          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #1827 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1827/ )

            People

            • Assignee:
              rakeshr Rakesh R
              Reporter:
              rrati_oss Robert Rati
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development