Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-5375

hdfs.cmd does not expose several snapshot commands.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.0
    • Fix Version/s: 2.3.0
    • Component/s: tools
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      We need to update hdfs.cmd to expose the snapshotDiff and lsSnapshottableDir commands on Windows.

      1. HDFS-5375.1.patch
        1 kB
        Chris Nauroth

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        2m 14s 1 Chris Nauroth 16/Oct/13 22:47
        Patch Available Patch Available Resolved Resolved
        19h 32m 1 Chris Nauroth 17/Oct/13 18:19
        Resolved Resolved Closed Closed
        130d 3h 38m 1 Arun C Murthy 24/Feb/14 20:58
        Allen Wittenauer made changes -
        Fix Version/s 3.0.0 [ 12320356 ]
        Arun C Murthy made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Arun C Murthy made changes -
        Fix Version/s 2.3.0 [ 12325255 ]
        Fix Version/s 2.4.0 [ 12324588 ]
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #1582 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1582/)
        HDFS-5375. hdfs.cmd does not expose several snapshot commands. Contributed by Chris Nauroth. (cnauroth: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1533165)

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs.cmd
        Show
        Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #1582 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1582/ ) HDFS-5375 . hdfs.cmd does not expose several snapshot commands. Contributed by Chris Nauroth. (cnauroth: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1533165 ) /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs.cmd
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #1556 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1556/)
        HDFS-5375. hdfs.cmd does not expose several snapshot commands. Contributed by Chris Nauroth. (cnauroth: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1533165)

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs.cmd
        Show
        Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #1556 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1556/ ) HDFS-5375 . hdfs.cmd does not expose several snapshot commands. Contributed by Chris Nauroth. (cnauroth: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1533165 ) /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs.cmd
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk #366 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/366/)
        HDFS-5375. hdfs.cmd does not expose several snapshot commands. Contributed by Chris Nauroth. (cnauroth: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1533165)

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs.cmd
        Show
        Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #366 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/366/ ) HDFS-5375 . hdfs.cmd does not expose several snapshot commands. Contributed by Chris Nauroth. (cnauroth: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1533165 ) /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs.cmd
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in Hadoop-trunk-Commit #4623 (See https://builds.apache.org/job/Hadoop-trunk-Commit/4623/)
        HDFS-5375. hdfs.cmd does not expose several snapshot commands. Contributed by Chris Nauroth. (cnauroth: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1533165)

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs.cmd
        Show
        Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #4623 (See https://builds.apache.org/job/Hadoop-trunk-Commit/4623/ ) HDFS-5375 . hdfs.cmd does not expose several snapshot commands. Contributed by Chris Nauroth. (cnauroth: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1533165 ) /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs.cmd
        Chris Nauroth made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Fix Version/s 3.0.0 [ 12320356 ]
        Fix Version/s 2.3.0 [ 12324588 ]
        Resolution Fixed [ 1 ]
        Hide
        Chris Nauroth added a comment -

        I've committed this to trunk and branch-2. Jing, thank you for the code review.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        This was a script-only patch, so there are no automated tests. I tested the commands manually in a running Windows cluster.

        Show
        Chris Nauroth added a comment - I've committed this to trunk and branch-2. Jing, thank you for the code review. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. This was a script-only patch, so there are no automated tests. I tested the commands manually in a running Windows cluster.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12608810/HDFS-5375.1.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/5217//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5217//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12608810/HDFS-5375.1.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/5217//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5217//console This message is automatically generated.
        Hide
        Jing Zhao added a comment -

        The patch looks pretty good to me. +1

        Show
        Jing Zhao added a comment - The patch looks pretty good to me. +1
        Chris Nauroth made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Chris Nauroth made changes -
        Field Original Value New Value
        Attachment HDFS-5375.1.patch [ 12608810 ]
        Hide
        Chris Nauroth added a comment -

        Here is a patch to add the commands to the cmd file. Thanks to Ramya Sunil for finding and reporting the bug.

        Show
        Chris Nauroth added a comment - Here is a patch to add the commands to the cmd file. Thanks to Ramya Sunil for finding and reporting the bug.
        Chris Nauroth created issue -

          People

          • Assignee:
            Chris Nauroth
            Reporter:
            Chris Nauroth
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development