-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12608457/hdfs-bsd.txt
against trunk revision .

+1 @author. The patch does not contain any @author tags.

-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 eclipse:eclipse. The patch built with eclipse:eclipse.

+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

+1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

+1 contrib tests. The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/5195//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/5195//console

This message is automatically generated.

code used for -ldl detection is copied from hadoop common cmake.

seems reasonable. +1

+1 from me too. I spun up a FreeBSD VM, confirmed that libhdfs won't build, and then confirmed that it will build with this patch applied. I also checked that libhdfs still builds on Linux with this patch.

I plan to commit this later today.

-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.

No tests required, because this fixes a build problem.

I committed this to trunk and branch-2. Radim, thank you for contributing the patch. Colin, thank you for helping with code review.

SUCCESS: Integrated in Hadoop-trunk-Commit #4628 (See https://builds.apache.org/job/Hadoop-trunk-Commit/4628/)
HDFS-5365. Fix libhdfs compile error on FreeBSD9. Contributed by Radim Kolar. (cnauroth: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1533283)

• /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
• /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/CMakeLists.txt
• /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/util/posix_util.c

can be this merged to branch-2.1-beta ?

SUCCESS: Integrated in Hadoop-Yarn-trunk #366 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/366/)
HDFS-5365. Fix libhdfs compile error on FreeBSD9. Contributed by Radim Kolar. (cnauroth: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1533283)

• /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
• /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/CMakeLists.txt
• /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/util/posix_util.c

FAILURE: Integrated in Hadoop-Hdfs-trunk #1556 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1556/)
HDFS-5365. Fix libhdfs compile error on FreeBSD9. Contributed by Radim Kolar. (cnauroth: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1533283)

• /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
• /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/CMakeLists.txt
• /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/util/posix_util.c

FAILURE: Integrated in Hadoop-Mapreduce-trunk #1582 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1582/)
HDFS-5365. Fix libhdfs compile error on FreeBSD9. Contributed by Radim Kolar. (cnauroth: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1533283)

• /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
• /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/CMakeLists.txt
• /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/util/posix_util.c

can be this merged to branch-2.1-beta ?

branch-2.1-beta is closed. Now that release 2.2.0 is GA, there won't be any more releases from branch-2.1-beta. However, we can merge to branch-2.2 for inclusion in the 2.2.1 release. I'll do that later today.

I've merged this to branch-2.2 and updated attribution to release 2.2.1 in CHANGES.txt. Thanks again, Radim.

SUCCESS: Integrated in Hadoop-trunk-Commit #4629 (See https://builds.apache.org/job/Hadoop-trunk-Commit/4629/)
HDFS-5365. Move attribution to 2.2.1 in CHANGES.txt. (cnauroth: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1533574)

• /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt

SUCCESS: Integrated in Hadoop-Yarn-trunk #367 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/367/)
HDFS-5365. Move attribution to 2.2.1 in CHANGES.txt. (cnauroth: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1533574)

• /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt

FAILURE: Integrated in Hadoop-Hdfs-trunk #1557 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1557/)
HDFS-5365. Move attribution to 2.2.1 in CHANGES.txt. (cnauroth: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1533574)

• /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt

FAILURE: Integrated in Hadoop-Mapreduce-trunk #1583 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1583/)
HDFS-5365. Move attribution to 2.2.1 in CHANGES.txt. (cnauroth: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1533574)

• /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt

can be this merged into 2.2 branch?

Hi Radim,

Unfortunately, this can't be merged to branch-2.2. AFAIK, there are not any additional 2.2.x releases on the schedule, and the plan is to proceed with 2.3.x forward:

https://wiki.apache.org/hadoop/Roadmap

Therefore, if we committed code to branch-2.2 now, then it wouldn't actually go into a release.

I have confirmed that your patch is in branch-2.3 for inclusion in the 2.3.0 release, currently targeted for mid-December. If the plan changes and we decide to add another 2.2.x release on the schedule, then you could nominate this patch for inclusion and we'd commit it at that time. It seems unlikely at this point though.