[HDFS-5300] FSNameSystem#deleteSnapshot() should not check owner in case of permissions disabled

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.1.0-beta, 3.0.0-alpha1
• Fix Version/s: 2.2.0
• Component/s: namenode
• Hadoop Flags: Reviewed
• Assignee: Vinayakumar B
• Reporter: Vinayakumar B
• Created: 04/Oct/13 06:17
• Updated: 12/May/16 18:17
• Resolved: 04/Oct/13 21:19

Description

FSNameSystem#deleteSnapshot() should not check owner in case of permissions disabled

      checkOperation(OperationCategory.WRITE);
      if (isInSafeMode()) {
        throw new SafeModeException(
            "Cannot delete snapshot for " + snapshotRoot, safeMode);
      }
      FSPermissionChecker pc = getPermissionChecker();
      checkOwner(pc, snapshotRoot);

      BlocksMapUpdateInfo collectedBlocks = new BlocksMapUpdateInfo();
      List<INode> removedINodes = new ChunkedArrayList<INode>();
      dir.writeLock();

should check owner only in case of permissions enabled as its done for all other operations.