Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-529

More redundant block searches in BlockManager.

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.21.0
    • Fix Version/s: 0.21.0
    • Component/s: namenode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Found more redundant searches in BlockManager.addStoredBLock() and BlockManager.getNodes(Block).
      The pattern here is that we first call BlocksMap.numNodes(Block) in order to determine the size of the array of data-nodes. This is one search in blocksMap. Then we call BlocksMap.nodeIterator(Block), which also performs a search. This is all not necessary because we already have the block in the form of BlockInfo from blocksMap and do not need to search for it.

      1. BlocksMap.patch
        4 kB
        Konstantin Shvachko
      2. BlocksMap.patch
        4 kB
        Konstantin Shvachko

        Issue Links

          Activity

          No work has yet been logged on this issue.

            People

            • Assignee:
              Konstantin Shvachko
              Reporter:
              Konstantin Shvachko
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development