Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-529

More redundant block searches in BlockManager.

Log workAgile BoardRank to TopRank to BottomAttach filesAttach ScreenshotBulk Copy AttachmentsBulk Move AttachmentsVotersWatch issueWatchersCreate sub-taskConvert to sub-taskMoveLinkCloneLabelsUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 0.21.0
    • 0.21.0
    • namenode
    • None
    • Reviewed

    Description

      Found more redundant searches in BlockManager.addStoredBLock() and BlockManager.getNodes(Block).
      The pattern here is that we first call BlocksMap.numNodes(Block) in order to determine the size of the array of data-nodes. This is one search in blocksMap. Then we call BlocksMap.nodeIterator(Block), which also performs a search. This is all not necessary because we already have the block in the form of BlockInfo from blocksMap and do not need to search for it.

      Attachments

        1. BlocksMap.patch
          4 kB
          Konstantin Shvachko
        2. BlocksMap.patch
          4 kB
          Konstantin Shvachko

        Issue Links

        blocks

        Sub-task - The sub-task of the issue HDFS-517 Introduce BlockInfoUnderConstruction to reflect block replica states while writing.

        • Major - Major loss of function.
        • Resolved

        Activity
          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            shv Konstantin Shvachko Assign to me
            shv Konstantin Shvachko
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment