[HDFS-5264] Consider renaming StorageID

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Won't Fix
• Component/s: datanode, namenode
• Assignee: Unassigned
• Reporter: Arpit Agarwal
• Created: 25/Sep/13 23:55
• Updated: 06/Apr/15 23:05
• Resolved: 21/Jan/15 06:23

Description

We should consider renaming StorageID to something else since we have changed the meaning of the field. Previously it was used to identify the single logical storage attached to a datanode and hence it was a de-facto identifier for a Datanode. Now the StorageID identifies a single storage. To avoid confusion of meaning especially when merging with other feature branches it may be best to rename it to something else.

We can do so when merging phase 1 of the Heterogeneous Storage work into trunk.

A partial list of places to update:

1. FsVolumeSpi#storageID
2. DatanodeStorageInfo#storageID
3. DatanodeStorage#storageID
4. StorageReceivedDeletedBlocks#storageID
5. StorageReport#storageID
6. LocatedBlock#storageIDs
7. processFirstBlockReport
8. DatanodeStorage#getStorageInfo
9. TestDatanodeDescriptor#testBlocksCounter
10. TestBlockManager.java
11. FsDatasetSpi#getBlockReports

Issue Links

• is related to: HDFS-4988 Datanode must support all the volumes as individual storages
• relates to: HDFS-4378 Create a StorageID class