Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-5156

SafeModeTime metrics sometimes includes non-Safemode time.

    Details

    • Type: Bug Bug
    • Status: Patch Available
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: 2.1.0-beta, 1.2.1
    • Fix Version/s: None
    • Component/s: namenode
    • Target Version/s:

      Description

      SafeModeTime metrics shows duration in safe mode startup. However, this metrics is set to the time from FSNameSystem starts whenever safe mode leaves. In the result, executing "hdfs dfsadmin -safemode enter" and "hdfs dfsadmin -safemode leave", the metrics includes non-Safemode time.

      1. HDFS-5156.2.patch
        5 kB
        Akira AJISAKA
      2. HDFS-5156.patch
        5 kB
        Akira AJISAKA

        Activity

        Hide
        Akira AJISAKA added a comment -

        Attached a patch for SafeModeTime metrics to record "total" safemode time.
        Furthermore, the patch enables StateChangeLog to show the interval between safemode enters and leaves like below.

        13/09/03 16:35:22 INFO hdfs.StateChange: STATE* Leaving safe mode after 3 secs
        

        In trunk, it shows the interval between FSNameSystem starts and safemode leaves.

        Show
        Akira AJISAKA added a comment - Attached a patch for SafeModeTime metrics to record "total" safemode time. Furthermore, the patch enables StateChangeLog to show the interval between safemode enters and leaves like below. 13/09/03 16:35:22 INFO hdfs.StateChange: STATE* Leaving safe mode after 3 secs In trunk, it shows the interval between FSNameSystem starts and safemode leaves.
        Hide
        Akira AJISAKA added a comment -

        Add a comment to test.

        Show
        Akira AJISAKA added a comment - Add a comment to test.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12601688/HDFS-5156.2.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/4930//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4930//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12601688/HDFS-5156.2.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/4930//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4930//console This message is automatically generated.
        Hide
        Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 patch 0m 0s The patch command could not apply the patch during dryrun.



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12601688/HDFS-5156.2.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / f1a152c
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10551/console

        This message was automatically generated.

        Show
        Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 patch 0m 0s The patch command could not apply the patch during dryrun. Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12601688/HDFS-5156.2.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / f1a152c Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10551/console This message was automatically generated.

          People

          • Assignee:
            Akira AJISAKA
            Reporter:
            Akira AJISAKA
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:

              Development