Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-514

DFSClient.namenode is a public field. Should be private.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: hdfs-client
    • Labels:
      None
    • Hadoop Flags:
      Incompatible change, Reviewed
    1. hdfs-514-2.patch
      24 kB
      Bill Zeller
    2. hdfs-514-3.patch
      24 kB
      Bill Zeller

      Issue Links

        Activity

        Hide
        Tsz Wo Nicholas Sze added a comment -

        Could the fields be private final?

        Show
        Tsz Wo Nicholas Sze added a comment - Could the fields be private final?
        Hide
        Bill Zeller added a comment -

        They cannot be private final with the changes that need to be made in HDFS-167 due to the addition of ctors that needs to be made. However, it might be a better idea to leave the fields final in this patch and change them in HDFS-167.

        Show
        Bill Zeller added a comment - They cannot be private final with the changes that need to be made in HDFS-167 due to the addition of ctors that needs to be made. However, it might be a better idea to leave the fields final in this patch and change them in HDFS-167 .
        Hide
        Bill Zeller added a comment -

        *They cannot be private final due to the changes that need to be made in HDFS-167.

        Show
        Bill Zeller added a comment - *They cannot be private final due to the changes that need to be made in HDFS-167 .
        Hide
        Tsz Wo Nicholas Sze added a comment -

        > ... However, it might be a better idea to leave the fields final in this patch and change them in HDFS-167.
        I agree. Could you post a new patch?

        Show
        Tsz Wo Nicholas Sze added a comment - > ... However, it might be a better idea to leave the fields final in this patch and change them in HDFS-167 . I agree. Could you post a new patch?
        Hide
        Bill Zeller added a comment -

        I posted a new patch that only makes DFSClient.namenode private.

        Show
        Bill Zeller added a comment - I posted a new patch that only makes DFSClient.namenode private.
        Hide
        Jakob Homan added a comment -

        +1 on the patch. Looks good. Bill, Hudson is being flaky at the moment. Can you post test-patch and test results?

        Show
        Jakob Homan added a comment - +1 on the patch. Looks good. Bill, Hudson is being flaky at the moment. Can you post test-patch and test results?
        Hide
        Bill Zeller added a comment -

        [exec] There appear to be 148 release audit warnings before the patch and 148 release audit warnings after applying the patch.
        [exec] +1 overall.
        [exec] +1 @author. The patch does not contain any @author tags.
        [exec] +1 tests included. The patch appears to include 36 new or modified tests.
        [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
        [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
        [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
        [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
        [exec] Finished build.

        BUILD SUCCESSFUL
        Total time: 9 minutes 47 seconds

        "ant test" passed all tests.

        Show
        Bill Zeller added a comment - [exec] There appear to be 148 release audit warnings before the patch and 148 release audit warnings after applying the patch. [exec] +1 overall. [exec] +1 @author. The patch does not contain any @author tags. [exec] +1 tests included. The patch appears to include 36 new or modified tests. [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] Finished build. BUILD SUCCESSFUL Total time: 9 minutes 47 seconds "ant test" passed all tests.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        "Incompatible" since this changes a public API.

        Show
        Tsz Wo Nicholas Sze added a comment - "Incompatible" since this changes a public API.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        I have committed this. Thanks, Bill!

        Show
        Tsz Wo Nicholas Sze added a comment - I have committed this. Thanks, Bill!
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #35 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/35/)
        . Change DFSClient.namenode from public to private. Contributed by Bill Zeller

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #35 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/35/ ) . Change DFSClient.namenode from public to private. Contributed by Bill Zeller
        Hide
        Robert Chansler added a comment -

        Editorial pass over all release notes prior to publication of 0.21.

        Show
        Robert Chansler added a comment - Editorial pass over all release notes prior to publication of 0.21.

          People

          • Assignee:
            Bill Zeller
            Reporter:
            Bill Zeller
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development